Skip to contentSkip to conversation

net: mdio: xgene: remove useless xgene_mdio_status

PATCH Applied Russell King (Oracle) 3 participants 3 messages Aug 18, 2023 – Aug 19, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: mdio: xgene: remove useless xgene_mdio_status

xgene_mdio_status is declared static, and is only written once by the driver. It appears to have been this way since the driver was first added to the kernel tree. No other users can be found, so let's remove it.

---
 drivers/net/mdio/mdio-xgene.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/mdio/mdio-xgene.c +0 -3
index 1af7a4d9f86c..1190a793555a 100644
@@ -20,8 +20,6 @@
 #include <linux/prefetch.h>
 #include <net/ip.h>
 
-static bool xgene_mdio_status;
-
 u32 xgene_mdio_rd_mac(struct xgene_mdio_pdata *pdata, u32 rd_addr)
 {
 	void __iomem *addr, *rd, *cmd, *cmd_done;
@@ -421,7 +419,6 @@ static int xgene_mdio_probe(struct platform_device *pdev)
 		goto out_mdiobus;
 
 	pdata->mdio_bus = mdio_bus;
-	xgene_mdio_status = true;
 
 	return 0;
 
Signature · 1 line
2.30.2
#2 lore raw
In reply to Russell King (Oracle)
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Quoted 8 lines · On Fri, 18 Aug 2023 12:33:24 +0100 you wrote:

xgene_mdio_status is declared static, and is only written once by the driver. It appears to have been this way since the driver was first added to the kernel tree. No other users can be found, so let's remove it.

[...]

Here is the summary with links:
- [net-next] net: mdio: xgene: remove useless xgene_mdio_status

    https://git.kernel.org/netdev/net-next/c/44a696de720d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html