scripts/gdb: fix debugging modules on s390
Subsystems (2)
PATCH 1/1 scripts/gdb: fix debugging modules on s390
Currently lx-symbols assumes that module text is always located at module->core_layout->base, but s390 uses the following layout:
+------+ <- module->core_layout->base | GOT | +------+ <- module->core_layout->base + module->arch->plt_offset | PLT | +------+ <- module->core_layout->base + module->arch->plt_offset + | TEXT | module->arch->plt_size +------+
Therefore, when trying to debug modules on s390, all the symbol addresses are skewed by plt_offset + plt_size.
Fix by adding plt_offset + plt_size to module_addr in load_module_symbols().
--- scripts/gdb/linux/symbols.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
scripts/gdb/linux/symbols.py +7 -1
@@ -15,7 +15,7 @@ import gdb import os import re -from linux import modules +from linux import modules, utils if hasattr(gdb, 'Breakpoint'):
@@ -113,6 +113,12 @@ lx-symbols command.""" if module_file: gdb.write("loading @{addr}: {filename}\n".format( addr=module_addr, filename=module_file)) + if utils.is_target_arch('s390'): + # Module text is preceded by PLT stubs on s390. + module_arch = module['arch'] + plt_offset = int(module_arch['plt_offset']) + plt_size = int(module_arch['plt_size']) + module_addr = hex(int(module_addr, 0) + plt_offset + plt_size) cmdline = "add-symbol-file {filename} {addr}{sections}".format( filename=module_file, addr=module_addr,
Signature · 1 line
2.23.0
Jan Kiszka
maintainerQuoted 36 lines · Ilya Leoshkevich
Currently lx-symbols assumes that module text is always located at
module->core_layout->base, but s390 uses the following layout:+------+ <- module->core_layout->base | GOT | +------+ <- module->core_layout->base + module->arch->plt_offset | PLT | +------+ <- module->core_layout->base + module->arch->plt_offset + | TEXT | module->arch->plt_size +------+Therefore, when trying to debug modules on s390, all the symbol addresses are skewed by
plt_offset+plt_size.Fix by adding
plt_offset+plt_sizetomodule_addrinload_module_symbols().Signed-off-by Ilya Leoshkevich <[email protected]>--- scripts/gdb/linux/symbols.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)scripts/gdb/linux/symbols.py +1
-1@@ -15,7 +15,7 @@ import gdb import os import re -from linux import modules +from linux import modules, utils if hasattr(gdb, 'Breakpoint'):
scripts/gdb/linux/symbols.py lx-symbols command.""" · line 121
Quoted 9 lines
scripts/gdb/linux/symbols.py +6
-0@@ -113,6 +113,12 @@ lx-symbols command.""" if module_file: gdb.write("loading @{addr}: {filename}\n".format( addr=module_addr, filename=module_file)) + if utils.is_target_arch('s390'): + # Module text is preceded by PLT stubs on s390. + module_arch = module['arch'] + plt_offset = int(module_arch['plt_offset']) + plt_size = int(module_arch['plt_size']) + module_addr = hex(int(module_addr, 0) + plt_offset + plt_size)
Shouldn't we report the actual address above, ie. reorder this tuning with the gdb.write?
scripts/gdb/linux/symbols.py lx-symbols command.""" · line 124
Quoted 4 lines
scripts/gdb/linux/symbols.py +0
-0cmdline = "add-symbol-file {filename} {addr}{sections}".format( filename=module_file, addr=module_addr,
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
Quoted 15 lines
Am 15.10.2019 um 17:21 schrieb Jan Kiszka <[email protected]>:
scripts/gdb/linux/symbols.py lx-symbols command.""" · line 121
Quoted 10 lines
scripts/gdb/linux/symbols.py +6
-0@@ -113,6 +113,12 @@ lx-symbols command.""" if module_file: gdb.write("loading @{addr}: {filename}\n".format( addr=module_addr, filename=module_file)) + if utils.is_target_arch('s390'): + # Module text is preceded by PLT stubs on s390. + module_arch = module['arch'] + plt_offset = int(module_arch['plt_offset']) + plt_size = int(module_arch['plt_size']) + module_addr = hex(int(module_addr, 0) + plt_offset + plt_size)Shouldn't we report the actual address above, ie. reorder this tuning with the gdb.write?
That's a tough question. I thought about this, and the argument for showing the fixed up address is that if someone does the math with symbol offsets from e.g. objdump, the result will be consistent with what gdb shows.
On the other hand side, why would anyone do this? that's exactly what this gdb script is for. So showing the actual address at which the memory was allocated gives the user some additional information, and is also consistent with what cat /proc/modules would show.
At the end of the day, I don't have a strong opinion on this, so if you think it's better to show the fixed up address, I'll send a v2.
Best regards,
Ilya
Jan Kiszka
maintainerQuoted 21 lines · Ilya Leoshkevich
Quoted 15 lines
Am 15.10.2019 um 17:21 schrieb Jan Kiszka <[email protected]>:
scripts/gdb/linux/symbols.py lx-symbols command.""" · line 121
Quoted 10 lines
scripts/gdb/linux/symbols.py +6
-0@@ -113,6 +113,12 @@ lx-symbols command.""" if module_file: gdb.write("loading @{addr}: {filename}\n".format( addr=module_addr, filename=module_file)) + if utils.is_target_arch('s390'): + # Module text is preceded by PLT stubs on s390. + module_arch = module['arch'] + plt_offset = int(module_arch['plt_offset']) + plt_size = int(module_arch['plt_size']) + module_addr = hex(int(module_addr, 0) + plt_offset + plt_size)Shouldn't we report the actual address above, ie. reorder this tuning with the gdb.write?
That's a tough question. I thought about this, and the argument for showing the fixed up address is that if someone does the math with symbol offsets from e.g. objdump, the result will be consistent with what gdb shows.
Quoted 7 lines
On the other hand side, why would anyone do this? that's exactly what this gdb script is for. So showing the actual address at which the memory was allocated gives the user some additional information, and is also consistent with what cat
/proc/moduleswould show.At the end of the day, I don't have a strong opinion on this, so if you think it's better to show the fixed up address, I'll send a v2.
One of the original ideas of the printout was to provide the information needed to reproduce potential issues manually. From that perspective, the fixed-up address would the the thing to print.
If you think the vanilla address has some value as well, we could make an s390-specifi printout of both values.
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux