mtd: rawnand: ingenic: Fix missing put_device in ingenic_ecc_get
Subsystems (5)
PATCH 1/1 mtd: rawnand: ingenic: Fix missing put_device in ingenic_ecc_get
If of_find_device_by_node() succeeds, ingenic_ecc_get() doesn't have a corresponding put_device(). Thus add put_device() to fix the exception handling.
--- drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/mtd/nand/raw/ingenic/ingenic_ecc.c +6 -1
@@ -68,9 +68,14 @@ static struct ingenic_ecc *ingenic_ecc_get(struct device_node *np)struct ingenic_ecc *ecc; pdev =of_find_device_by_node (np); -if (!pdev || !platform_get_drvdata (pdev)) +if (!pdev)return ERR_PTR (-EPROBE_DEFER ); +if (!platform_get_drvdata (pdev)) { +put_device (&pdev->dev); +return ERR_PTR (-EPROBE_DEFER ); + } + ecc =platform_get_drvdata (pdev);clk_prepare_enable (ecc->clk);
Signature · 1 line
2.17.1
Hi,
Quoted 6 lines · Miaoqian Lin
If
of_find_device_by_node()succeeds,ingenic_ecc_get()doesn't have a correspondingput_device(). Thus addput_device()to fix the exception handling.Fixes 15de8c6 ("mtd: rawnand: ingenic: Separate top-level and SoC specific code")Signed-off-by Miaoqian Lin <[email protected]>
Cheers,
-Paul
Quoted 28 lines
--- drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/mtd/nand/raw/ingenic/ingenic_ecc.c +6
-2@@ -68,9 +68,14 @@ static struct ingenic_ecc *ingenic_ecc_get(struct device_node *np)struct ingenic_ecc *ecc; pdev =of_find_device_by_node (np); -if (!pdev || !platform_get_drvdata (pdev)) +if (!pdev)return ERR_PTR (-EPROBE_DEFER ); +if (!platform_get_drvdata (pdev)) { +put_device (&pdev->dev); +return ERR_PTR (-EPROBE_DEFER ); + } + ecc =platform_get_drvdata (pdev);clk_prepare_enable (ecc->clk); --2.17.1
Quoted 7 lines · Miaoqian Lin
If
of_find_device_by_node()succeeds,ingenic_ecc_get()doesn't have a correspondingput_device(). Thus addput_device()to fix the exception handling.Fixes 15de8c6 ("mtd: rawnand: ingenic: Separate top-level and SoC specific code")Signed-off-by Miaoqian Lin <[email protected]>Reviewed-by Paul Cercueil <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
Miquel Raynal
maintainer[email protected] wrote on Sun, 23 Jan 2022 16:23:32 +0100:
Quoted 10 lines · Miaoqian Lin
Quoted 7 lines
If
of_find_device_by_node()succeeds,ingenic_ecc_get()doesn't have a correspondingput_device(). Thus addput_device()to fix the exception handling.Fixes 15de8c6 ("mtd: rawnand: ingenic: Separate top-level and SoC specific code")Signed-off-by Miaoqian Lin <[email protected]>Reviewed-by Paul Cercueil <[email protected]>Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Pushed on mtd/fixes, actually.