Skip to contentSkip to conversation

ALC286 recording delay

PATCH Kailang 2 participants 2 messages Jun 30, 2014 – Jul 4, 2014 2 messages not in the archive Sound

lore
Share & tools
lore

Kailang

author
#0 lore raw

Hi Takashi,

It will be recording voice delay for resume back recording for Headset Mic. This patch doesn't disable pin for suspend state. The issue was fixed. This is follow ALC286 programing guide.

Thanks.

BR,
Kailang

Quoted 1 line

From 5d7ae195257daaffa1497d2c79d06aa01b9754b0 Mon Sep 17 00:00:00 2001

From: Kailang Yang <[email protected]>
Date: Mon, 30 Jun 2014 16:10:37 +0800
Subject: [PATCH] ALSA: hda/realtek - Fixed ALC286/ALC288 recording delay for
Headset Mic

It will be recording voice delay for resume back recording for Headset Mic. This patch doesn't disable pin for suspend state. The issue was fixed. This is follow ALC286 programing guide.

sound/pci/hda/patch_realtek.c +20 -0
index 60bf5ee..13cdefb 100644
@@ -2782,6 +2782,25 @@ static int alc269_parse_auto_config(struct hda_codec *codec)
 	return alc_parse_auto_config(codec, alc269_ignore, ssids);
 }
 
+void alc_snd_hda_shutup_pins(struct hda_codec *codec)
+{
+	int i;
+	int mic_pin = find_ext_mic_pin(codec);
+	/* don't shut up pins when unloading the driver; otherwise it breaks
+	 * the default pin setup at the next load of the driver
+	 */
+	if (codec->bus->shutdown)
+		return;
+	for (i = 0; i < codec->init_pins.used; i++) {
+		struct hda_pincfg *pin = snd_array_elem(&codec->init_pins, i);
+		/* use read here for syncing after issuing each verb */
+		if (pin->nid != mic_pin)
+			snd_hda_codec_read(codec, pin->nid, 0,
+					AC_VERB_SET_PIN_WIDGET_CONTROL, 0);
+	}
+	codec->pins_shutup = 1;
+}
+
 static void alc269vb_toggle_power_output(struct hda_codec *codec, int power_up)
 {
 	int val = alc_read_coef_idx(codec, 0x04);
@@ -5326,6 +5345,7 @@ static int patch_alc269(struct hda_codec *codec)
 	case 0x10ec0286:
 	case 0x10ec0288:
 		spec->codec_variant = ALC269_TYPE_ALC286;
+		spec->shutup = alc_snd_hda_shutup_pins;
 		break;
 	case 0x10ec0255:
 		spec->codec_variant = ALC269_TYPE_ALC255;

A message that is not in the archive (sent off-list or not yet received): s5hvbrisr8r.wl%[email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

At Thu, 3 Jul 2014 15:30:17 +0800,

Quoted 12 lines · Kailang
Quoted 12 lines

At Mon, 30 Jun 2014 16:25:46 +0800,

Quoted 7 lines · Kailang

Hi Takashi,

It will be recording voice delay for resume back recording for Headset Mic.
This patch doesn't disable pin for suspend state. The issue was fixed. This is follow ALC286 programing guide.

Quoted 5 lines
Quoted 2 lines

Please make alc_snd_hda_shutup_pins() static and name it a bit more specific.

Could you have idea for the name?
alc_shutup_pins()

The name can indicate the purpose, e.g. alc_shutup_pins_except_extmic().

Quoted 5 lines
Quoted 3 lines

Also, it'd be helpful if you explain a bit more *why* this fixes the recording voice delay.

Our AE try to tune the mic cap to clear issue.
But he say, keep MIC input enable will be better.

But for which purpose should we keep MIC input? This should be more elaborated.

Takashi