arm64/xen: Consider alignment calling grub_arch_efi_linux_boot_image
PATCH 1/1 arm64/xen: Consider alignment calling grub_arch_efi_linux_boot_image
The Xen image is loaded alignment, not always at "start".
--- grub-core/loader/arm64/xen_boot.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
grub-core/loader/arm64/xen_boot.c +7 -3
@@ -247,13 +247,17 @@ fail:static grub_err_t xen_boot (void ) { +grub_addr_t start; +grub_err_t err =finalize_params_xen_boot ();if (err)return err; -return grub_arch_efi_linux_boot_image (xen_hypervisor->start, - xen_hypervisor->size, - xen_hypervisor->cmdline); + start =xen_boot_address_align (xen_hypervisor->start, + xen_hypervisor->align); +return grub_arch_efi_linux_boot_image (start, + xen_hypervisor->size, + xen_hypervisor->cmdline); } static void
Signature · 7 lines
2.43.0 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
Quoted 20 lines · Frediano Ziglio via Grub-devel
The Xen image is loaded alignment, not always at "start".
Signed-off-by Frediano Ziglio <[email protected]>---
grub-core/loader/arm64/xen_boot.c| 10 +++++++---1 file changed, 7 insertions(+), 3 deletions(-)grub-core/loader/arm64/xen_boot.c +0
-0@@ -247,13 +247,17 @@ fail:static
grub_err_txen_boot(void)
{grub-core/loader/arm64/xen_boot.c +1
-0+grub_addr_t start;
grub-core/loader/arm64/xen_boot.c fail: · line 257
Quoted 10 lines
grub-core/loader/arm64/xen_boot.c +3
-3+grub_err_t err =finalize_params_xen_boot ();if (err)return err; -return grub_arch_efi_linux_boot_image (xen_hypervisor->start, - xen_hypervisor->size, - xen_hypervisor->cmdline); + start =xen_boot_address_align (xen_hypervisor->start, + xen_hypervisor->align);
it would be better like below
start = xen_boot_address_align (xen_hypervisor->start, xen_hypervisor->align);
grub-core/loader/arm64/xen_boot.c fail: · line 260
Quoted 3 lines
grub-core/loader/arm64/xen_boot.c +3
-0+return grub_arch_efi_linux_boot_image (start, + xen_hypervisor->size, + xen_hypervisor->cmdline);
Something is off with indention here
Thanks,
Sudhakar
Quoted 11 lines
}
static void
Signature · 7 lines
2.43.0 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
Quoted 34 lines · Sudhakar Kuppusamy
Quoted 21 lines · Frediano Ziglio via Grub-devel
The Xen image is loaded alignment, not always at "start".
Signed-off-by Frediano Ziglio <[email protected]>---
grub-core/loader/arm64/xen_boot.c| 10 +++++++---1 file changed, 7 insertions(+), 3 deletions(-)grub-core/loader/arm64/xen_boot.c +0
-0@@ -247,13 +247,17 @@ fail:static
grub_err_txen_boot(void)
{grub-core/loader/arm64/xen_boot.c +1
-0+grub_addr_t start;grub-core/loader/arm64/xen_boot.c fail: · line 257
Quoted 10 lines
grub-core/loader/arm64/xen_boot.c +3
-3+grub_err_t err =finalize_params_xen_boot ();if (err)return err; -return grub_arch_efi_linux_boot_image (xen_hypervisor->start, - xen_hypervisor->size, - xen_hypervisor->cmdline); + start =xen_boot_address_align (xen_hypervisor->start, + xen_hypervisor->align);it would be better like below
Quoted 2 lines
start =
xen_boot_address_align(xen_hypervisor->start,xen_hypervisor->align);
I can do it, it looks like the line is exactly 80 characters.
Quoted 8 lines
grub-core/loader/arm64/xen_boot.c fail: · line 260
Quoted 4 lines
grub-core/loader/arm64/xen_boot.c +3
-0+return grub_arch_efi_linux_boot_image (start, + xen_hypervisor->size, + xen_hypervisor->cmdline);Something is off with indention here
I'm not really familiar with GNU style however I think it's correct. The code should be indented with 8 space tabs. The "xen_hypervisor..." lines are exactly under "start,".
Quoted 5 lines
Thanks,
SudhakarQuoted 3 lines
}
static void
Frediano
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
Quoted 3 lines · Frediano Ziglio via Grub-devel
The Xen image is loaded alignment, not always at "start".
Signed-off-by Frediano Ziglio <[email protected]>
Daniel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
Quoted 8 lines · Frediano Ziglio via Grub-devel
The Xen image is loaded alignment, not always at "start".
Signed-off-by Frediano Ziglio <[email protected]>---
Quoted 27 lines
grub-core/loader/arm64/xen_boot.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)grub-core/loader/arm64/xen_boot.c +0
-0@@ -247,13 +247,17 @@ fail:static
grub_err_txen_boot(void)
{grub-core/loader/arm64/xen_boot.c +7
-3+grub_addr_t start; +grub_err_t err =finalize_params_xen_boot ();if (err)return err; -return grub_arch_efi_linux_boot_image (xen_hypervisor->start, - xen_hypervisor->size, - xen_hypervisor->cmdline); + start =xen_boot_address_align (xen_hypervisor->start, + xen_hypervisor->align); +return grub_arch_efi_linux_boot_image (start, + xen_hypervisor->size, + xen_hypervisor->cmdline);}
Quoted 9 lines
static void
Signature · 7 lines
2.43.0 _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel