Skip to contentSkip to conversation

Fix compilation error if CONFIG_USB is disabled

PATCH Superseded Matthias Brugger 3 participants 5 messages Apr 16, 2019 – May 9, 2019 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH v2 1/2 Fix compilation error if CONFIG_USB is disabled

Quoted 8 lines · akaher

There are compilation errors, if CONFIG_CMD_USB is enabled and CONFIG_USB is disabled.

CONFIG_CMD_USB depends upon CONFIG_USB, so CONFIG_CMD_USB should not be enabled if CONFIG_USB is disabled.

Quoted 17 lines
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
cmd/Kconfig +1 -0
index 4bcc5c4557..96e665a1c9 100644
@@ -1059,6 +1059,7 @@ config CMD_UNIVERSE
 config CMD_USB
 	bool "usb"
 	select HAVE_BLOCK_DEVICE
+	depends on USB
 	help
 	  USB support.
 
#3 lore raw

v2 cover Fix compilation error if CONFIG_USB is disabled

In reply to a message not in the archive

Tom, [PATCH v2 1/2] reviewed by 'Matthias Brugger'.
But no update on [Patch v2 2/2] (includes changes in include/configs/rpi.h)

- Ajay

On 11/04/19, 10:56 AM, "akaher" <[email protected]> wrote:

Fix compilation error if CONFIG_USB is disabled

[Patch v2 1/2]:
CONFIG_CMD_USB depends upon CONFIG_USB, so CONFIG_CMD_USB should not be enabled if CONFIG_USB is disabled.

[Patch v2 2/2]:
This patch is to fix the following compilation error when disabling CONFIG_USB for Rpi3:

include/config_distro_bootcmd.h:242:2: error: expected ‘}’ before ‘BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB’
BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB

Changes from v1:
Split the patch.

cmd/Kconfig | 1 +
include/configs/rpi.h | 36 +++++++++++++++++++++++++++++++-----

2 file changed, 32 insertions(+), 5 deletions(-)

--
2.14.2

#4 lore raw

v2 cover Fix compilation error if CONFIG_USB is disabled

Quoted 3 lines · Ajay Kaher

Tom, [PATCH v2 1/2] reviewed by 'Matthias Brugger'.
But no update on [Patch v2 2/2] (includes changes in include/configs/rpi.h)

Since Matthias is the Pi custodian, I'm expecting a PR from him with the changes. Thanks!

Quoted 35 lines

- Ajay

On 11/04/19, 10:56 AM, "akaher" <[email protected]> wrote:

Fix compilation error if CONFIG_USB is disabled

[Patch v2 1/2]:
CONFIG_CMD_USB depends upon CONFIG_USB, so CONFIG_CMD_USB should not be enabled if CONFIG_USB is disabled.

[Patch v2 2/2]:
This patch is to fix the following compilation error when disabling CONFIG_USB for Rpi3:

include/config_distro_bootcmd.h:242:2: error: expected ‘}’ before ‘BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB’
BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB

Changes from v1:
Split the patch.

cmd/Kconfig | 1 +
include/configs/rpi.h | 36 +++++++++++++++++++++++++++++++-----

2 file changed, 32 insertions(+), 5 deletions(-)

--
2.14.2

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190425/8ef0a4da/attachment.sig>
#5 lore raw

v2 cover Fix compilation error if CONFIG_USB is disabled

Quoted 7 lines · Tom Rini
Quoted 3 lines · Ajay Kaher

Tom, [PATCH v2 1/2] reviewed by 'Matthias Brugger'.
But no update on [Patch v2 2/2] (includes changes in include/configs/rpi.h)

Since Matthias is the Pi custodian, I'm expecting a PR from him with the changes. Thanks!

Matthias, please let me know if you would require any info or detail from me to review [Patch v2 2/2]. To create the [Patch v2 2/2], I have taken the reference of include/configs/rockchip-common.h. Same changes are already present in include/configs/rockchip-common.h, hope this will help you to do review and PR. Thanks.

- Ajay

Quoted 31 lines
Quoted 31 lines

On 11/04/19, 10:56 AM, "akaher" <[email protected]> wrote:

Fix compilation error if CONFIG_USB is disabled

[Patch v2 1/2]:
CONFIG_CMD_USB depends upon CONFIG_USB, so CONFIG_CMD_USB should not be enabled if CONFIG_USB is disabled.

[Patch v2 2/2]:
This patch is to fix the following compilation error when disabling CONFIG_USB for Rpi3:

include/config_distro_bootcmd.h:242:2: error: expected ‘}’ before ‘BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB’
BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB

Changes from v1:
Split the patch.

cmd/Kconfig | 1 +
include/configs/rpi.h | 36 +++++++++++++++++++++++++++++++-----

2 file changed, 32 insertions(+), 5 deletions(-)

--
2.14.2

#6 lore raw

v2 cover Fix compilation error if CONFIG_USB is disabled

Hi Ajay,

Quoted 9 lines · Ajay Kaher
Quoted 5 lines · Tom Rini
Quoted 3 lines · Ajay Kaher

Tom, [PATCH v2 1/2] reviewed by 'Matthias Brugger'.
But no update on [Patch v2 2/2] (includes changes in include/configs/rpi.h)

Quoted 8 lines
Quoted 2 lines

Since Matthias is the Pi custodian, I'm expecting a PR from him with the changes. Thanks!

Matthias, please let me know if you would require any info or detail from me to review [Patch v2 2/2]. To create the [Patch v2 2/2], I have taken the reference of include/configs/rockchip-common.h. Same changes are already present in include/configs/rockchip-common.h, hope this will help you to do review and PR. Thanks.

It's on my list. On the first look it seems good for me. Bear with me, I'll take it netxt week and push it out.

Regards,
Matthias

Quoted 35 lines

- Ajay

Quoted 31 lines
Quoted 31 lines

On 11/04/19, 10:56 AM, "akaher" <[email protected]> wrote:

Fix compilation error if CONFIG_USB is disabled

[Patch v2 1/2]:
CONFIG_CMD_USB depends upon CONFIG_USB, so CONFIG_CMD_USB should not be enabled if CONFIG_USB is disabled.

[Patch v2 2/2]:
This patch is to fix the following compilation error when disabling CONFIG_USB for Rpi3:

include/config_distro_bootcmd.h:242:2: error: expected ‘}’ before ‘BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB’
BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB

Changes from v1:
Split the patch.

cmd/Kconfig | 1 +
include/configs/rpi.h | 36 +++++++++++++++++++++++++++++++-----

2 file changed, 32 insertions(+), 5 deletions(-)

--
2.14.2