Skip to contentSkip to conversation

resize2fs: trim resize to cluster boundary

PATCH Applied Kiselev, Oleg 2 participants 2 messages May 14, 2022 – Aug 11, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 resize2fs: trim resize to cluster boundary

This patch rounds down the size provided to resize2fs to the nearest cluster boundary for bigalloc filesystems. This is similar to the trimming already done for page boundary alignment. Aligning the size in the user space provides the right value feedback from the resize2fs command, which is a better user experience than trimming the size in the kernel.

---
 resize/main.c | 6 ++++++
 1 file changed, 6 insertions(+)
resize/main.c +6 -0
index bceaa1677e21..93a1d5a260e1 100644
@@ -537,6 +537,12 @@ int main (int argc, char ** argv)
 			goto errout;
 		}
 	}
+
+	/* If using cluster allocations, trim down to a cluster boundary */
+	if (ext2fs_has_feature_bigalloc(fs->super)) {
+		new_size &= ~((blk64_t)(1 << fs->cluster_ratio_bits) - 1);
+	}
+
 	new_group_desc_count = ext2fs_div64_ceil(new_size -
 				fs->super->s_first_data_block,
 						 EXT2_BLOCKS_PER_GROUP(fs->super));

--
2.32.0

#1 lore raw
Quoted 8 lines · Oleg

This patch rounds down the size provided to resize2fs to the nearest cluster boundary for bigalloc filesystems. This is similar to the trimming already done for page boundary alignment. Aligning the size in the user space provides the right value feedback from the resize2fs command, which is a better user experience than trimming the size in the kernel.

[...]

Applied, thanks!

[1/1] resize2fs: trim resize to cluster boundary

      commit: b609d01e6d200638aad42adee922f91d91e3e642

Best regards,

Signature · 1 line
Theodore Ts'o <[email protected]>