Skip to contentSkip to conversation

Systemd 209

PATCH In review Khem Raj 6 participants 23 messages Feb 20, 2014 – Feb 26, 2014

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

cover Systemd 209

This patchset upgrades systemd to 209 as can be seen some enahancements to uclibc were neeed. As of now. It builds for me on both uclibc/eglibc Please test it out in your setups and report back any issues

The following changes since commit 9a98b8bfe13b94d89a9e39cca821f26fdeaeffc3:

image_types.bbclass: Fix tar IMAGE_CMD to not change directories (2014-02-18 08:37:03 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-209
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-209

Khem Raj (2):
uclibc: Add new functionality needed for systemd 209
systemd: Upgrade 208 -> 209

 ...-Use-bin-mkdir-instead-of-host-mkdir-path.patch |  31 --
 ...1-uClibc-doesn-t-implement-pwritev-preadv.patch |  15 +-
 ...ournal-Add-missing-byte-order-conversions.patch |  60 ----
 .../journal-file-protect-against-alloca-0.patch    |  23 --
 ...n-appending-to-journal-file-allocate-larg.patch |  83 -----
 .../systemd/journald-add-missing-error-check.patch |  16 -
 .../systemd/systemd/systemd-pam-fix-execvpe.patch  |  22 +-
 .../systemd/systemd-pam-fix-fallocate.patch        |  24 +-
 .../systemd/systemd-pam-fix-getty-unit.patch       |  20 +-
 .../systemd/systemd/systemd-pam-fix-mkostemp.patch | 166 +--------
 .../systemd/systemd/systemd-pam-fix-msformat.patch | 115 ++++---
 .../systemd/systemd/uclibc-sysinfo_h.patch         |  19 ++
 .../systemd/{systemd_208.bb => systemd_209.bb}     |  14 +-
 meta/recipes-core/uclibc/uclibc-git.inc            |   3 +
 .../0001-Add-eventfd_read-and-eventfd_write.patch  | 120 +++++++
 .../uclibc-git/0002-wire-setns-syscall.patch       |  68 ++++
 ...tl.h-Define-F_SETPIPE_SZ-and-F_GETPIPE_SZ.patch | 377 +++++++++++++++++++++
 17 files changed, 702 insertions(+), 474 deletions(-)
 delete mode 100644 meta/recipes-core/systemd/systemd/0001-Use-bin-mkdir-instead-of-host-mkdir-path.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journal-Add-missing-byte-order-conversions.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journal-file-protect-against-alloca-0.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journal-when-appending-to-journal-file-allocate-larg.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journald-add-missing-error-check.patch
 create mode 100644 meta/recipes-core/systemd/systemd/uclibc-sysinfo_h.patch
 rename meta/recipes-core/systemd/{systemd_208.bb => systemd_209.bb} (96%)
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0001-Add-eventfd_read-and-eventfd_write.patch
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0002-wire-setns-syscall.patch
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0003-fcntl.h-Define-F_SETPIPE_SZ-and-F_GETPIPE_SZ.patch
Signature · 1 line
1.9.0
#1 lore raw
Quoted 35 lines · Khem Raj

This patchset upgrades systemd to 209 as can be seen some enahancements to uclibc were neeed. As of now. It builds for me on both uclibc/eglibc Please test it out in your setups and report back any issues

The following changes since commit 9a98b8bfe13b94d89a9e39cca821f26fdeaeffc3:

   image_types.bbclass: Fix tar IMAGE_CMD to not change directories (2014-02-18 08:37:03 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-209
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-209

Khem Raj (2):
uclibc: Add new functionality needed for systemd 209
systemd: Upgrade 208 -> 209

  ...-Use-bin-mkdir-instead-of-host-mkdir-path.patch |  31 --
  ...1-uClibc-doesn-t-implement-pwritev-preadv.patch |  15 +-
  ...ournal-Add-missing-byte-order-conversions.patch |  60 ----
  .../journal-file-protect-against-alloca-0.patch    |  23 --
  ...n-appending-to-journal-file-allocate-larg.patch |  83 -----
  .../systemd/journald-add-missing-error-check.patch |  16 -
  .../systemd/systemd/systemd-pam-fix-execvpe.patch  |  22 +-
  .../systemd/systemd-pam-fix-fallocate.patch        |  24 +-
  .../systemd/systemd-pam-fix-getty-unit.patch       |  20 +-
  .../systemd/systemd/systemd-pam-fix-mkostemp.patch | 166 +--------
  .../systemd/systemd/systemd-pam-fix-msformat.patch | 115 ++++---
  .../systemd/systemd/uclibc-sysinfo_h.patch         |  19 ++
  .../systemd/{systemd_208.bb => systemd_209.bb}     |  14 +-
  meta/recipes-core/uclibc/uclibc-git.inc            |   3 +
  .../0001-Add-eventfd_read-and-eventfd_write.patch  | 120 +++++++
  .../uclibc-git/0002-wire-setns-syscall.patch       |  68 ++++
  ...tl.h-Define-F_SETPIPE_SZ-and-F_GETPIPE_SZ.patch | 377 +++++++++++++++++++++
  17 files changed, 702 insertions(+), 474 deletions(-)
Quoted 11 lines

delete mode 100644 meta/recipes-core/systemd/systemd/0001-Use-bin-mkdir-instead-of-host-mkdir-path.patch delete mode 100644 meta/recipes-core/systemd/systemd/journal-Add-missing-byte-order-conversions.patch delete mode 100644 meta/recipes-core/systemd/systemd/journal-file-protect-against-alloca-0.patch delete mode 100644 meta/recipes-core/systemd/systemd/journal-when-appending-to-journal-file-allocate-larg.patch delete mode 100644 meta/recipes-core/systemd/systemd/journald-add-missing-error-check.patch create mode 100644 meta/recipes-core/systemd/systemd/uclibc-sysinfo_h.patch
rename meta/recipes-core/systemd/{systemd_208.bb => systemd_209.bb} (96%)
create mode 100644 meta/recipes-core/uclibc/uclibc-git/0001-Add-eventfd_read-and-eventfd_write.patch create mode 100644 meta/recipes-core/uclibc/uclibc-git/0002-wire-setns-syscall.patch
create mode 100644 meta/recipes-core/uclibc/uclibc-git/0003-fcntl.h-Define-F_SETPIPE_SZ-and-F_GETPIPE_SZ.patch

Seems like there might be an issue with ptest when I built this on the AB, it might be build vs src dir split?

Quoted 11 lines

NOTE: Running task 5039 of 5679 (ID: 3843, /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/meta/recipes-support/libcroco/libcroco_0.6.8.bb, do_package_write_ipk)
ERROR: Function failed: do_install_ptest_base (log file is located at /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/build/tmp/work/core2-64-poky-linux/systemd/1_209-r0/temp/log.do_install_ptest_base.24377)
ERROR: Logfile of failure stored in: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/build/tmp/work/core2-64-poky-linux/systemd/1_209-r0/temp/log.do_install_ptest_base.24377 Log data follows:

| DEBUG: SITE files ['endian-little', 'common-linux', 'common-glibc', 'bit-64', 'x86_64-linux', 'common']
| DEBUG: Executing shell function do_install_ptest_base
| cp: cannot stat '/home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/build/tmp/work/core2-64-poky-linux/systemd/1_209-r0/build/rules': No such file or directory
| WARNING: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/build/tmp/work/core2-64-poky-linux/systemd/1_209-r0/temp/run.do_install_ptest_base.24377:1 exit 1 from
|   cp -rf /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/build/tmp/work/core2-64-poky-linux/systemd/1_209-r0/build/rules /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/build/tmp/work/core2-64-poky-linux/systemd/1_209-r0/image/usr/lib/systemd/ptest/
| ERROR: Function failed: do_install_ptest_base (log file is located at /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-qa-systemd/build/build/tmp/work/core2-64-poky-linux/systemd/1_209-r0/temp/log.do_install_ptest_base.24377)

NOTE: recipe systemd-1_209-r0: task do_install_ptest_base: Failed

Sau!

author
#2 lore raw
Quoted 2 lines · Saul Wold

Seems like there might be an issue with ptest when I built this on the AB, it might be build vs src dir split?

hmmm, could be. but there are more rutime issues as this point, I am waiting for 210 release which should happen soon

#3 lore raw
In reply to Khem Raj
Quoted 8 lines · Khem Raj

This patchset upgrades systemd to 209 as can be seen some enahancements to uclibc were neeed. As of now. It builds for me on both uclibc/eglibc Please test it out in your setups and report back any issues

The following changes since commit 9a98b8bfe13b94d89a9e39cca821f26fdeaeffc3:

image_types.bbclass: Fix tar IMAGE_CMD to not change directories (2014-02-18 08:37:03 +0000)

Quoted 8 lines

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-209
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-209

Khem Raj (2):
uclibc: Add new functionality needed for systemd 209
systemd: Upgrade 208 -> 209

Thanks for upgrade

I've noticed pulseaudio failing to build when it tries to detect old libsystemd-login lib:

| to the PKG_CONFIG_PATH environment variable
| No package 'libsystemd-login' found
| configure:26263: $? = 1
| configure:26277: result: no
| No package 'libsystemd-login' found
| configure:26310: error: *** Needed systemd support not found

do we want to enable compat libs or update pulseaudio to use new libsystemd?

Quoted 36 lines
 ...-Use-bin-mkdir-instead-of-host-mkdir-path.patch |  31 --
 ...1-uClibc-doesn-t-implement-pwritev-preadv.patch |  15 +-
 ...ournal-Add-missing-byte-order-conversions.patch |  60 ----
 .../journal-file-protect-against-alloca-0.patch    |  23 --
 ...n-appending-to-journal-file-allocate-larg.patch |  83 -----
 .../systemd/journald-add-missing-error-check.patch |  16 -
 .../systemd/systemd/systemd-pam-fix-execvpe.patch  |  22 +-
 .../systemd/systemd-pam-fix-fallocate.patch        |  24 +-
 .../systemd/systemd-pam-fix-getty-unit.patch       |  20 +-
 .../systemd/systemd/systemd-pam-fix-mkostemp.patch | 166 +--------
 .../systemd/systemd/systemd-pam-fix-msformat.patch | 115 ++++---
 .../systemd/systemd/uclibc-sysinfo_h.patch         |  19 ++
 .../systemd/{systemd_208.bb => systemd_209.bb}     |  14 +-
 meta/recipes-core/uclibc/uclibc-git.inc            |   3 +
 .../0001-Add-eventfd_read-and-eventfd_write.patch  | 120 +++++++
 .../uclibc-git/0002-wire-setns-syscall.patch       |  68 ++++
 ...tl.h-Define-F_SETPIPE_SZ-and-F_GETPIPE_SZ.patch | 377 +++++++++++++++++++++
 17 files changed, 702 insertions(+), 474 deletions(-)
 delete mode 100644 meta/recipes-core/systemd/systemd/0001-Use-bin-mkdir-instead-of-host-mkdir-path.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journal-Add-missing-byte-order-conversions.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journal-file-protect-against-alloca-0.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journal-when-appending-to-journal-file-allocate-larg.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/journald-add-missing-error-check.patch
 create mode 100644 meta/recipes-core/systemd/systemd/uclibc-sysinfo_h.patch
 rename meta/recipes-core/systemd/{systemd_208.bb => systemd_209.bb} (96%)
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0001-Add-eventfd_read-and-eventfd_write.patch
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0002-wire-setns-syscall.patch
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0003-fcntl.h-Define-F_SETPIPE_SZ-and-F_GETPIPE_SZ.patch
Signature · 6 lines
1.9.0

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 30 lines · Martin Jansa
Quoted 8 lines · Khem Raj

This patchset upgrades systemd to 209 as can be seen some enahancements to uclibc were neeed. As of now. It builds for me on both uclibc/eglibc Please test it out in your setups and report back any issues

The following changes since commit 9a98b8bfe13b94d89a9e39cca821f26fdeaeffc3:

image_types.bbclass: Fix tar IMAGE_CMD to not change directories (2014-02-18 08:37:03 +0000)

Quoted 8 lines

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-209
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-209

Khem Raj (2):
uclibc: Add new functionality needed for systemd 209
systemd: Upgrade 208 -> 209

Thanks for upgrade

I've noticed pulseaudio failing to build when it tries to detect old libsystemd-login lib:

| to the PKG_CONFIG_PATH environment variable
| No package 'libsystemd-login' found
| configure:26263: $? = 1
| configure:26277: result: no
| No package 'libsystemd-login' found
| configure:26310: error: *** Needed systemd support not found
Quoted 2 lines

do we want to enable compat libs or update pulseaudio to use new libsystemd?

FWIW the git recipe I was using enabled compat-libs...

Cheers,

Richard

author
#5 lore raw
Quoted 2 lines · Richard Purdie

FWIW the git recipe I was using enabled compat-libs...

I have tested both combinations. I would suggest that we drop compat-libs if there are few packages needing it lests fix the packages instead

#6 lore raw
In reply to Richard Purdie

Op 21 feb. 2014, om 16:21 heeft Richard Purdie <[email protected]> het volgende geschreven:

Quoted 31 lines · Martin Jansa
Quoted 30 lines · Khem Raj
Quoted 8 lines

This patchset upgrades systemd to 209 as can be seen some enahancements to uclibc were neeed. As of now. It builds for me on both uclibc/eglibc Please test it out in your setups and report back any issues

The following changes since commit 9a98b8bfe13b94d89a9e39cca821f26fdeaeffc3:

image_types.bbclass: Fix tar IMAGE_CMD to not change directories (2014-02-18 08:37:03 +0000)

Quoted 8 lines

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-209
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-209

Khem Raj (2):
uclibc: Add new functionality needed for systemd 209
systemd: Upgrade 208 -> 209

Thanks for upgrade

I've noticed pulseaudio failing to build when it tries to detect old libsystemd-login lib:

| to the PKG_CONFIG_PATH environment variable
| No package 'libsystemd-login' found
| configure:26263: $? = 1
| configure:26277: result: no
| No package 'libsystemd-login' found
| configure:26310: error: *** Needed systemd support not found
Quoted 4 lines
Quoted 2 lines

do we want to enable compat libs or update pulseaudio to use new libsystemd?

FWIW the git recipe I was using enabled compat-libs...

And that needs IFUNC which only x86 toolchains support :(

#7 lore raw
Quoted 33 lines · Koen Kooi

Op 21 feb. 2014, om 16:21 heeft Richard Purdie <[email protected]> het volgende geschreven:

Quoted 31 lines · Martin Jansa
Quoted 30 lines · Khem Raj
Quoted 8 lines

This patchset upgrades systemd to 209 as can be seen some enahancements to uclibc were neeed. As of now. It builds for me on both uclibc/eglibc Please test it out in your setups and report back any issues

The following changes since commit 9a98b8bfe13b94d89a9e39cca821f26fdeaeffc3:

image_types.bbclass: Fix tar IMAGE_CMD to not change directories (2014-02-18 08:37:03 +0000)

Quoted 8 lines

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-209
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-209

Khem Raj (2):
uclibc: Add new functionality needed for systemd 209
systemd: Upgrade 208 -> 209

Thanks for upgrade

I've noticed pulseaudio failing to build when it tries to detect old libsystemd-login lib:

| to the PKG_CONFIG_PATH environment variable
| No package 'libsystemd-login' found
| configure:26263: $? = 1
| configure:26277: result: no
| No package 'libsystemd-login' found
| configure:26310: error: *** Needed systemd support not found
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

do we want to enable compat libs or update pulseaudio to use new libsystemd?

FWIW the git recipe I was using enabled compat-libs...

And that needs IFUNC which only x86 toolchains support :(

I did run test builds of the git version on the autobuilders and didn't see any failures?

Cheers,

Richard

author
#8 lore raw
Quoted 37 lines · Richard Purdie
Quoted 36 lines · Koen Kooi

Op 21 feb. 2014, om 16:21 heeft Richard Purdie <[email protected]> het volgende geschreven:

Quoted 34 lines · Martin Jansa
Quoted 32 lines · Khem Raj
Quoted 8 lines

This patchset upgrades systemd to 209 as can be seen some enahancements to uclibc were neeed. As of now. It builds for me on both uclibc/eglibc Please test it out in your setups and report back any issues

The following changes since commit 9a98b8bfe13b94d89a9e39cca821f26fdeaeffc3:

image_types.bbclass: Fix tar IMAGE_CMD to not change directories (2014-02-18 08:37:03 +0000)

Quoted 8 lines

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-209
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-209

Khem Raj (2):
uclibc: Add new functionality needed for systemd 209
systemd: Upgrade 208 -> 209

Thanks for upgrade

I've noticed pulseaudio failing to build when it tries to detect old libsystemd-login lib:

| to the PKG_CONFIG_PATH environment variable
| No package 'libsystemd-login' found
| configure:26263: $? = 1
| configure:26277: result: no
| No package 'libsystemd-login' found
| configure:26310: error: *** Needed systemd support not found

do we want to enable compat libs or update pulseaudio to use new libsystemd?

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

FWIW the git recipe I was using enabled compat-libs...

And that needs IFUNC which only x86 toolchains support :(

I did run test builds of the git version on the autobuilders and didn't see any failures?

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

Quoted 9 lines

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#9 lore raw
Quoted 3 lines · Khem Raj

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

What is the problem with ifunc on non-x86? As far as I know the compiler, assembler, linker and ld.so for all reasonable architectures support that nowadays (though prelink support is a bit patchy). GCC didn't have ifuncs enabled for some architectures until quite recently but if that was the problem then you'd see compile-time failures. So, if it compiles then I can't think of any reason why it oughtn't to run. Is this a uclibc thing?

p.

author
#10 lore raw
Quoted 6 lines · Phil Blundell
Quoted 3 lines · Khem Raj

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

What is the problem with ifunc on non-x86?

they are not enabled across all architectures, well specifically, its not enabled on arm and seems also ppc is missing it.

Quoted 6 lines

As far as I know the
compiler, assembler, linker and ld.so for all reasonable architectures support that nowadays (though prelink support is a bit patchy). GCC didn't have ifuncs enabled for some architectures until quite recently but if that was the problem then you'd see compile-time failures. So, if it compiles then I can't think of any reason why it oughtn't to run.

systemd is using ifuncs to patch up the library migration it has done in 209
so it only shows up when we enable compat lib support in systemd, and if we patch the apps to forward port to systemd 209 then we don’t need to enable compat lib support and it could be left alone.

if we want to enable compat libs/ifunc then we can think of adding --enable-gnu-indirect-function to gcc configure but then it may not work on all architectures that we are interested in.

Quoted 1 line

Is this a uclibc thing?

no

Quoted 4 lines

p.

#11 lore raw

Op 22 feb. 2014, om 20:52 heeft Khem Raj <[email protected]> het volgende geschreven:

Quoted 19 lines · Phil Blundell
Quoted 7 lines · Khem Raj
Quoted 3 lines

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

What is the problem with ifunc on non-x86?

they are not enabled across all architectures, well specifically, its not enabled on arm and seems also ppc is missing it.

Quoted 6 lines

As far as I know the
compiler, assembler, linker and ld.so for all reasonable architectures support that nowadays (though prelink support is a bit patchy). GCC didn't have ifuncs enabled for some architectures until quite recently but if that was the problem then you'd see compile-time failures. So, if it compiles then I can't think of any reason why it oughtn't to run.

Quoted 3 lines

systemd is using ifuncs to patch up the library migration it has done in 209
so it only shows up when we enable compat lib support in systemd, and if we patch the apps to forward port to systemd 209 then we don’t need to enable compat lib support and it could be left alone.

Or we can cherry-pick http://cgit.freedesktop.org/systemd/systemd/commit/?id=03e37dd767e52908f30783d9b4c09fb6a4e865c7 :)

Quoted 14 lines

if we want to enable compat libs/ifunc then we can think of adding --enable-gnu-indirect-function to gcc configure but then it may not work on all architectures that we are interested in.

Quoted 1 line

Is this a uclibc thing?

no

Quoted 4 lines

p.

#12 lore raw
Quoted 22 lines · Koen Kooi

Op 22 feb. 2014, om 20:52 heeft Khem Raj <[email protected]> het volgende geschreven:

Quoted 19 lines · Phil Blundell
Quoted 7 lines · Khem Raj
Quoted 3 lines

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

What is the problem with ifunc on non-x86?

they are not enabled across all architectures, well specifically, its not enabled on arm and seems also ppc is missing it.

Quoted 6 lines

As far as I know the
compiler, assembler, linker and ld.so for all reasonable architectures support that nowadays (though prelink support is a bit patchy). GCC didn't have ifuncs enabled for some architectures until quite recently but if that was the problem then you'd see compile-time failures. So, if it compiles then I can't think of any reason why it oughtn't to run.

Quoted 5 lines
Quoted 3 lines

systemd is using ifuncs to patch up the library migration it has done in 209
so it only shows up when we enable compat lib support in systemd, and if we patch the apps to forward port to systemd 209 then we don’t need to enable compat lib support and it could be left alone.

Or we can cherry-pick http://cgit.freedesktop.org/systemd/systemd/commit/?id=03e37dd767e52908f30783d9b4c09fb6a4e865c7 :)

And 210 is out :)

FWIW: My world builds revealed only networkmanager failing to detect libsystemd.

Quoted 18 lines
Quoted 4 lines

if we want to enable compat libs/ifunc then we can think of adding --enable-gnu-indirect-function to gcc configure but then it may not work on all architectures that we are interested in.

Quoted 9 lines
Quoted 1 line

Is this a uclibc thing?

no

Quoted 4 lines

p.

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#13 lore raw
In reply to Phil Blundell
Quoted 5 lines · Phil Blundell
Quoted 3 lines · Khem Raj

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

Quoted 7 lines

What is the problem with ifunc on non-x86? As far as I know the compiler, assembler, linker and ld.so for all reasonable architectures support that nowadays (though prelink support is a bit patchy). GCC didn't have ifuncs enabled for some architectures until quite recently but if that was the problem then you'd see compile-time failures. So, if it compiles then I can't think of any reason why it oughtn't to run. Is this a uclibc thing?

I'm seeing lots of compile errors like this:

| arm-oe-linux-gnueabi-libtool: link: arm-oe-linux-gnueabi-ranlib .libs/libsystemd-units.a
| libsystemd-id128.c:6:6: error: ifunc is not supported in this configuration
|  void sd_id128_to_string(void) __attribute__((ifunc("resolve_sd_id128_to_string")));
|       ^
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#14 lore raw
Quoted 14 lines · Martin Jansa
Quoted 5 lines · Phil Blundell
Quoted 3 lines · Khem Raj

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

Quoted 7 lines

What is the problem with ifunc on non-x86? As far as I know the compiler, assembler, linker and ld.so for all reasonable architectures support that nowadays (though prelink support is a bit patchy). GCC didn't have ifuncs enabled for some architectures until quite recently but if that was the problem then you'd see compile-time failures. So, if it compiles then I can't think of any reason why it oughtn't to run. Is this a uclibc thing?

Quoted 7 lines

I'm seeing lots of compile errors like this:

| arm-oe-linux-gnueabi-libtool: link: arm-oe-linux-gnueabi-ranlib .libs/libsystemd-units.a
| libsystemd-id128.c:6:6: error: ifunc is not supported in this configuration
|  void sd_id128_to_string(void) __attribute__((ifunc("resolve_sd_id128_to_string")));
|       ^

this is exact problem I mentioned in last email. Try to remove --enable-compat-libs in systemd recipe.

Quoted 2 lines

--
Martin 'JaMa' Jansa jabber: [email protected]

author
#15 lore raw
In reply to Khem Raj
Quoted 8 lines
Quoted 3 lines

I did run test builds of the git version on the autobuilders and didn't see any failures?

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

I have now refreshed my contrib tree

http://git.openembedded.org/openembedded-core-contrib/log/?h=kraj/systemd-210

I have documented additional change you might need in your distro if you are not using OE-Core’s fs-perms.txt, systemd now needs /var/run to be symlinked to /run or else it won’t be able to talk to d-bus and kdbus is too new to enable yet.

Please try this patch, it now builds and boots fine on x86 and arm here. I am also testing out other architecture in meantime

-Khem

#16 lore raw
Quoted 11 lines · Khem Raj
Quoted 8 lines
Quoted 3 lines

I did run test builds of the git version on the autobuilders and didn't see any failures?

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

I have now refreshed my contrib tree

Quoted 9 lines

http://git.openembedded.org/openembedded-core-contrib/log/?h=kraj/systemd-210

I have documented additional change you might need in your distro if you are not using OE-Core’s fs-perms.txt, systemd now needs /var/run to be symlinked to /run or else it won’t be able to talk to d-bus and kdbus is too new to enable yet.

Please try this patch, it now builds and boots fine on x86 and arm here. I am also testing out other architecture in meantime

Khem,

Did you test with ptest enabled in DISTRO_FEATURES? I just built it locally and got the following error:

Quoted 4 lines
| cp: cannot stat '/home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/build/rules': No such file or directory
| WARNING: /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/temp/run.do_install_ptest_base.9533:1 exit 1 from
|   cp -rf /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/build/rules /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/image/usr/lib/systemd/ptest/
| ERROR: Function failed: do_install_ptest_base (log file is located at /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/temp/log.do_install_ptest_base.9533)

Sau!

Quoted 9 lines

-Khem

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#17 lore raw
Quoted 18 lines · Saul Wold
Quoted 17 lines · Khem Raj
Quoted 8 lines
Quoted 3 lines

I did run test builds of the git version on the autobuilders and didn't see any failures?

builds might work but they won’t run and yes so far IFUNC support is needed so it won’t work on non-x86 architectures. One common runtime problem I am seeing is logind not being able to talk to dbus across all architectures. I have pushed my latest rework to pull branch

I have now refreshed my contrib tree

http://git.openembedded.org/openembedded-core-contrib/log/?h=kraj/systemd-210

I have documented additional change you might need in your distro if you are not using OE-Core’s fs-perms.txt, systemd now needs /var/run to be symlinked to /run or else it won’t be able to talk to d-bus and kdbus is too new to enable yet.

Quoted 7 lines
Quoted 3 lines

Please try this patch, it now builds and boots fine on x86 and arm here. I am also testing out other architecture in meantime

Khem,

Did you test with ptest enabled in DISTRO_FEATURES?

no

Quoted 7 lines

I just built it locally and got the following error:

Quoted 4 lines
| cp: cannot stat '/home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/build/rules': No such file or directory
| WARNING: /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/temp/run.do_install_ptest_base.9533:1 exit 1 from
|   cp -rf /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/build/rules /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/image/usr/lib/systemd/ptest/
| ERROR: Function failed: do_install_ptest_base (log file is located at /home/sgw/yocto/builds/world/tmp/work/core2-64-poky-linux/systemd/1_210-r0/temp/log.do_install_ptest_base.9533)

this is because you might have S != B, anyway I have fixed this and refreshed the branch

Quoted 13 lines

Sau!

Quoted 9 lines

-Khem

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#18 lore raw
In reply to Martin Jansa
Quoted 13 lines · Martin Jansa

Thanks for upgrade

I've noticed pulseaudio failing to build when it tries to detect old libsystemd-login lib:

| to the PKG_CONFIG_PATH environment variable
| No package 'libsystemd-login' found
| configure:26263: $? = 1
| configure:26277: result: no
| No package 'libsystemd-login' found
| configure:26310: error: *** Needed systemd support not found
Quoted 2 lines

do we want to enable compat libs or update pulseaudio to use new libsystemd?

I think we dont have such a big legacy with systemd yet may be if its few packages then lets fix the packages instead of enabling legacy support if we can. in my local tree ( not yet pushed ) I was explicitly enabling it and disabling kdbus support to see if I can fix the logind not finding dbus issue
it seems to happen for all architectures

#19 lore raw
Quoted 17 lines · Khem Raj
Quoted 13 lines · Martin Jansa

Thanks for upgrade

I've noticed pulseaudio failing to build when it tries to detect old libsystemd-login lib:

| to the PKG_CONFIG_PATH environment variable
| No package 'libsystemd-login' found
| configure:26263: $? = 1
| configure:26277: result: no
| No package 'libsystemd-login' found
| configure:26310: error: *** Needed systemd support not found
Quoted 2 lines

do we want to enable compat libs or update pulseaudio to use new libsystemd?

Quoted 6 lines

I think we dont have such a big legacy with systemd yet may be if its few packages then lets fix the packages instead of enabling legacy support if we can. in my local tree ( not yet pushed ) I was explicitly enabling it and disabling kdbus support to see if I can fix the logind not finding dbus issue
it seems to happen for all architectures

Agreed,

I've found another one: polkit:

| checking for LIBSYSTEMD_LOGIN... no
| configure: error: libsystemd-login support requested but libsystemd-login library not found
| Configure failed. The contents of all config.log files follows to aid debugging
| /home/jenkins/oe/shr-core-branches/shr-core/tmp-eglibc/work/armv5te-oe-linux-gnueabi/polkit/0.111-r0/polkit-0.111/config.log
| This file contains any messages produced by compilers while
| running configure, to aid debugging if configure makes a mistake.
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#20 lore raw

PATCH 1/1 polkit: make it compatible with systemd-209

---
 ...c-Check-only-for-libsystemd-not-libsystem.patch | 39 ++++++++++++++++++++++
 meta-oe/recipes-extended/polkit/polkit_0.111.bb    |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 meta-oe/recipes-extended/polkit/polkit/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch
meta-oe/recipes-extended/polkit/polkit/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch new file +39 -0
new file mode 100644
index 0000000..b9334a8
@@ -0,0 +1,39 @@
+From 56cadbc45c5ef98a7b775638d2109c4a09a58c06 Mon Sep 17 00:00:00 2001
+From: Martin Jansa <[email protected]>
+Date: Sat, 22 Feb 2014 18:09:57 +0100
+Subject: [PATCH] configure.ac: Check only for libsystemd not libsystemd-login
+
+* they were merged into libsystemd in systemd-209
+
+Upstream-Status: Pending (it would need to be conditional on systemd version for upstream to accept this)
+
+Signed-off-by: Martin Jansa <[email protected]>
+---
+ configure.ac | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index a7b0148..64d513d 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -196,7 +196,7 @@ AC_ARG_ENABLE([libsystemd-login],
+               [enable_libsystemd_login=auto])
+ if test "$enable_libsystemd_login" != "no"; then
+   PKG_CHECK_MODULES(LIBSYSTEMD_LOGIN,
+-                    [libsystemd-login],
++                    [libsystemd],
+                     have_libsystemd_login=yes,
+                     have_libsystemd_login=no)
+   if test "$have_libsystemd_login" = "yes"; then
+@@ -223,7 +223,7 @@ AS_IF([test "x$cross_compiling" != "xyes" ], [
+       AS_IF([test "$enable_libsystemd_login" = "no" ], [
+         AC_MSG_WARN([ConsoleKit requested but system appears to use systemd])
+       ], [
+-        AC_MSG_ERROR([ConsoleKit autoconfigured, but systemd is in use (missing libsystemd-login pkg-config?)])
++        AC_MSG_ERROR([ConsoleKit autoconfigured, but systemd is in use (missing libsystemd pkg-config?)])
+       ])
+     ])
+   ])
+-- 
+1.8.5.3
+
meta-oe/recipes-extended/polkit/polkit_0.111.bb +1 -0
index 33101cf..4614387 100644
@@ -20,6 +20,7 @@ PACKAGECONFIG[consolekit] = ",,,consolekit"
 PAM_SRC_URI = "file://polkit-1_pam.patch"
 SRC_URI = "http://www.freedesktop.org/software/polkit/releases/polkit-${PV}.tar.gz \
            ${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', '', d)} \
+           file://0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch \
 "
 
 SRC_URI[md5sum] = "81b116edf986d8e13502929a171f4e0d"
Signature · 1 line
1.8.5.3
#21 lore raw

PATCH 1/1 pulseaudio: Make it compatible with systemd-209

---
 ...c-Check-only-for-libsystemd-not-libsystem.patch | 30 ++++++++++++++++++++++
 .../pulseaudio/pulseaudio_4.0.bb                   |  1 +
 2 files changed, 31 insertions(+)
 create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch
meta/recipes-multimedia/pulseaudio/pulseaudio/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch new file +30 -0
new file mode 100644
index 0000000..467cd2c
@@ -0,0 +1,30 @@
+From 002b16f0f2176b4c685e210e335bf69c02563ede Mon Sep 17 00:00:00 2001
+From: Martin Jansa <[email protected]>
+Date: Sat, 22 Feb 2014 18:03:10 +0100
+Subject: [PATCH] configure.ac: Check only for libsystemd not libsystemd-login
+
+* they were merged into libsystemd in systemd-209
+
+Upstream-Status: Pending (it would need to be conditional on systemd version for upstream to accept this)
+
+Signed-off-by: Martin Jansa <[email protected]>
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index 388fae2..fff7a83 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -1160,7 +1160,7 @@ AC_ARG_ENABLE([systemd],
+     AS_HELP_STRING([--disable-systemd],[Disable optional systemd support]))
+ 
+ AS_IF([test "x$enable_systemd" != "xno"],
+-    [PKG_CHECK_MODULES(SYSTEMD, [ libsystemd-login ], HAVE_SYSTEMD=1, HAVE_SYSTEMD=0)],
++    [PKG_CHECK_MODULES(SYSTEMD, [ libsystemd ], HAVE_SYSTEMD=1, HAVE_SYSTEMD=0)],
+     HAVE_SYSTEMD=0)
+ 
+ AS_IF([test "x$enable_systemd" = "xyes" && test "x$HAVE_SYSTEMD" = "x0"],
+-- 
+1.8.5.3
+
meta/recipes-multimedia/pulseaudio/pulseaudio_4.0.bb +1 -0
index b419c54..53dd494 100644
@@ -1,6 +1,7 @@
 require pulseaudio.inc
 
 SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/pulseaudio-${PV}.tar.xz \
+           file://0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch \
            file://volatiles.04_pulse"
 
 SRC_URI[md5sum] = "591f211db2790a7e4d222f2dc6858db3"
Signature · 1 line
1.8.5.3
author
#22 lore raw

Re: [PATCH] pulseaudio: Make it compatible with systemd-209

Quoted 14 lines · Martin Jansa
---
 ...c-Check-only-for-libsystemd-not-libsystem.patch | 30 ++++++++++++++++++++++
 .../pulseaudio/pulseaudio_4.0.bb                   |  1 +
 2 files changed, 31 insertions(+)
 create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch
meta/recipes-multimedia/pulseaudio/pulseaudio/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch new file +1 -0
new file mode 100644
index 0000000..467cd2c
@@ -0,0 +1,30 @@
+From 002b16f0f2176b4c685e210e335bf69c02563ede Mon Sep 17 00:00:00 2001

meta/recipes-multimedia/pulseaudio/pulseaudio/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch line 11

Quoted 10 lines
meta/recipes-multimedia/pulseaudio/pulseaudio/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch new file +10 -0
+From: Martin Jansa <[email protected]>
+Date: Sat, 22 Feb 2014 18:03:10 +0100
+Subject: [PATCH] configure.ac: Check only for libsystemd not libsystemd-login
+
+* they were merged into libsystemd in systemd-209
+
+Upstream-Status: Pending (it would need to be conditional on systemd version for upstream to accept this)
+
+Signed-off-by: Martin Jansa <[email protected]>
+---

while we fight to make it work in OE you can in parallel stage/get reviews on these patches in respective upstream projects.

Quoted 38 lines
meta/recipes-multimedia/pulseaudio/pulseaudio/0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch new file +19 -0
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index 388fae2..fff7a83 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -1160,7 +1160,7 @@ AC_ARG_ENABLE([systemd],
+     AS_HELP_STRING([--disable-systemd],[Disable optional systemd support]))
+
+ AS_IF([test "x$enable_systemd" != "xno"],
+-    [PKG_CHECK_MODULES(SYSTEMD, [ libsystemd-login ], HAVE_SYSTEMD=1, HAVE_SYSTEMD=0)],
++    [PKG_CHECK_MODULES(SYSTEMD, [ libsystemd ], HAVE_SYSTEMD=1, HAVE_SYSTEMD=0)],
+     HAVE_SYSTEMD=0)
+
+ AS_IF([test "x$enable_systemd" = "xyes" && test "x$HAVE_SYSTEMD" = "x0"],
+--
+1.8.5.3
+
meta/recipes-multimedia/pulseaudio/pulseaudio_4.0.bb +1 -1
index b419c54..53dd494 100644
@@ -1,6 +1,7 @@
 require pulseaudio.inc
 
 SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/pulseaudio-${PV}.tar.xz \
+           file://0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch \
            file://volatiles.04_pulse"
 
 SRC_URI[md5sum] = "591f211db2790a7e4d222f2dc6858db3"
--

1.8.5.3

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core