Skip to contentSkip to conversation

dev: Add NMEA port for MHI WWAN device. (mhi0_NMEA)

PATCH In review Muhammad Nuzaihan 2 participants 3 messages Jan 4, 2025 – Jan 5, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dev: Add NMEA port for MHI WWAN device. (mhi0_NMEA)

Based on the earlier v2 and v1 patches. This patch is a cleanup from v2.

Removed unnecessary code added to "iosm" and "AT IOCTL" which is not relevant.

Tested this change on a new kernel and module built and now device NMEA (mhi0_NMEA) statements are available through /dev/wwan0nmea0 port on bootup.

---
v3:
- Rebased to net-next main branch
- Removed earlier patches that added unnecessary iosm (unrelated) and AT IOCTL code.
v2: https://lore.kernel.org/netdev/[email protected]/
v1: https://lore.kernel.org/netdev/[email protected]/
---

drivers/net/wwan/mhi_wwan_ctrl.c | 1 +
drivers/net/wwan/wwan_core.c | 4 ++++
include/linux/wwan.h | 2 ++

3 files changed, 7 insertions(+)
drivers/net/wwan/mhi_wwan_ctrl.c +1 -0
index e9f979d2d851..e13c0b078175 100644
@@ -263,6 +263,7 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = {
       { .chan = "QMI", .driver_data = WWAN_PORT_QMI },
       { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
       { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE },
+	{ .chan = "NMEA", .driver_data = WWAN_PORT_NMEA },
       {},

};
MODULE_DEVICE_TABLE(mhi, mhi_wwan_ctrl_match_table);

drivers/net/wwan/wwan_core.c +4 -0
index a51e2755991a..ebf574f2b126 100644
@@ -342,6 +342,10 @@ static const struct {
               .name = "MIPC",
               .devsuf = "mipc",
       },
+	[WWAN_PORT_NMEA] = {
+		.name = "NMEA",
+		.devsuf = "nmea",
+	},

};

static ssize_t type_show(struct device *dev, struct device_attribute *attr,

include/linux/wwan.h +2 -1
index a4d6cc0c9f68..ca38a2fe0987 100644
@@ -19,6 +19,7 @@
 * @WWAN_PORT_FASTBOOT: Fastboot protocol control
 * @WWAN_PORT_ADB: ADB protocol control
 * @WWAN_PORT_MIPC: MTK MIPC diagnostic interface
+ * @WWAN_PORT_NMEA: NMEA GPS statements interface
 *
 * @WWAN_PORT_MAX: Highest supported port types
 * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type
@@ -34,6 +35,7 @@ enum wwan_port_type {
       WWAN_PORT_FASTBOOT,
       WWAN_PORT_ADB,
       WWAN_PORT_MIPC,
+	WWAN_PORT_NMEA,
 
       /* Add new port types above this line */
--

2.34.1

#1 lore raw
Quoted 29 lines · Muhammad Nuzaihan

Based on the earlier v2 and v1 patches. This patch is a cleanup from v2.

Removed unnecessary code added to "iosm" and "AT IOCTL" which is not relevant.

Tested this change on a new kernel and module built and now device NMEA (mhi0_NMEA) statements are available through /dev/wwan0nmea0 port on bootup.

---
v3:
- Rebased to net-next main branch
- Removed earlier patches that added unnecessary iosm (unrelated) and AT IOCTL code.
v2: https://lore.kernel.org/netdev/[email protected]/
v1: https://lore.kernel.org/netdev/[email protected]/
---

drivers/net/wwan/mhi_wwan_ctrl.c | 1 +
drivers/net/wwan/wwan_core.c | 4 ++++
include/linux/wwan.h | 2 ++

3 files changed, 7 insertions(+)
drivers/net/wwan/mhi_wwan_ctrl.c +0 -0
index e9f979d2d851..e13c0b078175 100644

drivers/net/wwan/mhi_wwan_ctrl.c static const struct mhi_device_id · line 267

Quoted 5 lines
drivers/net/wwan/mhi_wwan_ctrl.c +1 -0
@@ -263,6 +263,7 @@ static const struct mhi_device_id
 mhi_wwan_ctrl_match_table[] = {
       { .chan = "QMI", .driver_data = WWAN_PORT_QMI },
       { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
       { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE },
+	{ .chan = "NMEA", .driver_data = WWAN_PORT_NMEA },

The indentation is all messed up in this patch. It looks like a tab to space conversion has happened somewhere?

Did you use git send-email?

Andrew

---
pw-bot: cr

#2 lore raw

Hi Andrew,

Yes, i was using geary client to send out the patch. Will send out using git send-email

Quoted 52 lines · Andrew Lunn
Quoted 36 lines · Muhammad Nuzaihan

Based on the earlier v2 and v1 patches. This patch is a cleanup
from v2.

Removed unnecessary code added to "iosm" and "AT IOCTL" which is not relevant.

Tested this change on a new kernel and module built and now device
NMEA
(mhi0_NMEA) statements are available through /dev/wwan0nmea0 port
on bootup.

Signed-off-by: Muhammad Nuzaihan Bin Kamal Luddin
<[email protected]>
---
v3:
- Rebased to net-next main branch
- Removed earlier patches that added unnecessary iosm (unrelated)
and AT
IOCTL code.
v2:
https://lore.kernel.org/netdev/[email protected]/
v1:
https://lore.kernel.org/netdev/[email protected]/
---

 drivers/net/wwan/mhi_wwan_ctrl.c | 1 +
 drivers/net/wwan/wwan_core.c | 4 ++++
 include/linux/wwan.h | 2 ++
 3 files changed, 7 insertions(+)

diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c
index e9f979d2d851..e13c0b078175 100644
--- a/drivers/net/wwan/mhi_wwan_ctrl.c
+++ b/drivers/net/wwan/mhi_wwan_ctrl.c
@@ -263,6 +263,7 @@ static const struct mhi_device_id

Quoted 5 lines
 mhi_wwan_ctrl_match_table[] = {
        { .chan = "QMI", .driver_data = WWAN_PORT_QMI },
        { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
        { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE },

+ { .chan = "NMEA", .driver_data = WWAN_PORT_NMEA },

The indentation is all messed up in this patch. It looks like a tab to space conversion has happened somewhere?

Did you use git send-email?

Andrew

---
pw-bot: cr