Skip to contentSkip to conversation

Typo in manage.c causes compile failure

PATCH In review David Stipp 2 participants 2 messages Nov 22, 2005 – Nov 23, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Typo in manage.c causes compile failure

Hi all,

In OpenVPN 2.0.5, the following patch is necessary to compile manage.c with Sun Studio 9. Without it, the resulting symbol will be undefined.

********************************************************************************

manage.c 2005-11-22 13:14:00.420287000 -0600 renamed from manage.c.orig 2005-11-01 05:06:11.000000000 -0600 +1 -1
@@ -1564,7 +1564,7 @@
 
 #endif
 
-inline bool
+static inline bool
 man_standalone_ok (const struct management *man)
 {
   return !man->settings.management_over_tunnel && man->connection.state != MS_INITIAL;

********************************************************************************

There are 'static inline bool's all over the code, but only this one particular 'inline bool'. Perhaps it was just a mistype.

Please CC me on any additional correspondence as I am not on the mailing list.

Thanks!

David

Signature · 1 line
David Stipp <[email protected]...>
#1 lore raw
Quoted 19 lines · David Stipp

Hi all,

In OpenVPN 2.0.5, the following patch is necessary to compile manage.c with Sun Studio 9. Without it, the resulting symbol will be undefined.

********************************************************************************

manage.c 2005-11-22 13:14:00.420287000 -0600 renamed from manage.c.orig 2005-11-01 05:06:11.000000000 -0600 +1 -1
@@ -1564,7 +1564,7 @@
 
 #endif
 
-inline bool
+static inline bool
 man_standalone_ok (const struct management *man)
 {
   return !man->settings.management_over_tunnel && man->connection.state != MS_INITIAL;

********************************************************************************

Quoted 5 lines

There are 'static inline bool's all over the code, but only this one particular 'inline bool'. Perhaps it was just a mistype.

Please CC me on any additional correspondence as I am not on the mailing list.

Indeed, this appears to be a typo. I will fix for 2.0.6 and the 2.1 beta series.

James