unexport install_page
PATCH 1/1 unexport install_page
No in-kernel module is using it, so there's no reason bloating the kernel with this EXPORT_SYMBOL.
---
This patch was already sent on:
- 16 Feb 2006
mm/fremap.c renamed from mm/fremap.c.old +0 -1
@@ -89,7 +89,6 @@ out:return err; } -EXPORT_SYMBOL (install_page);/* * Install a file pte to a given virtual memory address, release any
Quoted 2 lines · Adrian Bunk
No in-kernel module is using it, so there's no reason bloating the kernel with this
EXPORT_SYMBOL.
And no one should be using it, really. It's a helper for sys_remap_file_pages implementations, something that nothing but the generic filemap.c or shmem.c should do.
Quoted 5 lines · Christoph Hellwig
Quoted 2 lines · Adrian Bunk
No in-kernel module is using it, so there's no reason bloating the kernel with this
EXPORT_SYMBOL.And no one should be using it, really.
Why's that?
Quoted 1 line
It's a helper for
sys_remap_file_pagesimplementations,
Exactly (to support non-linear vmas and MAP_POPULATE).
Quoted 1 line
something that nothing but the generic
filemap.corshmem.cshould do.
Why's that? It's rightly been recognized as a library function since 2.6.0-test3. I'd say it should remain exported for whatever filesystems might wish to use it (but no, I've no vested interest, the filesystem you'll suspect me of arguing for does not use it ;)
<[email protected]>
[PATCH] export install_page() to modules
install_page() is a library function which we expect will be used by all drivers which implement vm_operations.populate(). Therefore it should be exported to kernel modules.
Petr Vandrovec has a project which involves sparse mappings of device memory which can use remap_file_pages(). It needs install_page().
Hugh
Quoted 9 lines · Hugh Dickins
...
Why's that? It's rightly been recognized as a library function since 2.6.0-test3. I'd say it should remain exported for whatever filesystems might wish to use it (but no, I've no vested interest, the filesystem you'll suspect me of arguing for does not use it ;)<[email protected]>
[PATCH] exportinstall_page()to modules
Quoted 6 lines
install_page()is a library function which we expect will be used by all drivers which implementvm_operations.populate(). Therefore it should be exported to kernel modules.Petr Vandrovec has a project which involves sparse mappings of device memory which can use
remap_file_pages(). It needsinstall_page().
This export was justified in mid-2003 with a projet that would use it.
Now it's 2006, and there's still no in-kernel user.
This means it has only bloated the kernel for two and a half years for nearly everyone.
Quoted 1 line
Hugh
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 2 lines · Adrian Bunk
This means it has only bloated the kernel for two and a half years for nearly everyone.
Wouldn't it be more productive to just shave 30 bytes off some other function and make it faster instead of moaning about every single export symbol that is provided even when its intentionally part of a complete API ?
Quoted 8 lines · Alan Cox
Quoted 2 lines · Adrian Bunk
This means it has only bloated the kernel for two and a half years for nearly everyone.
Wouldn't it be more productive to just shave 30 bytes off some other function and make it faster instead of moaning about every single export symbol that is provided even when its intentionally part of a complete API ?
Wouldn't it be best to do both?
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed