Skip to contentSkip to conversation

m68k Kconfig undefined symbol in 2.6.23.

PATCH Rob Landley 3 participants 3 messages Oct 10, 2007 – Oct 11, 2007 Linux for power macintosh

lore
Share & tools
lore
#0 lore raw

The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.

I did this to fix it, without really understanding the larger problem. (Did APM go away?) Just FYI...

Rob

drivers/macintosh/Kconfig +0 -5
diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig
@@ -116,11 +116,6 @@ config PMAC_SMU
 	  on the "SMU" system control chip which replaces the old PMU.
 	  If you don't know, say Y.
 
-config PMAC_APM_EMU
-	tristate "APM emulation"
-	select APM_EMULATION
-	depends on ADB_PMU && PM && PPC32
-
 config PMAC_MEDIABAY
 	bool "Support PowerBook hotswap media bay"
 	depends on PPC_PMAC && PPC32
Signature · 2 lines
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
#1 lore raw
Quoted 11 lines · Rob Landley

The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.

I did this to fix it, without really understanding the larger problem. (Did APM go away?) Just FYI...

Rob

diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig

drivers/macintosh/Kconfig config PMAC_SMU · line 122

Quoted 7 lines
drivers/macintosh/Kconfig +0 -4
@@ -116,11 +116,6 @@ config PMAC_SMU
 	  on the "SMU" system control chip which replaces the old PMU.
 	  If you don't know, say Y.
 
-config PMAC_APM_EMU
-	tristate "APM emulation"
-	select APM_EMULATION
-	depends on ADB_PMU && PM && PPC32
                                    ^^^^^

I.e. PPC, not m68k.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
In reply to Rob Landley
Quoted 12 lines · Rob Landley

The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.

I did this to fix it, without really understanding the larger problem. (Did APM go away?) Just FYI...

Rob

diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig

drivers/macintosh/Kconfig +0 -0
@@ -116,11 +116,6 @@ config PMAC_SMU
 	  on the "SMU" system control chip which replaces the old PMU.

drivers/macintosh/Kconfig config PMAC_SMU · line 121

Quoted 10 lines
drivers/macintosh/Kconfig +0 -5
 	  If you don't know, say Y.
 
-config PMAC_APM_EMU
-	tristate "APM emulation"
-	select APM_EMULATION
-	depends on ADB_PMU && PM && PPC32
-
 config PMAC_MEDIABAY
 	bool "Support PowerBook hotswap media bay"
 	depends on PPC_PMAC && PPC32

the obvious problem with the above is that APM_EMULATION is defined in kernel/power/Kconfig arch-independently thusly:

config APM_EMULATION

        tristate "Advanced Power Management Emulation"
        depends on PM && SYS_SUPPORTS_APM_EMULATION
        help
        ... blah blah ...

but the Kconfig variable SYS_SUPPORTS_APM_EMULATION is defined for only a small subset of architectures:

$ grep "config SYS_SUPPORTS_APM_EMULATION" $(find . -name Kconfig*)
./arch/mips/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/sh/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/arm/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/powerpc/Kconfig:config SYS_SUPPORTS_APM_EMULATION

so there's a good chance that doing a kernel config with any other
arch than those listed above that supports PM is going to generate the same warning.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================