Skip to contentSkip to conversation

ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

PATCH Superseded John Dahlstrom 2 participants 4 messages Feb 18, 2016 – Feb 22, 2016 x86 platform drivers

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

Some Lenovo ideapad models lack a physical rfkill switch. On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK, ideapad-laptop would wrongly report all radios as blocked by hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

---
Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27

Test configuration
Hardware: Lenovo ideapad Y700 Touch-15ISK
Kernel version: 4.4.2

Patch changelog
v2 split patch between Touch and non-Touch devices v3 undo patch split and limit summary to 72 characters

 drivers/platform/x86/ideapad-laptop.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/platform/x86/ideapad-laptop.c +0 -0
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
 			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
		},

+ },
+ {
+ .ident = "Lenovo ideapad Y700-15ISK",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700-15ISK"),
+ },
+ },
+ {
+ .ident = "Lenovo ideapad Y700 Touch-15ISK",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 Touch-15ISK"),
+ },
},
{

#1 lore raw
Quoted 11 lines · John Dahlstrom

Some Lenovo ideapad models lack a physical rfkill switch. On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK, ideapad-laptop would wrongly report all radios as blocked by hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

---
Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27

See stable_kernel_rules.txt for how to specify relevant versions. I'm curious why there is a gap from 3.18 to 4.1.

What you probably meant was:

Cc <[email protected]> # 3.18.x

If you are going to take this approach, you may wish to verify that this applies back to 3.18, otherwise you may need to specify dependencies (also described in the stable_kernel_rules).

My recommendation would be to simply leave the version off and let Greg and the other maintainers decide how far back to apply it, unless you really care about 3.18 working on these laptops.

If you don't mind leaving it up to them I can take this as is, otherwise, you'll need to update the Cc stable lines accordingly.

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center
#2 lore raw
Quoted 11 lines · Darren Hart

See stable_kernel_rules.txt for how to specify relevant versions. I'm curious why there is a gap from 3.18 to 4.1.

What you probably meant was:

Cc <[email protected]> # 3.18.x

If you are going to take this approach, you may wish to verify that this applies back to 3.18, otherwise you may need to specify dependencies (also described in the stable_kernel_rules).

Darren,

Thank you for your assistance.

The version gap in the earlier v3 comment reflected my earlier gap in verification. Today I stepped through the additional kernel versions to confirm the patch applies successfully to those versions, and have submitted the patch as v4.

Kernel version 3.18.27 already handles the 17" model of the ideapad Y700, so it would seem odd not to also handle the 15" model.

Kind regards,

John

#3 lore raw
Quoted 14 lines · John Dahlstrom
Quoted 11 lines · Darren Hart

See stable_kernel_rules.txt for how to specify relevant versions. I'm curious why there is a gap from 3.18 to 4.1.

What you probably meant was:

Cc <[email protected]> # 3.18.x

If you are going to take this approach, you may wish to verify that this applies back to 3.18, otherwise you may need to specify dependencies (also described in the stable_kernel_rules).

Quoted 8 lines

Darren,

Thank you for your assistance.

The version gap in the earlier v3 comment reflected my earlier gap in verification. Today I stepped through the additional kernel versions to confirm the patch applies successfully to those versions, and have submitted the patch as v4.

In this case, the patch should only have a single Cc line to stable:

Cc <[email protected]> # 3.18.x

I'll make the adjustment from your v4 myself to save you the resend ;-)

Quoted 3 lines

Kernel version 3.18.27 already handles the 17" model of the ideapad Y700, so it would seem odd not to also handle the 15" model.

We backport until it doesn't apply, but shouldn't be skipping versions as we go back, that would be simply unmaintainable. So I'll mark it as 3.18.x.

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center