qemuboot: move QB_MEM to default in qemuboot
PATCH 1/1 qemuboot: move QB_MEM to default in qemuboot
Previously, to satisfy opengl's requirement for at least 512MB of memory, QB_MEM was overriden by core-image-sato. This made it impossible for machine configurations to specify their own values, so this clause was moved to qemuboot instead and rewritten as a default to allow other recipes to state their own values if needed.
---
meta/classes/qemuboot.bbclass | 2 +- meta/recipes-sato/images/core-image-sato.bb | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
meta/classes/qemuboot.bbclass +0 -0
@@ -73,7 +73,7 @@
# IMAGE_CLASSES += "qemuboot"
# See "runqemu help" for more info
-QB_MEM ?= "-m 256"
+QB_MEM ?= '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}' QB_SERIAL_OPT ?= "-serial mon:stdio -serial null"QB_DEFAULT_KERNEL ?= "${KERNEL_IMAGETYPE}"QB_DEFAULT_FSTYPE ?= "ext4"
meta/recipes-sato/images/core-image-sato.bb +0 -0
@@ -11,5 +11,4 @@ inherit core-image
TOOLCHAIN_HOST_TASK_append = " nativesdk-intltool nativesdk-glib-2.0" TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"
-QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}' QB_MEM_qemumips = "-m 256"
--
2.17.1
I believe something similar was previously rejected on the grounds that the need for 512M of RAM is not about opengl in general, it's about Xorg failing to start when using glamor unless there's at least 512M. Otherwise, we should continue to verify images with just 256M.
Therefore it is image specific.
Alex
Quoted 48 lines · On Thu, 1 Oct 2020 at 14:46, <[email protected]> wrote:
Previously, to satisfy opengl's requirement for at least 512MB of memory,
QB_MEMwas overriden by core-image-sato. This made it impossible for machine configurations to specify their own values, so this clause was moved to qemuboot instead and rewritten as a default to allow other recipes to state their own values if needed.Signed-off-by Brett Warren <[email protected]>---
meta/classes/qemuboot.bbclass | 2 +-
meta/recipes-sato/images/core-image-sato.bb | 1 -2 files changed, 1 insertion(+), 2 deletions(-)meta/classes/qemuboot.bbclass +1
-1@@ -73,7 +73,7 @@ # IMAGE_CLASSES += "qemuboot" # See "runqemu help" for more info -QB_MEM ?= "-m 256" +QB_MEM ?= '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512","-m 256", d)}'
QB_SERIAL_OPT?= "-serial mon:stdio -serial null"QB_DEFAULT_KERNEL?= "${KERNEL_IMAGETYPE}"QB_DEFAULT_FSTYPE?= "ext4"meta/recipes-sato/images/core-image-sato.bb +0
-0@@ -11,5 +11,4 @@ inherit core-image
TOOLCHAIN_HOST_TASK_append= " nativesdk-intltool nativesdk-glib-2.0" TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"-QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
QB_MEM_qemumips= "-m 256"
--
2.17.1
Quoted 6 lines · Alexander Kanavin
I believe something similar was previously rejected on the grounds that the need for 512M of RAM is not about opengl in general, it's about Xorg failing to start when using glamor unless there's at least 512M. Otherwise, we should continue to verify images with just 256M.
Therefore it is image specific.
Right, it makes no sense for example to need/want 512MB for core-image- minimal.
Cheers,
Richard
Quoted 5 lines · Alexander Kanavin
I believe something similar was previously rejected on the grounds that the need for 512M of RAM is not about opengl in general, it's about Xorg failing to start when using glamor unless there's at least 512M...
Therefore it is image specific.
In that case I'll move the line back to core-image-sato, with the small modification that it'll no longer override machine configurations.
Cheers,
Brett
________________________________
From: [email protected] <[email protected]> on behalf of Richard Purdie via lists.openembedded.org <[email protected]>
Sent: 01 October 2020 15:12
To: Alexander Kanavin <[email protected]>; Brett Warren <[email protected]>
Cc: OE-core <[email protected]>
Subject: Re: [OE-core] [PATCH] qemuboot: move QB_MEM to default in qemuboot
Quoted 6 lines · Alexander Kanavin
I believe something similar was previously rejected on the grounds that the need for 512M of RAM is not about opengl in general, it's about Xorg failing to start when using glamor unless there's at least 512M. Otherwise, we should continue to verify images with just 256M.
Therefore it is image specific.
Right, it makes no sense for example to need/want 512MB for core-image- minimal.
Cheers,
Richard
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.