Skip to contentSkip to conversation

system: set default PATH according to BR2_ROOTFS_MERGED_USR

PATCH New Paul Cercueil 2 participants 4 messages Aug 8, 2020 – Aug 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 system: set default PATH according to BR2_ROOTFS_MERGED_USR

Use "/usr/bin:/usr/sbin" as the default path if BR2_ROOTFS_MERGED_USR is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin".

---
 system/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
system/Config.in +2 -1
index 5063797976..b8b7c16529 100644
@@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT
 
 config BR2_SYSTEM_DEFAULT_PATH
 	string "Set the system's default PATH"
-	default "/bin:/sbin:/usr/bin:/usr/sbin"
+	default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR
+	default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR
 	help
 	  Sets the system's default PATH. It is being used in
 	  /etc/profile in the skeleton-init-common package and by some
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 system: set default PATH according to BR2_ROOTFS_MERGED_USR

Paul, All,

On 2020-08-08 17:55 +0200, Paul Cercueil spake thusly:

Quoted 2 lines

Use "/usr/bin:/usr/sbin" as the default path if BR2_ROOTFS_MERGED_USR is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin".

Why? Is it fixing an issue, or is it just for the beauty of it?

However, see below...

Quoted 10 lines
---
 system/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
system/Config.in +0 -0
index 5063797976..b8b7c16529 100644

system/Config.in endif # BR2_ROOTFS_SKELETON_DEFAULT · line 405

Quoted 4 lines
system/Config.in +0 -1
@@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT
 
 config BR2_SYSTEM_DEFAULT_PATH
 	string "Set the system's default PATH"
-	default "/bin:/sbin:/usr/bin:/usr/sbin"

This default is a bit unfortunate. Traditionally, distributions have a default set to /usr/sbin:/usr/bin:/sbin:/bin (i.e. exactly the reverse order that we have).

However, we have that to keep the behaviour prior to 375f7488758.

system/Config.in endif # BR2_ROOTFS_SKELETON_DEFAULT · line 406

Quoted 2 lines
system/Config.in +2 -0
+	default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR
+	default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR

I have no strong opinion, but I wonder why you had to do that...

Regards,
Yann E. MORIN.

Quoted 10 lines
system/Config.in +0 -0
 	help
 	  Sets the system's default PATH. It is being used in
 	  /etc/profile in the skeleton-init-common package and by some
Signature · 6 lines
2.28.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 system: set default PATH according to BR2_ROOTFS_MERGED_USR

Hi Yann,

Le jeu. 13 ao?t 2020 ? 23:38, Yann E. MORIN <[email protected]> a ?crit :

Quoted 8 lines

Paul, All,

On 2020-08-08 17:55 +0200, Paul Cercueil spake thusly:

Quoted 3 lines

Use "/usr/bin:/usr/sbin" as the default path if
BR2_ROOTFS_MERGED_USR
is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin".

Why? Is it fixing an issue, or is it just for the beauty of it?

I got a PR to remove /bin:/sbin from the BR2_SYSTEM_DEFAULT_PATH in my tree, I thought it made more sense to do it this way.

Cheers,
-Paul

Quoted 53 lines

However, see below...

Quoted 11 lines

---

  system/Config.in | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/system/Config.in b/system/Config.in index 5063797976..b8b7c16529 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT

Quoted 3 lines

config BR2_SYSTEM_DEFAULT_PATH
string "Set the system's default PATH"
- default "/bin:/sbin:/usr/bin:/usr/sbin"

This default is a bit unfortunate. Traditionally, distributions have a default set to /usr/sbin:/usr/bin:/sbin:/bin (i.e. exactly the reverse order that we have).

However, we have that to keep the behaviour prior to 375f7488758.

Quoted 2 lines

+ default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR
+ default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR

I have no strong opinion, but I wonder why you had to do that...

Regards,
Yann E. MORIN.

Quoted 10 lines

help
Sets the system's default PATH. It is being used in /etc/profile in the skeleton-init-common package and by some
--
2.28.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' 
conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___      
         |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  
There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   
conspiracy.  |

'------------------------------^-------^------------------^--------------------'

#3 lore raw

PATCH 1/1 system: set default PATH according to BR2_ROOTFS_MERGED_USR

In reply to Paul Cercueil

Paul, All,

On 2020-08-08 17:55 +0200, Paul Cercueil spake thusly:

Quoted 4 lines

Use "/usr/bin:/usr/sbin" as the default path if BR2_ROOTFS_MERGED_USR is enabled, otherwise use "/bin:/sbin:/usr/bin:/usr/sbin".

Applied to next, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 system/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
system/Config.in +2 -1
index 5063797976..b8b7c16529 100644
@@ -402,7 +402,8 @@ endif # BR2_ROOTFS_SKELETON_DEFAULT
 
 config BR2_SYSTEM_DEFAULT_PATH
 	string "Set the system's default PATH"
-	default "/bin:/sbin:/usr/bin:/usr/sbin"
+	default "/usr/bin:/usr/sbin" if BR2_ROOTFS_MERGED_USR
+	default "/bin:/sbin:/usr/bin:/usr/sbin" if !BR2_ROOTFS_MERGED_USR
 	help
 	  Sets the system's default PATH. It is being used in
 	  /etc/profile in the skeleton-init-common package and by some
Signature · 6 lines
2.28.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'