Skip to contentSkip to conversation

struct char_device

PATCH [email protected] 2 participants 2 messages May 22, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines · Alexander Viro

patch below adds the missing half of kdev_t - for block devices we already have a unique pointer and that adds a similar animal for character devices.

Very good.
(Of course I did precisely the same, but am a bit slower in submitting things during a stable series or code freeze.)

One remark, repeating what I wrote on some web page:
-----
A struct block_device provides the connection between a device number and a struct block_device_operations.
...
Clearly, we also want to associate a struct char_device_operations to a character device number. When we do this, all bdev code will have to be duplicated for cdev, so there seems no point in having bdev code - kdev, for both bdev and cdev, seems more elegant.
-----

And a second remark: don't forget that presently the point where bdev is introduced is not quite right. We must only introduce it when we really have a device, not when there only is a device number (like on a mknod call).

Andries

#1 lore raw
Quoted 7 lines · On Tue, 22 May 2001 [email protected] wrote:

One remark, repeating what I wrote on some web page:
-----
A struct block_device provides the connection between a device number and a struct block_device_operations.
...
Clearly, we also want to associate a struct char_device_operations to a character device number. When we do this, all bdev code will

They are entirely different. Too different sets of operations.

Quoted 3 lines

have to be duplicated for cdev, so there seems no point in having bdev code - kdev, for both bdev and cdev, seems more elegant.
-----

Not really. For struct block_device you have partitioning stuff sitting nearby. It should be handled by generic code. Nothing of that kind for character devices.

But the main point is that for block devices ->read() and ->write() do not belong to the natural interface. Request queue does. They are about as far from each other as from FIFOs and sockets.

Quoted 4 lines

And a second remark: don't forget that presently the point where bdev is introduced is not quite right. We must only introduce it when we really have a device, not when there only is a device number (like on a mknod call).

That's simply wrong. kdev_t is used for unopened objects quite often.