Skip to contentSkip to conversation

struct char_device

PATCH [email protected] 2 participants 2 messages May 23, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

why not implement partitions as simply doing block remaps

Everybody agrees.

Andries

#1 lore raw
Quoted 4 lines · On Wed, 23 May 2001 [email protected] wrote:
Quoted 2 lines

why not implement partitions as simply doing block remaps

Everybody agrees.

No they don't.

Look at the cost of lvm. Function calls, buffer head remapping, the works. You _need_ that for a generic LVM layer, but you sure as hell don't need it for simple partitioning.

Can LVM do it? Sure.

Do we need LVM to do it? No.

Does LVM simplify anything? No.

It doesn't get much simpler than a single line that does the equivalent of "bh->sector += offset". Most of the bulk of the code in the partitioning stuff is for actually parsing the partitions, and we need that to bootstrap. Maybe we can get rid of some of the more esoteric ones (ie pretty much everything except for the native partitioning code for each architecture) and tell people to use LVM for the rest.

In short, there are _no_ advantages to involve LVM here.

Linus