Skip to contentSkip to conversation

2.4.11 loses sda9

DISCUSSION [email protected] 2 participants 2 messages Oct 11, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines · Andreas Dilger

You probably need to go into fdisk and change the partition type of sda9 from "0" to "83" (or any other non-zero type). There is a reason that it is saying "omitting empty partition (9)" at boot, and "fdisk -l" doesn't list it - because type "0" means "I don't exist".

If I am not mistaken, it is fdisk rather than the kernel that says "omitting empty partition (9)". (And the latest fdisk no longer deletes partitions of type 0 from its listings.)
The sys_type field never had any significance to the kernel.

Andries

[By the way, it is a sad sight to see patch-2.4.11. Where my own sources use dev->hardsect_size , and intermediate sources use get_hardsect_size(dev) an inline function defined roughly either as

        dev->hardsect_size

or as
hardsect_size[MAJOR(dev)][MINOR(dev)]
so as to make it easy to switch between compiles where a kdev_t is a number and we use the infamous arrays, and compiles where a kdev_t is a pointer to a device struct, and no arrays exist, I now see that get_hardsect_size(dev) is replaced by

        get_hardsect_size(to_kdev_t(bdev->bd_dev))

. Yecch.
Al, I never understood why you want to introduce a struct block_device * to do precisely what kdev_t was designed to do.]

#1 lore raw
Quoted 10 lines · On Thu, 11 Oct 2001 [email protected] wrote:

so as to make it easy to switch between compiles where a kdev_t is a number and we use the infamous arrays, and compiles where a kdev_t is a pointer to a device struct, and no arrays exist, I now see that get_hardsect_size(dev) is replaced by

        get_hardsect_size(to_kdev_t(bdev->bd_dev))

. Yecch.
Al, I never understood why you want to introduce a struct block_device * to do precisely what kdev_t was designed to do.]

We had been through that way too many times. You know what problems with unified device struct I've brought before. You know what problems I have with your 64bit dev_t. And you know _very_ well that any patches in that area should be done in small steps.

Hell, I'd prefer that one to be done _much_ slower - with decent debugging between the steps instead of "we've got to close the holes opened by bdev-in-pagecache _NOW_" kind of situation we'd got.

IMO eventually we should have per-disk structure and keep reference to it from struct block_device. Then get_hardsect_size() wiuld turn into access to field of that beast (and would take struct block_device * as an argument). But that's 2.5 stuff and I bloody refuse to participate in attempts to do everything in one huge leap. One we'd got is already bad enough.