Skip to contentSkip to conversation

dt-bindings: usb: Use OF graph schema

PATCH In review Rob Herring 4 participants 4 messages Jan 12, 2021 – Jan 13, 2021

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: usb: Use OF graph schema

Now that we have a graph schema, rework the USB related schemas to use it. Mostly this is adding a reference to graph.yaml and dropping duplicate parts from schemas.

Cc Greg Kroah-Hartman <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Biju Das <[email protected]>
---
 .../devicetree/bindings/usb/renesas,usb3-peri.yaml        | 7 ++++---
 Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml   | 8 ++++----
 2 files changed, 8 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml +4 -3
index 929a3f413b44..9fcf54b10b07 100644
@@ -54,18 +54,19 @@ properties:
     description: phandle of a companion.
 
   ports:
+    $ref: /schemas/graph.yaml#/properties/ports
     description: |
       any connector to the data bus of this controller should be modelled
       using the OF graph bindings specified, if the "usb-role-switch"
       property is used.
-    type: object
+
     properties:
       port@0:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: High Speed (HS) data bus.
 
       port@1:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Super Speed (SS) data bus.
 
     required:
Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml +4 -4
index 52ceb07294a3..b86bf6bc9cd6 100644
@@ -26,17 +26,17 @@ properties:
     maxItems: 1
 
   ports:
+    $ref: /schemas/graph.yaml#/properties/ports
     description: OF graph bindings (specified in bindings/graph.txt) that model
       SS data bus to the SS capable connector.
-    type: object
+
     properties:
       port@0:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Super Speed (SS) MUX inputs connected to SS capable connector.
-        $ref: /connector/usb-connector.yaml#/properties/ports/properties/port@1
 
       port@1:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Output of 2:1 MUX connected to Super Speed (SS) data bus.
 
     required:
Signature · 1 line
2.27.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Rob Herring

Now that we have a graph schema, rework the USB related schemas to use it. Mostly this is adding a reference to graph.yaml and dropping duplicate parts from schemas.

Cc Greg Kroah-Hartman <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Biju Das <[email protected]>
Quoted 4 lines
---
 .../devicetree/bindings/usb/renesas,usb3-peri.yaml        | 7 ++++---
 Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml   | 8 ++++----
 2 files changed, 8 insertions(+), 7 deletions(-)
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 15 lines

-----Original Message-----
From: Rob Herring <[email protected]>
Sent: 12 January 2021 15:35
To: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>; Yoshihiro Shimoda <[email protected]>; Biju Das <[email protected]>; [email protected]
Subject: [PATCH] dt-bindings: usb: Use OF graph schema

Now that we have a graph schema, rework the USB related schemas to use it. Mostly this is adding a reference to graph.yaml and dropping duplicate parts from schemas.

Quoted 5 lines
Cc Greg Kroah-Hartman <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Biju Das <[email protected]>

Cheers,
Biju

Quoted 66 lines
---
 .../devicetree/bindings/usb/renesas,usb3-peri.yaml        | 7 ++++---
 Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml   | 8 ++++----
 2 files changed, 8 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml +4 -3
index 929a3f413b44..9fcf54b10b07 100644
@@ -54,18 +54,19 @@ properties:
     description: phandle of a companion.
 
   ports:
+    $ref: /schemas/graph.yaml#/properties/ports
     description: |
       any connector to the data bus of this controller should be modelled
       using the OF graph bindings specified, if the "usb-role-switch"
       property is used.
-    type: object
+
     properties:
       port@0:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: High Speed (HS) data bus.
 
       port@1:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Super Speed (SS) data bus.
 
     required:
Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml +1 -0
index 52ceb07294a3..b86bf6bc9cd6 100644
@@ -26,17 +26,17 @@ properties:
     maxItems: 1
 
   ports:
+    $ref: /schemas/graph.yaml#/properties/ports
     description: OF graph bindings (specified in bindings/graph.txt) that

model
SS data bus to the SS capable connector.

Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml +2 -2
-    type: object
+
     properties:
       port@0:
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Super Speed (SS) MUX inputs connected to SS capable

connector.
- $ref: /connector/usb-
connector.yaml#/properties/ports/properties/port@1

       port@1:
Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml +1 -1
-        type: object
+        $ref: /schemas/graph.yaml#/properties/port
         description: Output of 2:1 MUX connected to Super Speed (SS) data

bus.

required:
--
2.27.0

Reviewed-by on v1 1/1
#3 lore raw
In reply to Rob Herring
Quoted 11 lines

From: Rob Herring, Sent: Wednesday, January 13, 2021 12:35 AM

Now that we have a graph schema, rework the USB related schemas to use it. Mostly this is adding a reference to graph.yaml and dropping duplicate parts from schemas.

Cc Greg Kroah-Hartman <[email protected]>
Cc Yoshihiro Shimoda <[email protected]>
Cc Biju Das <[email protected]>

Best regards,
Yoshihiro Shimoda