Skip to contentSkip to conversation

drivers: net: wireless: realtek: Fix the word association defautly de-faulty

PATCH In review Bhaskar Chowdhury 5 participants 10 messages Jan 5, 2021 – Jan 6, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: net: wireless: realtek: Fix the word association defautly de-faulty

s/defautly/de-faulty/p

---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +1 -1
index c948dafa0c80..7d02d8abb4eb 100644
@@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
 	u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
 
 	/*beacon packet will only use the first
-	 *descriptor defautly,and the own may not
+	 *descriptor de-faulty,and the own may not
 	 *be cleared by the hardware
 	 */
 	if (own)

--
2.26.2

#1 lore raw

Hi Bhaskar,

Quoted 14 lines · Bhaskar Chowdhury

s/defautly/de-faulty/p

---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +0 -0
index c948dafa0c80..7d02d8abb4eb 100644

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) · line 817

Quoted 5 lines
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +1 -1
@@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
        u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
 
        /*beacon packet will only use the first
-        *descriptor defautly,and the own may not
+        *descriptor de-faulty,and the own may not

Really? "de-faultly" isn't any better than "defaultly" and in fact it's even worse as it breaks up the word "default".

This change doesn't make sense and the comment really needs to be completely re-written by someone who understands what's going on here as it barely makes sense.

Thanks,

Signature · 4 lines
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
#2 lore raw
Quoted 19 lines · Julian Calaby

Hi Bhaskar,

Quoted 16 lines · Bhaskar Chowdhury

s/defautly/de-faulty/p

---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +0 -0
index c948dafa0c80..7d02d8abb4eb 100644
@@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
        u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
 
Quoted 7 lines

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) · line 817

Quoted 3 lines
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +1 -1
        /*beacon packet will only use the first
-        *descriptor defautly,and the own may not
+        *descriptor de-faulty,and the own may not

Really? "de-faultly" isn't any better than "defaultly" and in fact it's even worse as it breaks up the word "default".

hey, it was written as "defautly" ...and that was simple spelling mistake .. so,corrected it.

Quoted 11 lines

This change doesn't make sense and the comment really needs to be completely re-written by someone who understands what's going on here as it barely makes sense.

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

#3 lore raw

Hi Bhaskar,

Quoted 28 lines · Bhaskar Chowdhury
Quoted 19 lines · Julian Calaby

Hi Bhaskar,

Quoted 16 lines · Bhaskar Chowdhury

s/defautly/de-faulty/p

---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +0 -0
index c948dafa0c80..7d02d8abb4eb 100644
@@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
        u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
 
Quoted 7 lines

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) · line 817

Quoted 3 lines
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +1 -1
        /*beacon packet will only use the first
-        *descriptor defautly,and the own may not
+        *descriptor de-faulty,and the own may not

Really? "de-faultly" isn't any better than "defaultly" and in fact it's even worse as it breaks up the word "default".

Quoted 2 lines

hey, it was written as "defautly" ...and that was simple spelling mistake .. so,corrected it.

Er, no, that isn't the correct replacement. They're using "default" as a verb and mean "by default".

The sentence makes no sense with "de-faulty" there instead.

Ultimately though the entire comment barely makes sense, so the best way to fix this spelling mistake is to re-write the entire comment so it does. I would have suggested a new wording for it, but I don't know enough about what's going on here to parse the rest of it.

So therefore someone who knows what's going on here needs to fix this and your change is just making this comment worse.

Thanks,

Signature · 4 lines
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
#4 lore raw
Quoted 34 lines · Julian Calaby

Hi Bhaskar,

Quoted 28 lines · Bhaskar Chowdhury
Quoted 19 lines · Julian Calaby

Hi Bhaskar,

Quoted 16 lines · Bhaskar Chowdhury

s/defautly/de-faulty/p

---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +0 -0
index c948dafa0c80..7d02d8abb4eb 100644
@@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
        u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
 
Quoted 7 lines

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) · line 817

Quoted 3 lines
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +1 -1
        /*beacon packet will only use the first
-        *descriptor defautly,and the own may not
+        *descriptor de-faulty,and the own may not

Really? "de-faultly" isn't any better than "defaultly" and in fact it's even worse as it breaks up the word "default".

Quoted 2 lines

hey, it was written as "defautly" ...and that was simple spelling mistake .. so,corrected it.

Quoted 8 lines

Er, no, that isn't the correct replacement. They're using "default" as a verb and mean "by default".

The sentence makes no sense with "de-faulty" there instead.

Ultimately though the entire comment barely makes sense, so the best way to fix this spelling mistake is to re-write the entire comment so it does. I would have suggested a new wording for it, but I don't know

hmmmm make sense...

Quoted 5 lines

enough about what's going on here to parse the rest of it.

So therefore someone who knows what's going on here needs to fix this

and your change is just making this comment worse.

really??? Not sure about it.

Quoted 8 lines

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

#5 lore raw
Quoted 2 lines · Bhaskar Chowdhury
Quoted 1 line · Julian Calaby

Hi Bhaskar,

[]

Quoted 2 lines
Quoted 1 line

and your change is just making this comment worse.

really??? Not sure about it.

I agree with Julian. I'm fairly sure it's worse.
The change you suggest doesn't parse well and is extremely odd. If you _really_ want to just change this use (and the others), I repeat his suggestion of "by default".

#6 lore raw
Quoted 11 lines · Joe Perches
Quoted 2 lines · Bhaskar Chowdhury
Quoted 1 line · Julian Calaby

Hi Bhaskar,

[]

Quoted 2 lines
Quoted 1 line

and your change is just making this comment worse.

really??? Not sure about it.

I agree with Julian. I'm fairly sure it's worse.
The change you suggest doesn't parse well and is extremely odd. If you _really_ want to just change this use (and the others), I repeat his suggestion of "by default".

I agree with Julian and Joe. Your suggested change makes it worse!

To match ALL previous commits/patches for these drivers, the subject should be "rtlwifi: <driver_name>: Fix description of usage of own bit in descriptor"

For all drivers, that comment should be written as:

        /* By default, a beacon packet will only use the first
         * descriptor and the own bit may not be cleared by the hardware
         */

Larry

#7 lore raw
In reply to Bhaskar Chowdhury
Quoted 13 lines · Bhaskar Chowdhury

s/defautly/de-faulty/p

---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +0 -0
index c948dafa0c80..7d02d8abb4eb 100644

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)

Quoted 9 lines
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +1 -2
@@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
 	u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
 
 	/*beacon packet will only use the first
-	 *descriptor defautly,and the own may not
+	 *descriptor de-faulty,and the own may not
 	 *be cleared by the hardware
 	 */
 	if (own)
--

Yes, I agree with "by default". I don't know what "the own" means.

Also, there should be a space after each beginning "*.

I saw another patch where the comment block began with /**, which should mean "begin kernel-doc comment block", but it's not kernel-doc, so that /** should be changed to just "/*".

Signature · 1 line
~Randy
#8 lore raw
Quoted 27 lines · Randy Dunlap
Quoted 13 lines · Bhaskar Chowdhury

s/defautly/de-faulty/p

---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +0 -0
index c948dafa0c80..7d02d8abb4eb 100644

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)

Quoted 9 lines
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c +1 -2
@@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
 	u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
 
 	/*beacon packet will only use the first
-	 *descriptor defautly,and the own may not
+	 *descriptor de-faulty,and the own may not
 	 *be cleared by the hardware
 	 */
 	if (own)
--

Yes, I agree with "by default". I don't know what "the own" means.

Quoted 7 lines

Also, there should be a space after each beginning "*.

I saw another patch where the comment block began with /**, which should mean "begin kernel-doc comment block", but it's not kernel-doc, so that /** should be changed to just "/*".

Good point Randy, there were several driver file witch have "defautly" in it and I tried to correct that.Only that spell made it a "de-faulty" as dic suggested . But I think it should be "by default" as you said.

The comment beginning part , let me hunt down that and fix it as you mentioned the way it should be.

Thanks Randy.

Quoted 3 lines

--
~Randy

#9 lore raw
Quoted 3 lines · Bhaskar Chowdhury

Good point Randy, there were several driver file witch have "defautly" in it and I tried to correct that.Only that spell made it a "de-faulty" as dic suggested . But I think it should be "by default" as you said.

What tool suggested 'de-faulty' with a dash between de and faulty"

I don't believe it was codespell.

$ codespell drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:61: cacluated ==> calculated
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:190: cacluated ==> calculated
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:435: managment ==> management
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:817: defautly ==> defaultly

Nor checkpatch:

$ ./scripts/checkpatch.pl -f --terse --nosummary --types=typo_spelling drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:61: CHECK: 'cacluated' may be misspelled - perhaps 'calculated'?
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:190: CHECK: 'cacluated' may be misspelled - perhaps 'calculated'?
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:435: CHECK: 'managment' may be misspelled - perhaps 'management'?