kunit: tool: Force the use of the 'tty' console for UML
PATCH 1/1 kunit: tool: Force the use of the 'tty' console for UML
kunit_tool relies on the UML console outputting printk() output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.
This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.
--- tools/testing/kunit/kunit_kernel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/kunit/kunit_kernel.py +1 -1
@@ -198,7 +198,7 @@ class LinuxSourceTree(object): return self.validate_config(build_dir) def run_kernel(self, args=[], build_dir='', timeout=None): - args.extend(['mem=1G']) + args.extend(['mem=1G', 'console=tty']) self._ops.linux_bin(args, timeout, build_dir) outfile = get_outfile_path(build_dir) subprocess.call(['stty', 'sane'])
Signature · 1 line
2.29.2.729.g45daf8777d-goog
Quoted 11 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.
Thanks!
Quoted 24 lines
Signed-off-by David Gow <[email protected]>Fixes 757055ae8ded ("init/console: Use ttynull as a fallback when there is no console")--- tools/testing/kunit/kunit_kernel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/kunit/kunit_kernel.py +1
-1@@ -198,7 +198,7 @@ class LinuxSourceTree(object): return self.validate_config(build_dir) def run_kernel(self, args=[], build_dir='', timeout=None): - args.extend(['mem=1G']) + args.extend(['mem=1G', 'console=tty']) self._ops.linux_bin(args, timeout, build_dir) outfile = get_outfile_path(build_dir) subprocess.call(['stty', 'sane'])Signature · 1 line
2.29.2.729.g45daf8777d-goog
Signature · 2 lines
With Best Regards, Andy Shevchenko
Shuah Khan
maintainerQuoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.
Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>
Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Sorry for the delay - have been away from the keyboard for a bit.
thanks,
-- Shuah
Quoted 18 lines · Shuah Khan
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>
Quoted 6 lines
Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Sorry for the delay - have been away from the keyboard for a bit.
JFYI, I am not sure that this is the right solution. I am looking into it, see
https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/
for more details.
Best Regards,
Petr
Shuah Khan
maintainerQuoted 23 lines · Petr Mladek
Quoted 22 lines · Shuah Khan
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Quoted 8 lines
Quoted 2 lines
Sorry for the delay - have been away from the keyboard for a bit.
JFYI, I am not sure that this is the right solution. I am looking into it, see
https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/
for more details.
Thanks Petr. I will hold off on sending the patch up to Linus and let you find a the right solution.
thanks,
-- Shuah
Quoted 27 lines · Shuah Khan
Quoted 26 lines · Petr Mladek
Quoted 24 lines · Shuah Khan
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Sorry for the delay - have been away from the keyboard for a bit.
Quoted 8 lines
Quoted 5 lines
JFYI, I am not sure that this is the right solution. I am looking into it, see
https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/
for more details.Thanks Petr. I will hold off on sending the patch up to Linus and let you find a the right solution.
Please. leave it in Linux Next at least. Otherwise kunit will be broken for a long time which is not good.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Shuah Khan
maintainerQuoted 34 lines · Andy Shevchenko
Quoted 33 lines · Shuah Khan
Quoted 31 lines · Petr Mladek
Quoted 18 lines · Shuah Khan
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>Quoted 6 lines
Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Sorry for the delay - have been away from the keyboard for a bit.
JFYI, I am not sure that this is the right solution. I am looking into it, see
https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/
for more details.
Quoted 7 lines
Quoted 2 lines
Thanks Petr. I will hold off on sending the patch up to Linus and let you find a the right solution.
Please. leave it in Linux Next at least. Otherwise kunit will be broken for a long time which is not good.
Yes. That is the plan. It will be in there until real fix comes in.
thanks,
-- Shuah
Quoted 39 lines · Shuah Khan
Quoted 37 lines · Andy Shevchenko
Quoted 35 lines · Shuah Khan
Quoted 23 lines · Petr Mladek
Quoted 22 lines · Shuah Khan
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Quoted 8 lines
Quoted 2 lines
Sorry for the delay - have been away from the keyboard for a bit.
JFYI, I am not sure that this is the right solution. I am looking into it, see
https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/
for more details.Thanks Petr. I will hold off on sending the patch up to Linus and let you find a the right solution.
Quoted 7 lines
Quoted 4 lines
Please. leave it in Linux Next at least. Otherwise kunit will be broken for a long time which is not good.
Yes. That is the plan. It will be in there until real fix comes in.
Thanks, Shuah.
Personally, I think that this patch makes some sense to keep even if the underlying issue with ttynull is resolved. Given that kunit.py requires the console output, explicitly stating we want console=tty set is probably worth doing rather than relying on it being the default. That being said, I definitely agree that this patch doesn't fix the underlying issue with UML/ttynull: it just makes the kunit.py script less sensitive to such changes (which, while unlikely, could potentially occur legitimately down the track).
Cheers,
-- David
Quoted 40 lines · David Gow
Quoted 39 lines · Shuah Khan
Quoted 37 lines · Andy Shevchenko
Quoted 35 lines · Shuah Khan
Quoted 23 lines · Petr Mladek
Quoted 22 lines · Shuah Khan
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Quoted 8 lines
Quoted 2 lines
Sorry for the delay - have been away from the keyboard for a bit.
JFYI, I am not sure that this is the right solution. I am looking into it, see
https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/
for more details.Thanks Petr. I will hold off on sending the patch up to Linus and let you find a the right solution.
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Please. leave it in Linux Next at least. Otherwise kunit will be broken for a long time which is not good.
Yes. That is the plan. It will be in there until real fix comes in.
The real fix would be too complicated for 5.11-rc3. Instead, I proposed to revert the problematic commit, see
https://lore.kernel.org/lkml/[email protected]/
I would like to push it for 5.11-rc3.
Quoted 5 lines
Personally, I think that this patch makes some sense to keep even if the underlying issue with ttynull is resolved. Given that
kunit.pyrequires the console output, explicitly stating we want console=tty set is probably worth doing rather than relying on it being the default.
I agree that the patch makes sense on its own. kunit depends on the particular console. Note that "tty" is actually the UML-specific stdio console implemented in arch/um/drivers/stdio_console.c.
Best Regards,
Petr
Shuah Khan
maintainerQuoted 59 lines · Petr Mladek
Quoted 40 lines · David Gow
Quoted 39 lines · Shuah Khan
Quoted 37 lines · Andy Shevchenko
Quoted 35 lines · Shuah Khan
Quoted 23 lines · Petr Mladek
Quoted 22 lines · Shuah Khan
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.Quoted 6 lines
Quoted 2 lines
Reported-by Andy Shevchenko <[email protected]>Tested-by Andy Shevchenko <[email protected]>Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Quoted 8 lines
Quoted 2 lines
Sorry for the delay - have been away from the keyboard for a bit.
JFYI, I am not sure that this is the right solution. I am looking into it, see
https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/
for more details.Thanks Petr. I will hold off on sending the patch up to Linus and let you find a the right solution.
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Please. leave it in Linux Next at least. Otherwise kunit will be broken for a long time which is not good.
Yes. That is the plan. It will be in there until real fix comes in.
The real fix would be too complicated for 5.11-rc3. Instead, I proposed to revert the problematic commit, see
https://lore.kernel.org/lkml/[email protected]/
I would like to push it for 5.11-rc3.Quoted 5 lines
Personally, I think that this patch makes some sense to keep even if the underlying issue with ttynull is resolved. Given that
kunit.pyrequires the console output, explicitly stating we want console=tty set is probably worth doing rather than relying on it being the default.
Quoted 4 lines
I agree that the patch makes sense on its own. kunit depends on the particular console. Note that "tty" is actually the UML-specific stdio console implemented in
arch/um/drivers/stdio_console.c.
The proposal sounds like revert the problem commit https://lore.kernel.org/lkml/[email protected]/
and also send kunit fix up. Sounds reasonable to me. I will send it for 5.11-rc3
thanks,
-- Shuah
Quoted 10 lines · David Gow
kunit_toolrelies on the UML console outputtingprintk()output to the tty in order to get results. Since the default console driver could change, pass 'console=tty' to the kernel.This is triggered by a change[1] to use ttynull as a fallback console driver which -- by chance or by design -- seems to have changed the default console output on UML, breaking
kunit_tool. While this may be fixed, we should be less fragile to such changes in the default.
Quoted 5 lines
Signed-off-by David Gow <[email protected]>Fixes 757055ae8ded ("init/console: Use ttynull as a fallback when there is no console")
Thanks for taking care of this!