Skip to contentSkip to conversation

net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig

PATCH Applied Marek Vasut 3 participants 3 messages Jan 11, 2021 – Jan 13, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig

The PHYLIB must be selected to provide mdiobus_*() functions, and the MICREL_PHY is necessary too, as that is the only possible PHY attached to the KS8851 (it is the internal PHY).

Fixes ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY")
Cc Andrew Lunn <[email protected]>
Cc Heiner Kallweit <[email protected]>
Cc Lukas Wunner <[email protected]>
---
 drivers/net/ethernet/micrel/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/micrel/Kconfig +4 -0
index 42bc014136fe..93df3049cdc0 100644
@@ -31,6 +31,8 @@ config KS8851
 	select MII
 	select CRC32
 	select EEPROM_93CX6
+	select PHYLIB
+	select MICREL_PHY
 	help
 	  SPI driver for Micrel KS8851 SPI attached network chip.
 
@@ -40,6 +42,8 @@ config KS8851_MLL
 	select MII
 	select CRC32
 	select EEPROM_93CX6
+	select PHYLIB
+	select MICREL_PHY
 	help
 	  This platform driver is for Micrel KS8851 Address/data bus
 	  multiplexed network chip.
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Marek Vasut

The PHYLIB must be selected to provide mdiobus_*() functions, and the MICREL_PHY is necessary too, as that is the only possible PHY attached to the KS8851 (it is the internal PHY).

Fixes ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY")
Cc Andrew Lunn <[email protected]>
Cc Heiner Kallweit <[email protected]>
Cc Lukas Wunner <[email protected]>

Andrew

maintainer Applied
#2 lore raw
Quoted 5 lines · On Mon, 11 Jan 2021 15:49:33 +0100 Andrew Lunn wrote:
Quoted 4 lines · Marek Vasut

The PHYLIB must be selected to provide mdiobus_*() functions, and the MICREL_PHY is necessary too, as that is the only possible PHY attached to the KS8851 (it is the internal PHY).

Quoted 7 lines
Quoted 5 lines
Fixes ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY")
Cc Andrew Lunn <[email protected]>
Cc Heiner Kallweit <[email protected]>
Cc Lukas Wunner <[email protected]>

Applied, thanks!