USB: xhci: Enable HCE event reset function
Subsystems (2)
RFC PATCH 1/1 USB: xhci: Enable HCE event reset function
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()
|----xhci_halt()
|----xhci_shutdown()
|----xhci_start()
|----xhci_run()--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/usb/host/xhci-ring.c +10 -0
@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; } +if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + } +/* * Clear the op reg interrupt status first, * so we can receive interrupts from other MSI-X interrupters.
Signature · 1 line
2.8.1
Greg KH
maintainerQuoted 11 lines · Longfang Liu
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()|----xhci_halt() |----xhci_shutdown() |----xhci_start() |----xhci_run()
Quoted 4 lines
Signed-off-by Longfang Liu <[email protected]>--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
$ ./scripts/get_maintainer.pl --file drivers/usb/host/xhci-ring.c Mathias Nyman <[email protected]> (supporter:USB XHCI DRIVER) Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM) [email protected] (open list:USB XHCI DRIVER) [email protected] (open list)
Any reason to not include the maintainer of the xhci driver here?
Quoted 8 lines
drivers/usb/host/xhci-ring.c +0
-0@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; }
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2869
Quoted 10 lines
drivers/usb/host/xhci-ring.c +10
-0+if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + } +
Does this fix a real problem for you? Are you sure we will not suddenly start resetting devices that were working properly and sending this error incorrectly? How did you test this?
thanks,
greg k-h
On 2020/11/18 15:02, Greg KH Wrote:
Quoted 17 lines · Longfang Liu
Quoted 11 lines
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()|----xhci_halt() |----xhci_shutdown() |----xhci_start() |----xhci_run()Quoted 4 lines
Signed-off-by Longfang Liu <[email protected]>--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
Quoted 7 lines
$ ./scripts/get_maintainer.pl --file drivers/usb/host/xhci-ring.c Mathias Nyman <[email protected]> (supporter:USB XHCI DRIVER) Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM) [email protected] (open list:USB XHCI DRIVER) [email protected] (open list)Any reason to not include the maintainer of the xhci driver here?
OK, I will include the maintainer in the next patch.
Quoted 24 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c +0
-0@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; }drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2869
Quoted 10 lines
drivers/usb/host/xhci-ring.c +10
-0+if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + } +Does this fix a real problem for you? Are you sure we will not suddenly start resetting devices that were working properly and sending this error incorrectly? How did you test this?
Quoted 5 lines
thanks,
greg k-h
.
Yes, we want to add a RAS feature to the USB,
Use the HCE event to trigger the reset operation of the USB controller.
By searching for the current xhci driver, the driver did not handle HCE event. In fact, I am not sure if other operations will cause HCE, The HCE event is used to reset the USB controller according to the definition of the event.
I test this reset operation through the Sysfs file, but have not tested all usage scenarios. Thanks.
Longfang
Greg KH
maintainerQuoted 50 lines · liulongfang
On 2020/11/18 15:02, Greg KH Wrote:
Quoted 17 lines · Longfang Liu
Quoted 11 lines
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()|----xhci_halt() |----xhci_shutdown() |----xhci_start() |----xhci_run()Quoted 4 lines
Signed-off-by Longfang Liu <[email protected]>--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 7 lines
$ ./scripts/get_maintainer.pl --file drivers/usb/host/xhci-ring.c Mathias Nyman <[email protected]> (supporter:USB XHCI DRIVER) Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM) [email protected] (open list:USB XHCI DRIVER) [email protected] (open list)Any reason to not include the maintainer of the xhci driver here?
OK, I will include the maintainer in the next patch.
Quoted 24 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c +0
-0@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; }drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2869
Quoted 10 lines
drivers/usb/host/xhci-ring.c +10
-0+if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + } +Does this fix a real problem for you? Are you sure we will not suddenly start resetting devices that were working properly and sending this error incorrectly? How did you test this?
Quoted 6 lines
Quoted 5 lines
thanks,
greg k-h
.Yes, we want to add a RAS feature to the USB,
What is "RAS"?
Quoted 1 line
Use the HCE event to trigger the reset operation of the USB controller.
Is that allowed by the XHCI specification?
Quoted 3 lines
By searching for the current xhci driver, the driver did not handle HCE event. In fact, I am not sure if other operations will cause HCE, The HCE event is used to reset the USB controller according to the definition of the event.
What generates that event? Do existing controllers do that today? What causes it?
Quoted 1 line
I test this reset operation through the Sysfs file, but have not tested all usage scenarios.
What sysfs file?
thanks,
greg k-h
Quoted 36 lines · Greg KH
Quoted 35 lines · liulongfang
On 2020/11/18 15:02, Greg KH Wrote:
Quoted 17 lines · Longfang Liu
Quoted 11 lines
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()|----xhci_halt() |----xhci_shutdown() |----xhci_start() |----xhci_run()Quoted 4 lines
Signed-off-by Longfang Liu <[email protected]>--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 7 lines
$ ./scripts/get_maintainer.pl --file drivers/usb/host/xhci-ring.c Mathias Nyman <[email protected]> (supporter:USB XHCI DRIVER) Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM) [email protected] (open list:USB XHCI DRIVER) [email protected] (open list)Any reason to not include the maintainer of the xhci driver here?
OK, I will include the maintainer in the next patch.
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c +0
-0@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; }
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2868
Quoted 9 lines
drivers/usb/host/xhci-ring.c +9
-0+if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + }
This won't work at all. It doesn't reset the xHC which is the one thing needed to recover from a HCE. This would deadlock immediately.
Many of the above functions shouldn't be called from interrupt context, and if HCE is set we probably even won't get any interrupts.
A reset will set all registers to their initial values, and need to be re-initialized. Nothing is freed or re-allocated, registrs are not re-initialized here.
Please revisit the xhci spec about HCE, and HCRST, and a more detail look at the xhci driver, and test the code before submitting.
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2869
Quoted 1 line
drivers/usb/host/xhci-ring.c +1
-0+Does this fix a real problem for you? Are you sure we will not suddenly start resetting devices that were working properly and sending this error incorrectly? How did you test this?
Quoted 6 lines
Quoted 5 lines
thanks,
greg k-h
.Yes, we want to add a RAS feature to the USB,
What is "RAS"?
Quoted 1 line
Use the HCE event to trigger the reset operation of the USB controller.
Quoted 9 lines
Is that allowed by the XHCI specification?
Quoted 3 lines
By searching for the current xhci driver, the driver did not handle HCE event. In fact, I am not sure if other operations will cause HCE, The HCE event is used to reset the USB controller according to the definition of the event.
What generates that event? Do existing controllers do that today? What causes it?
It's not an event, it's a controller internal error state. It's probably not very useful to check for it in the interrupt handler as the xHC hw ceases all activity when it sets the HCE bit, including sending interrupts.
From the spec:
4.24.1 Internal Errors
The Host Controller Error (HCE) flag is asserted when an internal xHC error is detected that exclusively affects the xHC. When the HCE flag is set to ‘1’ the xHC shall cease all activity. Software response to the assertion of HCE is to reset the xHC (HCRST = ‘1’) and reinitialize it
Quoted 3 lines
Quoted 1 line
I test this reset operation through the Sysfs file, but have not tested all usage scenarios.
What sysfs file?
I'm also interested in this, and to know more about RAS?
Thanks
-Mathias
On 2020/11/19 0:21, Mathias Nyman Wrote:
Quoted 100 lines · Greg KH
Quoted 36 lines · liulongfang
Quoted 35 lines
On 2020/11/18 15:02, Greg KH Wrote:
Quoted 17 lines · Longfang Liu
Quoted 11 lines
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()|----xhci_halt() |----xhci_shutdown() |----xhci_start() |----xhci_run()Quoted 4 lines
Signed-off-by Longfang Liu <[email protected]>--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 7 lines
$ ./scripts/get_maintainer.pl --file drivers/usb/host/xhci-ring.c Mathias Nyman <[email protected]> (supporter:USB XHCI DRIVER) Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM) [email protected] (open list:USB XHCI DRIVER) [email protected] (open list)Any reason to not include the maintainer of the xhci driver here?
OK, I will include the maintainer in the next patch.
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c +0
-0@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; }Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2868
Quoted 9 lines
drivers/usb/host/xhci-ring.c +9
-0+if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + }This won't work at all. It doesn't reset the xHC which is the one thing needed to recover from a HCE. This would deadlock immediately.
Many of the above functions shouldn't be called from interrupt context, and if HCE is set we probably even won't get any interrupts.A reset will set all registers to their initial values, and need to be re-initialized. Nothing is freed or re-allocated, registrs are not re-initialized here.
Please revisit the xhci spec about HCE, and HCRST, and a more detail look at the xhci driver, and test the code before submitting.
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2869
Quoted 1 line
drivers/usb/host/xhci-ring.c +1
-0+Does this fix a real problem for you? Are you sure we will not suddenly start resetting devices that were working properly and sending this error incorrectly? How did you test this?
Quoted 6 lines
Quoted 5 lines
thanks,
greg k-h
.Yes, we want to add a RAS feature to the USB,
What is "RAS"?
Quoted 1 line
Use the HCE event to trigger the reset operation of the USB controller.
Quoted 9 lines
Is that allowed by the XHCI specification?
Quoted 3 lines
By searching for the current xhci driver, the driver did not handle HCE event. In fact, I am not sure if other operations will cause HCE, The HCE event is used to reset the USB controller according to the definition of the event.
What generates that event? Do existing controllers do that today? What causes it?
It's not an event, it's a controller internal error state. It's probably not very useful to check for it in the interrupt handler as the xHC hw ceases all activity when it sets the HCE bit, including sending interrupts.
Quoted 1 line
From the spec:
4.24.1 Internal Errors
The Host Controller Error (HCE) flag is asserted when an internal xHC error is detected that exclusively affects the xHC. When the HCE flag is set to ‘1’ the xHC shall cease all activity. Software response to the assertion of HCE is to reset the xHC (HCRST = ‘1’) and reinitialize itQuoted 2 lines
Quoted 1 line
I test this reset operation through the Sysfs file, but have not tested all usage scenarios.
Quoted 8 lines
Quoted 1 line
What sysfs file?
I'm also interested in this, and to know more about RAS?
Thanks
-Mathias
.
RAS: Reliablity, Availability and Serviceability.
sysfs: a virtual file system based on memory, it's similar as proc. Use DEVICE_ATTR or DRIVER_ATTR to create files to the /sys directory Thanks
Longfang.
Greg KH
maintainerQuoted 103 lines · liulongfang
On 2020/11/19 0:21, Mathias Nyman Wrote:
Quoted 102 lines · Greg KH
Quoted 36 lines · liulongfang
Quoted 35 lines
On 2020/11/18 15:02, Greg KH Wrote:
Quoted 17 lines · Longfang Liu
Quoted 11 lines
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()|----xhci_halt() |----xhci_shutdown() |----xhci_start() |----xhci_run()Quoted 4 lines
Signed-off-by Longfang Liu <[email protected]>--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 7 lines
$ ./scripts/get_maintainer.pl --file drivers/usb/host/xhci-ring.c Mathias Nyman <[email protected]> (supporter:USB XHCI DRIVER) Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM) [email protected] (open list:USB XHCI DRIVER) [email protected] (open list)Any reason to not include the maintainer of the xhci driver here?
OK, I will include the maintainer in the next patch.
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c +0
-0@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; }Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2868
Quoted 9 lines
drivers/usb/host/xhci-ring.c +9
-0+if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + }This won't work at all. It doesn't reset the xHC which is the one thing needed to recover from a HCE. This would deadlock immediately.
Many of the above functions shouldn't be called from interrupt context, and if HCE is set we probably even won't get any interrupts.A reset will set all registers to their initial values, and need to be re-initialized. Nothing is freed or re-allocated, registrs are not re-initialized here.
Please revisit the xhci spec about HCE, and HCRST, and a more detail look at the xhci driver, and test the code before submitting.
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2869
Quoted 1 line
drivers/usb/host/xhci-ring.c +1
-0+Does this fix a real problem for you? Are you sure we will not suddenly start resetting devices that were working properly and sending this error incorrectly? How did you test this?
Quoted 6 lines
Quoted 5 lines
thanks,
greg k-h
.Yes, we want to add a RAS feature to the USB,
What is "RAS"?
Quoted 1 line
Use the HCE event to trigger the reset operation of the USB controller.
Quoted 9 lines
Is that allowed by the XHCI specification?
Quoted 3 lines
By searching for the current xhci driver, the driver did not handle HCE event. In fact, I am not sure if other operations will cause HCE, The HCE event is used to reset the USB controller according to the definition of the event.
What generates that event? Do existing controllers do that today? What causes it?
It's not an event, it's a controller internal error state. It's probably not very useful to check for it in the interrupt handler as the xHC hw ceases all activity when it sets the HCE bit, including sending interrupts.
Quoted 1 line
Quoted 1 line
From the spec:
4.24.1 Internal Errors
The Host Controller Error (HCE) flag is asserted when an internal xHC error is detected that exclusively affects the xHC. When the HCE flag is set to ‘1’ the xHC shall cease all activity. Software response to the assertion of HCE is to reset the xHC (HCRST = ‘1’) and reinitialize itQuoted 3 lines
Quoted 1 line
I test this reset operation through the Sysfs file, but have not tested all usage scenarios.
What sysfs file?
Quoted 7 lines
Quoted 6 lines
I'm also interested in this, and to know more about RAS?
Thanks
-Mathias
.RAS: Reliablity, Availability and Serviceability.
That's a marketing phrase, what specifically are you talking about when it comes to the xhci driver?
Quoted 1 line
sysfs: a virtual file system based on memory, it's similar as proc.
I am very aware of what sysfs is, look at the MAINTAINERS entry for it :)
Quoted 1 line
Use
DEVICE_ATTRorDRIVER_ATTRto create files to the /sys directory
Yes, but what file did you use for this? I don't see one in the kernel that can cause this, do you?
thanks,
greg k-h
On 2020/11/19 14:09, Greg KH Wrote:
Quoted 121 lines · liulongfang
Quoted 103 lines
On 2020/11/19 0:21, Mathias Nyman Wrote:
Quoted 102 lines · Greg KH
Quoted 36 lines · liulongfang
Quoted 35 lines
On 2020/11/18 15:02, Greg KH Wrote:
Quoted 17 lines · Longfang Liu
Quoted 11 lines
The HCE(Host Controller Error) event has been defined in the XHCI driver but has not been used. If we want to use the HCE event to reset the controller, can we implement it in the interrupt function as follows:
xhci_irq()|----xhci_halt() |----xhci_shutdown() |----xhci_start() |----xhci_run()Quoted 4 lines
Signed-off-by Longfang Liu <[email protected]>--- drivers/usb/host/xhci-ring.c | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 7 lines
$ ./scripts/get_maintainer.pl --file drivers/usb/host/xhci-ring.c Mathias Nyman <[email protected]> (supporter:USB XHCI DRIVER) Greg Kroah-Hartman <[email protected]> (supporter:USB SUBSYSTEM) [email protected] (open list:USB XHCI DRIVER) [email protected] (open list)Any reason to not include the maintainer of the xhci driver here?
OK, I will include the maintainer in the next patch.
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c +0
-0@@ -2857,6 +2857,16 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd) goto out; }Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2868
Quoted 9 lines
drivers/usb/host/xhci-ring.c +9
-0+if (status &STS_HCE ) { +xhci_warn (xhci,"WARNING: Host Controller Error\n" ); +xhci_halt (xhci); +xhci_shutdown (hcd); +xhci_start (xhci); +xhci_run (hcd); + ret =IRQ_HANDLED ; + goto out; + }This won't work at all. It doesn't reset the xHC which is the one thing needed to recover from a HCE. This would deadlock immediately.
Many of the above functions shouldn't be called from interrupt context, and if HCE is set we probably even won't get any interrupts.A reset will set all registers to their initial values, and need to be re-initialized. Nothing is freed or re-allocated, registrs are not re-initialized here.
Please revisit the xhci spec about HCE, and HCRST, and a more detail look at the xhci driver, and test the code before submitting.
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
drivers/usb/host/xhci-ring.c irqreturn_t xhci_irq(struct usb_hcd *hcd) · line 2869
Quoted 1 line
drivers/usb/host/xhci-ring.c +1
-0+Does this fix a real problem for you? Are you sure we will not suddenly start resetting devices that were working properly and sending this error incorrectly? How did you test this?
Quoted 6 lines
Quoted 5 lines
thanks,
greg k-h
.Yes, we want to add a RAS feature to the USB,
What is "RAS"?
Quoted 1 line
Use the HCE event to trigger the reset operation of the USB controller.
Quoted 9 lines
Is that allowed by the XHCI specification?
Quoted 3 lines
By searching for the current xhci driver, the driver did not handle HCE event. In fact, I am not sure if other operations will cause HCE, The HCE event is used to reset the USB controller according to the definition of the event.
What generates that event? Do existing controllers do that today? What causes it?
It's not an event, it's a controller internal error state. It's probably not very useful to check for it in the interrupt handler as the xHC hw ceases all activity when it sets the HCE bit, including sending interrupts.
Quoted 1 line
Quoted 1 line
From the spec:
4.24.1 Internal Errors
The Host Controller Error (HCE) flag is asserted when an internal xHC error is detected that exclusively affects the xHC. When the HCE flag is set to ‘1’ the xHC shall cease all activity. Software response to the assertion of HCE is to reset the xHC (HCRST = ‘1’) and reinitialize itQuoted 3 lines
Quoted 1 line
I test this reset operation through the Sysfs file, but have not tested all usage scenarios.
What sysfs file?
Quoted 7 lines
Quoted 6 lines
I'm also interested in this, and to know more about RAS?
Thanks
-Mathias
.RAS: Reliablity, Availability and Serviceability.
That's a marketing phrase, what specifically are you talking about when it comes to the xhci driver?
It means that when the hardware detects HCE, the USB controller could recover.Quoted 1 line
sysfs: a virtual file system based on memory, it's similar as proc.
I am very aware of what sysfs is, look at the
MAINTAINERSentry for it :)Quoted 1 line
Use
DEVICE_ATTRorDRIVER_ATTRto create files to the /sys directory
Quoted 8 lines
Yes, but what file did you use for this? I don't see one in the kernel that can cause this, do you?
thanks,
greg k-h
.
I found that there is debugfs in the USB xhci driver, and the reset test can be realized by adding the debugfs file thanks,
Longfang.