Skip to contentSkip to conversation

drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

PATCH Applied David Gow 2 participants 2 messages Nov 20, 2020 – Nov 22, 2020

Subsystems (2)
lore
Share & tools
lore

David Gow

author
#0 lore raw

PATCH v2 1/1 drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Fixes 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")

---

Changes since v1:
( https://lore.kernel.org/linux-fpga/[email protected]/ )
- Add Fixes tag

 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
Signature · 1 line
2.29.2.454.gaff20da3a2-goog
maintainer Applied
#1 lore raw
Quoted 33 lines · David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Fixes 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")

---

Changes since v1:
( https://lore.kernel.org/linux-fpga/[email protected]/ )
- Add Fixes tag

 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
Signature · 1 line
2.29.2.454.gaff20da3a2-goog

Applied to for-5.10,

I fixed up your commit message (dropped the drivers:)

- Moritz

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um