sched/fair: Fix overutilized update in enqueue_task_fair()
PATCH 1/1 sched/fair: Fix overutilized update in enqueue_task_fair()
[ Upstream commit 8e1ac4299a6e8726de42310d9c1379f188140c71 ]
enqueue_task_fair() attempts to skip the overutilized update for new tasks as their util_avg is not accurate yet. However, the flag we check to do so is overwritten earlier on in the function, which makes the condition pretty much a nop.
Fix this by saving the flag early on.
--- kernel/sched/fair.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/sched/fair.c +2 -1
@@ -5228,6 +5228,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)struct cfs_rq *cfs_rq;struct sched_entity *se = &p->se;int idle_h_nr_running =task_has_idle_policy (p); +int task_new = !(flags &ENQUEUE_WAKEUP );/* * The code below (indirectly) updates schedutil which looks at
@@ -5299,7 +5300,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)* into account, but that is not straightforward to implement, * and the following generally works well enough in practice. */ -if (flags &ENQUEUE_WAKEUP ) +if (!task_new)update_overutilized_status (rq); }
Signature · 1 line
2.29.2.454.gaff20da3a2-goog
Greg KH
maintainerQuoted 8 lines · Quentin Perret
[ Upstream commit
8e1ac4299a6e8726de42310d9c1379f188140c71]
enqueue_task_fair()attempts to skip the overutilized update for new tasks as theirutil_avgis not accurate yet. However, the flag we check to do so is overwritten earlier on in the function, which makes the condition pretty much a nop.Fix this by saving the flag early on.
Now queued up, thanks.
greg k-h