Skip to contentSkip to conversation

misc: altera-stapl: remove trailing semicolon in macro definition

PATCH In review [email protected] 2 participants 3 messages Nov 27, 2020 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: altera-stapl: remove trailing semicolon in macro definition

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/altera-stapl/altera-jtag.c +2 -2
index 27e8e0c9e8cf..0238600107b0 100644
@@ -17,9 +17,9 @@
 #include "altera-jtag.h"
 
 #define	alt_jtag_io(a, b, c)\
-		astate->config->jtag_io(astate->config->dev, a, b, c);
+		astate->config->jtag_io(astate->config->dev, a, b, c)
 
-#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL);
+#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL)
 
 /*
  * This structure shows, for each JTAG state, which state is reached after
Signature · 1 line
2.18.4
maintainer
#1 lore raw
Quoted 14 lines · On Fri, Nov 27, 2020 at 08:54:21AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/altera-stapl/altera-jtag.c +0 -0
index 27e8e0c9e8cf..0238600107b0 100644

drivers/misc/altera-stapl/altera-jtag.c line 22

Quoted 8 lines
drivers/misc/altera-stapl/altera-jtag.c +2 -2
@@ -17,9 +17,9 @@
 #include "altera-jtag.h"
 
 #define	alt_jtag_io(a, b, c)\
-		astate->config->jtag_io(astate->config->dev, a, b, c);
+		astate->config->jtag_io(astate->config->dev, a, b, c)
 
-#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL);
+#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL)

Ick, really? That macro should be removed entirely. Can you redo this as a 2 patch series, the first for the alt_jtag_io() change, and the other to remove all users of alt_malloc()?

thanks,

greg k-h

author
#2 lore raw
Quoted 21 lines · Greg KH
Quoted 20 lines · On Fri, Nov 27, 2020 at 08:54:21AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/altera-stapl/altera-jtag.c +1 -1
index 27e8e0c9e8cf..0238600107b0 100644
@@ -17,9 +17,9 @@
 #include "altera-jtag.h"
 
 #define	alt_jtag_io(a, b, c)\
-		astate->config->jtag_io(astate->config->dev, a, b, c);
+		astate->config->jtag_io(astate->config->dev, a, b, c)
 
Quoted 5 lines

drivers/misc/altera-stapl/altera-jtag.c line 22

Quoted 2 lines
drivers/misc/altera-stapl/altera-jtag.c +1 -1
-#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL);
+#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL)

Ick, really? That macro should be removed entirely. Can you redo this as a 2 patch series, the first for the alt_jtag_io() change, and the other to remove all users of alt_malloc()?

yes.

It may be a bit, I would like to see if there are other similar wrappers.

Tom

Quoted 5 lines

thanks,

greg k-h