Skip to contentSkip to conversation

printk: remove obsolete dead assignment

PATCH In review Lukas Bulwahn 3 participants 4 messages Nov 30, 2020 – Dec 8, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 printk: remove obsolete dead assignment

Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored devkmsg_write() and left over a dead assignment on the variable 'len'.

Hence, make clang-analyzer warns:

kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read

    [clang-analyzer-deadcode.DeadStores]
                          len -= endp - line;
                          ^

Simply remove this obsolete dead assignment here.

---
applies cleanly on current master and next-20201130

Petr, please pick this minor non-urgent clean-up patch.

 kernel/printk/printk.c | 1 -
 1 file changed, 1 deletion(-)
kernel/printk/printk.c +0 -1
index f279d4fbd9dd..6e4e38b7cd91 100644
@@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from)
 			if (LOG_FACILITY(u) != 0)
 				facility = LOG_FACILITY(u);
 			endp++;
-			len -= endp - line;
 			line = endp;
 		}
 	}
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines · Lukas Bulwahn

Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored devkmsg_write() and left over a dead assignment on the variable 'len'.

Hence, make clang-analyzer warns:

kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read

    [clang-analyzer-deadcode.DeadStores]
                          len -= endp - line;
                          ^

Simply remove this obsolete dead assignment here.

---
applies cleanly on current master and next-20201130

Petr, please pick this minor non-urgent clean-up patch.

 kernel/printk/printk.c | 1 -
 1 file changed, 1 deletion(-)
kernel/printk/printk.c +0 -0
index f279d4fbd9dd..6e4e38b7cd91 100644

kernel/printk/printk.c static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) · line 746

Quoted 7 lines
kernel/printk/printk.c +0 -1
@@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from)
 			if (LOG_FACILITY(u) != 0)
 				facility = LOG_FACILITY(u);
 			endp++;
-			len -= endp - line;
 			line = endp;
 		}
 	}

Yup, it was used to write the trailing '\0'. But it is done earlier now. So, it is not longer needed.

Best Regards,
Petr

PS: I'll give it few days just in case anyone else would want to review it. I'll push it then unless anyone complains.

Reviewed-by
#2 lore raw
Quoted 1 line · Petr Mladek

On Mon 2020-11-30 13:49:15, Lukas Bulwahn wrote:

[..]

Quoted 16 lines

kernel/printk/printk.c static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) · line 746

Quoted 12 lines
kernel/printk/printk.c +0 -1
index f279d4fbd9dd..6e4e38b7cd91 100644
@@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from)
 			if (LOG_FACILITY(u) != 0)
 				facility = LOG_FACILITY(u);
 			endp++;
-			len -= endp - line;
 			line = endp;
 		}
 	}

Yup, it was used to write the trailing '\0'. But it is done earlier now. So, it is not longer needed.

Quoted 7 lines

Best Regards,
Petr

PS: I'll give it few days just in case anyone else would want to review it. I'll push it then unless anyone complains.

FWIW, looks good to me

	-ss
maintainer
#3 lore raw
In reply to Lukas Bulwahn
Quoted 5 lines · Lukas Bulwahn

Commit 849f3127bb46 ("switch /dev/kmsg to ->write_iter()") refactored devkmsg_write() and left over a dead assignment on the variable 'len'.

Hence, make clang-analyzer warns:

Quoted 8 lines

kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read

    [clang-analyzer-deadcode.DeadStores]
                          len -= endp - line;
                          ^

Simply remove this obsolete dead assignment here.

The patch is committed in printk/linux.git, branch for-5.11.

Best Regards,
Petr