iio: sx9310: Off by one in sx9310_read_thresh()
Subsystems (2)
PATCH 1/1 iio: sx9310: Off by one in sx9310_read_thresh()
This > should be >= to prevent reading one element beyond the end of the sx9310_pthresh_codes[] array.
Fixes ad2b473e2ba3 ("iio: sx9310: Support setting proximity thresholds")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/iio/proximity/sx9310.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/proximity/sx9310.c +1 -1
@@ -601,7 +601,7 @@ static int sx9310_read_thresh(struct sx9310_data *data,return ret; regval =FIELD_GET (SX9310_REG_PROX_CTRL8_9_PTHRESH_MASK , regval); -if (regval >ARRAY_SIZE (sx9310_pthresh_codes)) +if (regval >=ARRAY_SIZE (sx9310_pthresh_codes))return -EINVAL ; *val = sx9310_pthresh_codes[regval];
Signature · 1 line
2.29.2
Hi,
Quoted 9 lines · Dan Carpenter
This > should be >= to prevent reading one element beyond the end of the sx9310_pthresh_codes[] array.
Fixes ad2b473e2ba3 ("iio: sx9310: Support setting proximity thresholds")Signed-off-by Dan Carpenter <[email protected]>--- drivers/iio/proximity/sx9310.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Douglas Anderson <[email protected]>
Quoting Dan Carpenter (2020-11-30 23:03:28)
Quoted 6 lines
This > should be >= to prevent reading one element beyond the end of the sx9310_pthresh_codes[] array.
Fixes ad2b473e2ba3 ("iio: sx9310: Support setting proximity thresholds")Signed-off-by Dan Carpenter <[email protected]>---
Thanks!
Reviewed-by Stephen Boyd <[email protected]>
Quoted 5 lines · On Tue, 1 Dec 2020 10:03:28 +0300 Dan Carpenter <[email protected]>…
This > should be >= to prevent reading one element beyond the end of the sx9310_pthresh_codes[] array.
Fixes ad2b473e2ba3 ("iio: sx9310: Support setting proximity thresholds")Signed-off-by Dan Carpenter <[email protected]>
Applied to the fixes-togreg branch of iio.git which won't go anywhere now until after rc1 (and is based on the stuff queued up for the merge window)
thanks,
Jonathan
Quoted 17 lines
--- drivers/iio/proximity/sx9310.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/proximity/sx9310.c +1
-1@@ -601,7 +601,7 @@ static int sx9310_read_thresh(struct sx9310_data *data,return ret; regval =FIELD_GET (SX9310_REG_PROX_CTRL8_9_PTHRESH_MASK , regval); -if (regval >ARRAY_SIZE (sx9310_pthresh_codes)) +if (regval >=ARRAY_SIZE (sx9310_pthresh_codes))return -EINVAL ; *val = sx9310_pthresh_codes[regval];