Skip to contentSkip to conversation

vhost_vdpa: return -EFAULT if copy_to_user() fails

PATCH In review Dan Carpenter 3 participants 3 messages Dec 2, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vhost_vdpa: return -EFAULT if copy_to_user() fails

The copy_to_user() function returns the number of bytes remaining to be copied but this should return -EFAULT to the user.

Fixes 1b48dc03e575 ("vhost: vdpa: report iova range")
---
 drivers/vhost/vdpa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vhost/vdpa.c +3 -1
index d6a37b66770b..ef688c8c0e0e 100644
@@ -344,7 +344,9 @@ static long vhost_vdpa_get_iova_range(struct vhost_vdpa *v, u32 __user *argp)
 		.last = v->range.last,
 	};
 
-	return copy_to_user(argp, &range, sizeof(range));
+	if (copy_to_user(argp, &range, sizeof(range)))
+		return -EFAULT;
+	return 0;
 }
 
 static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd,
Signature · 1 line
2.29.2
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Dan Carpenter

The copy_to_user() function returns the number of bytes remaining to be copied but this should return -EFAULT to the user.

Fixes 1b48dc03e575 ("vhost: vdpa: report iova range")
---
  drivers/vhost/vdpa.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vhost/vdpa.c +0 -0
index d6a37b66770b..ef688c8c0e0e 100644

drivers/vhost/vdpa.c static long vhost_vdpa_get_iova_range(struct vhost_vdpa *v, u32 __user *argp) · line 352

Quoted 10 lines
drivers/vhost/vdpa.c +3 -1
@@ -344,7 +344,9 @@ static long vhost_vdpa_get_iova_range(struct vhost_vdpa *v, u32 __user *argp)
  		.last = v->range.last,
  	};
 
-	return copy_to_user(argp, &range, sizeof(range));
+	if (copy_to_user(argp, &range, sizeof(range)))
+		return -EFAULT;
+	return 0;
  }
 
  static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd,

Thanks

Reviewed-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 8 lines · Dan Carpenter

The copy_to_user() function returns the number of bytes remaining to be copied but this should return -EFAULT to the user.

Fixes 1b48dc03e575 ("vhost: vdpa: report iova range")

---
drivers/vhost/vdpa.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 24 lines
drivers/vhost/vdpa.c +3 -1
index d6a37b66770b..ef688c8c0e0e 100644
@@ -344,7 +344,9 @@ static long vhost_vdpa_get_iova_range(struct vhost_vdpa *v, u32 __user *argp)
 		.last = v->range.last,
 	};
 
-	return copy_to_user(argp, &range, sizeof(range));
+	if (copy_to_user(argp, &range, sizeof(range)))
+		return -EFAULT;
+	return 0;
 }
 
 static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd,
Signature · 6 lines
2.29.2

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization