Skip to contentSkip to conversation

Revert "mei: virtio: virtualization frontend driver"

PATCH In review Michael S. Tsirkin 2 participants 2 messages Dec 5, 2020 – Dec 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "mei: virtio: virtualization frontend driver"

This reverts commit d162219c655c8cf8003128a13840d6c1e183fb80. The device uses a VIRTIO device ID out of a not-for-production range. Releasing Linux using an ID out of this range will make it conflict with development setups. An official request to reserve an ID for an MEI device is yet to be submitted to the virtio TC, thus there's no chance it will be reserved and fixed in time before the next release.

Once requested it usually takes 2-3 weeks to land in the spec, which means the device can be supported with the official ID in the next Linux version if contributors act quickly.

---
 drivers/misc/mei/Kconfig     |  10 -
 drivers/misc/mei/Makefile    |   3 -
 drivers/misc/mei/hw-virtio.c | 874 -----------------------------------
 3 files changed, 887 deletions(-)
 delete mode 100644 drivers/misc/mei/hw-virtio.c
drivers/misc/mei/Kconfig +0 -10
index c06581ffa7bd..f5fd5b786607 100644
@@ -46,14 +46,4 @@ config INTEL_MEI_TXE
 	  Supported SoCs:
 	  Intel Bay Trail
 
-config INTEL_MEI_VIRTIO
-	tristate "Intel MEI interface emulation with virtio framework"
-	select INTEL_MEI
-	depends on X86 && PCI && VIRTIO_PCI
-	help
-	  This module implements mei hw emulation over virtio transport.
-	  The module will be called mei_virtio.
-	  Enable this if your virtual machine supports virtual mei
-	  device over virtio.
-
 source "drivers/misc/mei/hdcp/Kconfig"
drivers/misc/mei/Makefile +0 -3
index 52aefaab5c1b..f1c76f7ee804 100644
@@ -22,9 +22,6 @@ obj-$(CONFIG_INTEL_MEI_TXE) += mei-txe.o
 mei-txe-objs := pci-txe.o
 mei-txe-objs += hw-txe.o
 
-obj-$(CONFIG_INTEL_MEI_VIRTIO) += mei-virtio.o
-mei-virtio-objs := hw-virtio.o
-
 mei-$(CONFIG_EVENT_TRACING) += mei-trace.o
 CFLAGS_mei-trace.o = -I$(src)
 
drivers/misc/mei/hw-virtio.c deleted +0 -874

874 lines not on this page · raw message

Signature · 1 line
MST
#1 lore raw
Quoted 8 lines · Michael S. Tsirkin

This reverts commit d162219c655c8cf8003128a13840d6c1e183fb80. The device uses a VIRTIO device ID out of a not-for-production range. Releasing Linux using an ID out of this range will make it conflict with development setups. An official request to reserve an ID for an MEI device is yet to be submitted to the virtio TC, thus there's no chance it will be reserved and fixed in time before the next release.

Quoted 5 lines

Once requested it usually takes 2-3 weeks to land in the spec, which means the device can be supported with the official ID in the next Linux version if contributors act quickly.

Now applied, thanks.

greg k-h