scsi: mpt3sas: Signedness bug in _base_get_diag_triggers()
Subsystems (3)
PATCH 1/1 scsi: mpt3sas: Signedness bug in _base_get_diag_triggers()
The "trigger_flags" variable needs to be signed for the error checking to work.
Fixes 5767aaffbb8b ("scsi: mpt3sas: Add persistent trigger pages support")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +1 -1
@@ -5034,7 +5034,7 @@ _base_check_for_trigger_pages_support(struct MPT3SAS_ADAPTER *ioc)static void _base_get_diag_triggers (struct MPT3SAS_ADAPTER *ioc) { -u16 trigger_flags; +int trigger_flags;/* * Default setting of master trigger.
Signature · 1 line
2.29.2
Martin K. Petersen
AppliedDan,
Quoted 2 lines
The "
trigger_flags" variable needs to be signed for the error checking to work.
Applied to 5.11/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering