media: atomisp: Fix PARENTHESIS_ALIGNMENT
Subsystems (4)
PATCH v2 9/12 media: atomisp: Fix PARENTHESIS_ALIGNMENT
You can sum up the two lines, because the maximum line length of 100 columns is not exceeded.
--- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +1 -2
@@ -37,8 +37,7 @@ static struct spctrl_context_info spctrl_cofig_info[N_SP_ID];static bool spctrl_loaded[N_SP_ID ] = {0 };/* Load firmware */ -int ia_css_spctrl_load_fw (sp_ID_t sp_id, -ia_css_spctrl_cfg *spctrl_cfg) +int ia_css_spctrl_load_fw (sp_ID_t sp_id,ia_css_spctrl_cfg *spctrl_cfg) {ia_css_ptr code_addr = mmgr_NULL;struct ia_css_sp_init_dmem_cfg *init_dmem_cfg;
Signature · 1 line
2.20.1
PATCH v2 10/12 media: atomisp: Fix BLOCK_COMMENT_STYLE
Block comments should align the * on each line
--- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +2 -2
@@ -105,8 +105,8 @@ int ia_css_spctrl_load_fw(sp_ID_t sp_id, ia_css_spctrl_cfg *spctrl_cfg)void sh_css_spctrl_reload_fw (sp_ID_t sp_id) {/* now we program the base address into the icache and -* invalidate the cache. -*/ +* invalidate the cache. +*/ sp_ctrl_store (sp_id,SP_ICACHE_ADDR_REG , (hrt_data )spctrl_cofig_info[sp_id].code_addr);sp_ctrl_setbit (sp_id,SP_ICACHE_INV_REG ,SP_ICACHE_INV_BIT );
Signature · 1 line
2.20.1
PATCH v2 11/12 media: atomisp: Write function decleration in one line
In reply to Philipp GerlesbergerCHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line.
--- .../atomisp/pci/runtime/queue/src/queue.c | 44 +++++-------------- 1 file changed, 11 insertions(+), 33 deletions(-)
drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +11 -33
@@ -22,9 +22,7 @@/***************************************************************************** * Queue Public APIs *****************************************************************************/ -int ia_css_queue_local_init ( -ia_css_queue_t *qhandle, -ia_css_queue_local_t *desc) +int ia_css_queue_local_init (ia_css_queue_t *qhandle,ia_css_queue_local_t *desc) {if (NULL == qhandle ||NULL == desc ||NULL == desc->cb_elems ||NULL == desc->cb_desc) {
@@ -43,9 +41,7 @@ int ia_css_queue_local_init(return 0 ; } -int ia_css_queue_remote_init ( -ia_css_queue_t *qhandle, -ia_css_queue_remote_t *desc) +int ia_css_queue_remote_init (ia_css_queue_t *qhandle,ia_css_queue_remote_t *desc) {if (NULL == qhandle ||NULL == desc) {/* Invalid parameters, return error*/
@@ -69,8 +65,7 @@ int ia_css_queue_remote_init(return 0 ; } -int ia_css_queue_uninit ( -ia_css_queue_t *qhandle) +int ia_css_queue_uninit (ia_css_queue_t *qhandle) {if (!qhandle)return -EINVAL ;
@@ -84,9 +79,7 @@ int ia_css_queue_uninit(return 0 ; } -int ia_css_queue_enqueue ( -ia_css_queue_t *qhandle, -uint32_t item) +int ia_css_queue_enqueue (ia_css_queue_t *qhandle,uint32_t item) {int error =0 ;
@@ -143,9 +136,7 @@ int ia_css_queue_enqueue(return 0 ; } -int ia_css_queue_dequeue ( -ia_css_queue_t *qhandle, -uint32_t *item) +int ia_css_queue_dequeue (ia_css_queue_t *qhandle,uint32_t *item) {int error =0 ;
@@ -200,9 +191,7 @@ int ia_css_queue_dequeue(return 0 ; } -int ia_css_queue_is_full ( -ia_css_queue_t *qhandle, -bool *is_full) +int ia_css_queue_is_full (ia_css_queue_t *qhandle,bool *is_full) {int error =0 ;
@@ -234,9 +223,7 @@ int ia_css_queue_is_full(return -EINVAL ; } -int ia_css_queue_get_free_space ( -ia_css_queue_t *qhandle, -uint32_t *size) +int ia_css_queue_get_free_space (ia_css_queue_t *qhandle,uint32_t *size) {int error =0 ;
@@ -268,9 +255,7 @@ int ia_css_queue_get_free_space(return -EINVAL ; } -int ia_css_queue_get_used_space ( -ia_css_queue_t *qhandle, -uint32_t *size) +int ia_css_queue_get_used_space (ia_css_queue_t *qhandle,uint32_t *size) {int error =0 ;
@@ -302,10 +287,7 @@ int ia_css_queue_get_used_space(return -EINVAL ; } -int ia_css_queue_peek ( -ia_css_queue_t *qhandle, -u32 offset, -uint32_t *element) +int ia_css_queue_peek (ia_css_queue_t *qhandle,u32 offset,uint32_t *element) {u32 num_elems =0 ;int error =0 ;
@@ -354,9 +336,7 @@ int ia_css_queue_peek(return -EINVAL ; } -int ia_css_queue_is_empty ( -ia_css_queue_t *qhandle, -bool *is_empty) +int ia_css_queue_is_empty (ia_css_queue_t *qhandle,bool *is_empty) {int error =0 ;
@@ -388,9 +368,7 @@ int ia_css_queue_is_empty(return -EINVAL ; } -int ia_css_queue_get_size ( -ia_css_queue_t *qhandle, -uint32_t *size) +int ia_css_queue_get_size (ia_css_queue_t *qhandle,uint32_t *size) {int error =0 ;
Signature · 1 line
2.20.1
PATCH v2 12/12 media: atomisp: Fix LOGICAL_CONTINUATIONS
In reply to Philipp GerlesbergerLogical continuations should be on the previous line
--- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +2 -2
@@ -24,8 +24,8 @@*****************************************************************************/ int ia_css_queue_local_init (ia_css_queue_t *qhandle,ia_css_queue_local_t *desc) { -if (NULL == qhandle ||NULL == desc - ||NULL == desc->cb_elems ||NULL == desc->cb_desc) { +if (NULL == qhandle ||NULL == desc || +NULL == desc->cb_elems ||NULL == desc->cb_desc) {/* Invalid parameters, return error*/ return -EINVAL ; }
Signature · 1 line
2.20.1
From: Philipp Gerlesberger
Quoted 4 lines
Sent: 14 December 2020 11:04
You can sum up the two lines, because the maximum line length of 100 columns is not exceeded.
IIRC the 80 column limit is preferred.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
[email protected]
maintainerQuoted 7 lines · David Laight
From: Philipp Gerlesberger
Quoted 4 lines
Sent: 14 December 2020 11:04
You can sum up the two lines, because the maximum line length of 100 columns is not exceeded.
IIRC the 80 column limit is preferred.
Not anymore, checkpatch has changed.