Skip to contentSkip to conversation

mke2fs.8: Improve valid block size documentation

PATCH In review Jan Kara 3 participants 5 messages Oct 13, 2020 – Dec 16, 2020

lore
Share & tools
lore

Jan Kara

author
#0 lore raw

PATCH 1/1 mke2fs.8: Improve valid block size documentation

Explain which valid block sizes mke2fs supports in more detail.

---
 misc/mke2fs.8.in | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
misc/mke2fs.8.in +5 -4
index e6bfc6d6fd2d..0814d216f3a4 100644
@@ -207,10 +207,11 @@ manual page for more details.
 .SH OPTIONS
 .TP
 .BI \-b " block-size"
-Specify the size of blocks in bytes.  Valid block-size values are 1024,
-2048 and 4096 bytes per block.  If omitted,
-block-size is heuristically determined by the filesystem size and
-the expected usage of the filesystem (see the
+Specify the size of blocks in bytes.  Valid block-size values are powers of two
+from 1024 up to 65536 (however note that the kernel is able to mount only
+filesystems with block-size smaller or equal to the system page size - 4k on
+x86 systems). If omitted, block-size is heuristically determined by the
+filesystem size and the expected usage of the filesystem (see the
 .B \-T
 option).  If
 .I block-size
Signature · 1 line
2.16.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Jan Kara

Explain which valid block sizes mke2fs supports in more detail.

Should this mention that the default block size is 4096 bytes for most filesystems?

It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this is definitely an improvement already.

Quoted 21 lines

---
misc/mke2fs.8.in | 9 +++++----

1 file changed, 5 insertions(+), 4 deletions(-)
misc/mke2fs.8.in +0 -0
index e6bfc6d6fd2d..0814d216f3a4 100644
@@ -207,10 +207,11 @@ manual page for more details.

.SH OPTIONS
.TP
.BI \-b " block-size"

misc/mke2fs.8.in +5 -4
-Specify the size of blocks in bytes.  Valid block-size values are 1024,
-2048 and 4096 bytes per block.  If omitted,
-block-size is heuristically determined by the filesystem size and
-the expected usage of the filesystem (see the
+Specify the size of blocks in bytes.  Valid block-size values are powers of two
+from 1024 up to 65536 (however note that the kernel is able to mount only
+filesystems with block-size smaller or equal to the system page size - 4k on
+x86 systems). If omitted, block-size is heuristically determined by the
+filesystem size and the expected usage of the filesystem (see the
Quoted 6 lines

.B \-T
option). If
.I block-size
--
2.16.4

Cheers, Andreas

author
#2 lore raw
Quoted 8 lines · Andreas Dilger
Quoted 4 lines · Jan Kara

Explain which valid block sizes mke2fs supports in more detail.

Should this mention that the default block size is 4096 bytes for most filesystems?

That would be to the "heuristic" parts. Yes, I agree, I'll add that.

Quoted 2 lines

It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this is definitely an improvement already.

Yeah, I can add that to the "page size" part. But with these archs there's a catch that page size can be configured in the kernel config so the formulation will need to be a bit more careful. But I'll add something.

Quoted 1 line

Thanks! I'll send v2.

Honza

Quoted 36 lines
Quoted 22 lines

---
misc/mke2fs.8.in | 9 +++++----

1 file changed, 5 insertions(+), 4 deletions(-)
misc/mke2fs.8.in +0 -0
index e6bfc6d6fd2d..0814d216f3a4 100644
@@ -207,10 +207,11 @@ manual page for more details.

.SH OPTIONS
.TP
.BI \-b " block-size"

misc/mke2fs.8.in +5 -4
-Specify the size of blocks in bytes.  Valid block-size values are 1024,
-2048 and 4096 bytes per block.  If omitted,
-block-size is heuristically determined by the filesystem size and
-the expected usage of the filesystem (see the
+Specify the size of blocks in bytes.  Valid block-size values are powers of two
+from 1024 up to 65536 (however note that the kernel is able to mount only
+filesystems with block-size smaller or equal to the system page size - 4k on
+x86 systems). If omitted, block-size is heuristically determined by the
+filesystem size and the expected usage of the filesystem (see the
Quoted 6 lines

.B \-T
option). If
.I block-size
--
2.16.4

Cheers, Andreas

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#3 lore raw
Quoted 15 lines · Jan Kara
Quoted 8 lines · Andreas Dilger
Quoted 4 lines · Jan Kara

Explain which valid block sizes mke2fs supports in more detail.

Should this mention that the default block size is 4096 bytes for most filesystems?

That would be to the "heuristic" parts. Yes, I agree, I'll add that.

Quoted 2 lines

It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this is definitely an improvement already.

Quoted 7 lines

Yeah, I can add that to the "page size" part. But with these archs there's a catch that page size can be configured in the kernel config so the formulation will need to be a bit more careful. But I'll add something.

Quoted 1 line

Thanks! I'll send v2.

Did you ever send a v2 of this patch? I can't seem to find it in my archives or in patchwork.

Thanks!!

- Ted

author
#4 lore raw
Quoted 20 lines · Theodore Y. Ts'o
Quoted 19 lines · Jan Kara
Quoted 8 lines · Andreas Dilger
Quoted 4 lines · Jan Kara

Explain which valid block sizes mke2fs supports in more detail.

Should this mention that the default block size is 4096 bytes for most filesystems?

That would be to the "heuristic" parts. Yes, I agree, I'll add that.

Quoted 2 lines

It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this is definitely an improvement already.

Yeah, I can add that to the "page size" part. But with these archs there's a catch that page size can be configured in the kernel config so the formulation will need to be a bit more careful. But I'll add something.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Thanks! I'll send v2.

Did you ever send a v2 of this patch? I can't seem to find it in my archives or in patchwork.

I think I did but probably it got lost somewhere. Anyway, I've resent it now. Thanks for noticing!

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR