drm/bridge: thc63lvd1024: Fix regulator_get_optional() misuse
Subsystems (3)
PATCH 1/1 drm/bridge: thc63lvd1024: Fix regulator_get_optional() misuse
The thc63lvd1024 driver requests a supply using regulator_get_optional() but both the name of the supply and the usage pattern suggest that it is being used for the main power for the device and is not at all optional for the device for function, there is no handling at all for absent supplies. Such regulators should use the vanilla regulator_get() interface, it will ensure that even if a supply is not described in the system integration one will be provided in software.
--- drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/thc63lvd1024.c +1 -1
@@ -200,7 +200,7 @@ static int thc63_probe(struct platform_device *pdev) thc63->dev = &pdev->dev;platform_set_drvdata (pdev, thc63); - thc63->vcc =devm_regulator_get_optional (thc63->dev,"vcc" ); + thc63->vcc =devm_regulator_get (thc63->dev,"vcc" );if (IS_ERR (thc63->vcc)) {if (PTR_ERR (thc63->vcc) == -EPROBE_DEFER )return -EPROBE_DEFER ;
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Mark,
Thank you for the patch.
Quoted 9 lines · Mark Brown
The thc63lvd1024 driver requests a supply using
regulator_get_optional()but both the name of the supply and the usage pattern suggest that it is being used for the main power for the device and is not at all optional for the device for function, there is no handling at all for absent supplies. Such regulators should use the vanillaregulator_get()interface, it will ensure that even if a supply is not described in the system integration one will be provided in software.Signed-off-by Mark Brown <[email protected]>
and queued in my tree for v5.12.
Quoted 17 lines
--- drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/thc63lvd1024.c +1
-1@@ -200,7 +200,7 @@ static int thc63_probe(struct platform_device *pdev) thc63->dev = &pdev->dev;platform_set_drvdata (pdev, thc63); - thc63->vcc =devm_regulator_get_optional (thc63->dev,"vcc" ); + thc63->vcc =devm_regulator_get (thc63->dev,"vcc" );if (IS_ERR (thc63->vcc)) {if (PTR_ERR (thc63->vcc) == -EPROBE_DEFER )return -EPROBE_DEFER ;
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel