perf/x86/amd/core: Use sysfs_emit() in show() callback function
Subsystems (2)
PATCH 1/1 perf/x86/amd/core: Use sysfs_emit() in show() callback function
Using sprintf/snprintf functions are error prone and suggested to be replaced by scnprintf/vscnrptintf as outlined in this [1] LWN article.
A more recent recommendation is to use sysfs_emit() or sysfs_emit_at() as per Documentation/filesystems/sysfs.rst in show() callback function when formatting values to be returned to user-space. These helper functions are PAGE_SIZE aware and wrap a safer call to vscnprintf().
[1] https://lwn.net/Articles/69419/
Issue identified using the coccinelle device_attr_show.cocci script.
--- arch/x86/events/amd/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/events/amd/core.c +1 -1
@@ -1272,7 +1272,7 @@ static ssize_t branches_show(struct device *cdev,struct device_attribute *attr, char *buf) { - return snprintf(buf, PAGE_SIZE, "%d\n", x86_pmu.lbr_nr); + return sysfs_emit(buf, "%d\n", x86_pmu.lbr_nr); }static DEVICE_ATTR_RO (branches);
Signature · 1 line
2.34.1
Peter Zijlstra
maintainerQuoted 11 lines · Deepak R Varma
Using sprintf/snprintf functions are error prone and suggested to be replaced by scnprintf/vscnrptintf as outlined in this [1] LWN article.
A more recent recommendation is to use
sysfs_emit()orsysfs_emit_at()as perDocumentation/filesystems/sysfs.rstinshow()callback function when formatting values to be returned to user-space. These helper functions arePAGE_SIZEaware and wrap a safer call tovscnprintf().[1] https://lwn.net/Articles/69419/
Issue identified using the coccinelle
device_attr_show.cocciscript.
This Changelog fails to inform me of what the actual problem is and why the proposed solution is better.
As such I cannot form an opinion on the patch and must decline.
(Also, I'm not going to chase down random links on the interweb, Changelogs should be self contained)