drm: rcar-du: Fix a NULL vs IS_ERR() bug
Subsystems (4)
PATCH 1/1 drm: rcar-du: Fix a NULL vs IS_ERR() bug
The drmm_encoder_alloc() function returns error pointers. It never returns NULL. Fix the check accordingly.
Fixes 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/rcar-du/rcar_du_encoder.c +2 -2
@@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base, &rcar_du_encoder_funcs,DRM_MODE_ENCODER_NONE ,NULL ); -if (!renc) -return -ENOMEM ; +if (IS_ERR (renc)) +return PTR_ERR (renc); renc->output = output;
Signature · 1 line
2.39.1
Quoting Dan Carpenter (2023-02-27 10:06:59)
Quoted 2 lines
The
drmm_encoder_alloc()function returns error pointers. It never returns NULL. Fix the check accordingly.
Yes, indeed. Thanks.
Reviewed-by Kieran Bingham <[email protected]>
Quoted 25 lines
Fixes 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/rcar-du/rcar_du_encoder.c +2
-2@@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base, &rcar_du_encoder_funcs,DRM_MODE_ENCODER_NONE ,NULL ); -if (!renc) -return -ENOMEM ; +if (IS_ERR (renc)) +return PTR_ERR (renc); renc->output = output;Signature · 1 line
2.39.1
Hi Dan,
Thank you for the patch.
Quoted 5 lines · Dan Carpenter
The
drmm_encoder_alloc()function returns error pointers. It never returns NULL. Fix the check accordingly.Fixes 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Quoted 19 lines
--- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/rcar-du/rcar_du_encoder.c +2
-2@@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base, &rcar_du_encoder_funcs,DRM_MODE_ENCODER_NONE ,NULL ); -if (!renc) -return -ENOMEM ; +if (IS_ERR (renc)) +return PTR_ERR (renc); renc->output = output;
Signature · 3 lines
Regards, Laurent Pinchart