Skip to contentSkip to conversation

platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

PATCH Applied Colin Ian King 5 participants 6 messages Feb 7, 2023 – Feb 8, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

There is a spelling mistake in a dev_warn message, make it lower case and fix the spelling.

---
 drivers/platform/chrome/cros_ec_typec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/chrome/cros_ec_typec.c +1 -1
index 71f5d7d8e055..a673c3342470 100644
@@ -1020,7 +1020,7 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
 		cros_typec_handle_vdm_attention(typec, port_num);
 		ret = cros_typec_send_clear_event(typec, port_num, PD_STATUS_EVENT_VDM_ATTENTION);
 		if (ret < 0)
-			dev_warn(typec->dev, "Failed VDM Attenetion event clear, port: %d\n",
+			dev_warn(typec->dev, "Failed VDM attention event clear, port: %d\n",
 				 port_num);
 	}
 }
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Colin Ian King

There is a spelling mistake in a dev_warn message, make it lower case and fix the spelling.

Quoted 20 lines
---
 drivers/platform/chrome/cros_ec_typec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/chrome/cros_ec_typec.c +1 -2
index 71f5d7d8e055..a673c3342470 100644
@@ -1020,7 +1020,7 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
                cros_typec_handle_vdm_attention(typec, port_num);
                ret = cros_typec_send_clear_event(typec, port_num, PD_STATUS_EVENT_VDM_ATTENTION);
                if (ret < 0)
-                       dev_warn(typec->dev, "Failed VDM Attenetion event clear, port: %d\n",
+                       dev_warn(typec->dev, "Failed VDM attention event clear, port: %d\n",
                                 port_num);
        }
 }
--

2.30.2

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Colin Ian King

Hi Prashant,

Quoted 4 lines · Colin Ian King

There is a spelling mistake in a dev_warn message, make it lower case and fix the spelling.

It's about time to cut for the coming merge window. I guess you would like this simple patch to be included as a fixup for f54c013e7eef ("platform/chrome: cros_typec_vdm: Add Attention support"). Please apply the patch if it makes sense.

One minor suggestion for the commit title:
"platform/chrome: cros_ec_typec: Fix spelling mistake" looks more clear to me.

With that:

#3 lore raw
Quoted 10 lines · Tzung-Bi Shih

Hi Prashant,

Quoted 4 lines · Colin Ian King

There is a spelling mistake in a dev_warn message, make it lower case and fix the spelling.

It's about time to cut for the coming merge window.

I thought there would be an rc8...

Quoted 4 lines

I guess you would
like this simple patch to be included as a fixup for f54c013e7eef ("platform/chrome: cros_typec_vdm: Add Attention support"). Please apply the patch if it makes sense.

Sure. I'll make the modification you suggest and apply this tomorrow. Thanks for signal boosting it.

Quoted 7 lines

One minor suggestion for the commit title:
"platform/chrome: cros_ec_typec: Fix spelling mistake" looks more clear to me.

With that:

#4 lore raw
In reply to Colin Ian King
This patch was applied to chrome-platform/linux.git (for-kernelci) by Prashant Malani <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci) by Prashant Malani <[email protected]>:

Quoted 7 lines · On Tue, 7 Feb 2023 09:14:43 +0000 you wrote:

There is a spelling mistake in a dev_warn message, make it lower case and fix the spelling.

---
 drivers/platform/chrome/cros_ec_typec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

    https://git.kernel.org/chrome-platform/c/b0d8a67715da

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#5 lore raw
In reply to Colin Ian King
This patch was applied to chrome-platform/linux.git (for-next) by Prashant Malani <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-next) by Prashant Malani <[email protected]>:

Quoted 7 lines · On Tue, 7 Feb 2023 09:14:43 +0000 you wrote:

There is a spelling mistake in a dev_warn message, make it lower case and fix the spelling.

---
 drivers/platform/chrome/cros_ec_typec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

    https://git.kernel.org/chrome-platform/c/b0d8a67715da

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html