Skip to contentSkip to conversation

staging: rts5208: Move open parenthesis to next line

PATCH In review Emily Peri 2 participants 3 messages Oct 19, 2022 Staging

lore
Share & tools
lore

Emily Peri

author
#0 lore raw

PATCH 1/1 staging: rts5208: Move open parenthesis to next line

Changed breakpoint for long line in sd.c to comply with checkpatch style warning that lines should not end with '('.

---
 drivers/staging/rts5208/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rts5208/sd.c +2 -2
index d1fafd530c80..99e951be2802 100644
@@ -4501,8 +4501,8 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 			sd_card->sd_lock_notify = 1;
 			if (sd_lock_state &&
 			    (sd_card->sd_lock_status & SD_LOCK_1BIT_MODE)) {
-				sd_card->sd_lock_status |= (
-					SD_UNLOCK_POW_ON | SD_SDR_RST);
+				sd_card->sd_lock_status |=
+					(SD_UNLOCK_POW_ON | SD_SDR_RST);
 				if (CHK_SD(sd_card)) {
 					retval = reset_sd(chip);
 					if (retval != STATUS_SUCCESS) {
Signature · 1 line
2.34.1
#1 lore raw
Quoted 2 lines · Emily Peri

Changed breakpoint for long line in sd.c to comply with checkpatch style warning that lines should not end with '('.

I think that someone else already did this? Or at least something very similar. Check the list archives.

Also, the patch should also go to all of the maintainers of the code. The first patch tutorial should show you how to use get_maintainers.pl to get the list of recipients.

julia

Quoted 26 lines
---
 drivers/staging/rts5208/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rts5208/sd.c +2 -3
index d1fafd530c80..99e951be2802 100644
@@ -4501,8 +4501,8 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 			sd_card->sd_lock_notify = 1;
 			if (sd_lock_state &&
 			    (sd_card->sd_lock_status & SD_LOCK_1BIT_MODE)) {
-				sd_card->sd_lock_status |= (
-					SD_UNLOCK_POW_ON | SD_SDR_RST);
+				sd_card->sd_lock_status |=
+					(SD_UNLOCK_POW_ON | SD_SDR_RST);
 				if (CHK_SD(sd_card)) {
 					retval = reset_sd(chip);
 					if (retval != STATUS_SUCCESS) {
--

2.34.1

author
#2 lore raw
Quoted 9 lines · Julia Lawall
Quoted 2 lines · Emily Peri

Changed breakpoint for long line in sd.c to comply with checkpatch style warning that lines should not end with '('.

I think that someone else already did this? Or at least something very similar. Check the list archives.

Yep, you're right, its the patch "merge unnecessary split lines". Back to square one...

Quoted 3 lines

Also, the patch should also go to all of the maintainers of the code. The first patch tutorial should show you how to use get_maintainers.pl to get the list of recipients.

Okay, got it!

Quoted 29 lines

julia

Quoted 26 lines
---
 drivers/staging/rts5208/sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rts5208/sd.c +2 -3
index d1fafd530c80..99e951be2802 100644
@@ -4501,8 +4501,8 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 			sd_card->sd_lock_notify = 1;
 			if (sd_lock_state &&
 			    (sd_card->sd_lock_status & SD_LOCK_1BIT_MODE)) {
-				sd_card->sd_lock_status |= (
-					SD_UNLOCK_POW_ON | SD_SDR_RST);
+				sd_card->sd_lock_status |=
+					(SD_UNLOCK_POW_ON | SD_SDR_RST);
 				if (CHK_SD(sd_card)) {
 					retval = reset_sd(chip);
 					if (retval != STATUS_SUCCESS) {
--

2.34.1