Skip to contentSkip to conversation

pinctrl: Clean up and add missed headers

PATCH In review Andy Shevchenko 22 participants 93 messages Oct 10, 2022 – Oct 18, 2022 Page 2 of 2

Subsystems (43)
lore
Share & tools
lore
#88 lore raw
In reply to Andy Shevchenko
Quoted 17 lines · Andy Shevchenko
Quoted 16 lines · Florian Fainelli
Quoted 10 lines · Andy Shevchenko

Currently the header inclusion inside the pinctrl headers seems more arbitrary than logical. This series is basically out of two parts:
- add missed headers to the pin control drivers / users
- clean up the headers of pin control subsystem

The idea is to have this series to be pulled after -rc1 by the GPIO and pin control subsystems, so all new drivers will utilize cleaned up headers of the pin control.

Please, review and comment.

Did you really need to split this on a per-driver basis as opposed to just a treewide drivers/pinctrl, drivers/media and drivers/gpiolib patch set?

Quoted 6 lines
Quoted 2 lines

36 patches seems needlessly high when 4 patches could have achieve the same outcome.

I can combine them if maintainers ask for that, nevertheless for Intel pin control and GPIO drivers, which I care more about, I would like to leave as separate changes (easy to see in history what was done).

I can now tell why I don't like to combine. While doing a revert (it's not related to GPIO nor to pin control), it appears that I reverted extra bits as merge conflict resolution. This is per se is not an issue, but when I tried to find and reapply that missed piece I can't, because the patch is combined and Git simply ignores to have
git cherry-pick _something in the past_ done.

But again, up to maintainers.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#89 lore raw
In reply to Andy Shevchenko
Quoted 8 lines · Andy Shevchenko

Currently the header inclusion inside the pinctrl headers seems more arbitrary than logical. This series is basically out of two parts:
- add missed headers to the pin control drivers / users
- clean up the headers of pin control subsystem

The idea is to have this series to be pulled after -rc1 by the GPIO and pin control subsystems, so all new drivers will utilize cleaned up headers of the pin control.

Aha I see you want to send a pull request so I backed out the applied patches from the series for now.

Yours,
Linus Walleij

#90 lore raw
Quoted 8 lines · Linus Walleij
Quoted 5 lines · Andy Shevchenko

Currently the header inclusion inside the pinctrl headers seems more arbitrary than logical. This series is basically out of two parts:
- add missed headers to the pin control drivers / users
- clean up the headers of pin control subsystem

Quoted 6 lines
Quoted 3 lines

The idea is to have this series to be pulled after -rc1 by the GPIO and pin control subsystems, so all new drivers will utilize cleaned up headers of the pin control.

Aha I see you want to send a pull request so I backed out the applied patches from the series for now.

Can I consider all that you answered to as Rb tag?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Acked-by
#91 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 8 lines · Linus Walleij
Quoted 5 lines · Andy Shevchenko

Currently the header inclusion inside the pinctrl headers seems more arbitrary than logical. This series is basically out of two parts:
- add missed headers to the pin control drivers / users
- clean up the headers of pin control subsystem

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

The idea is to have this series to be pulled after -rc1 by the GPIO and pin control subsystems, so all new drivers will utilize cleaned up headers of the pin control.

Aha I see you want to send a pull request so I backed out the applied patches from the series for now.

Can I consider all that you answered to as Rb tag?

I haven't reviewed in detail but I fully trust you to do the right thing and fix any fallout so will happily pull this.

Yours,
Linus Walleij

#92 lore raw
Quoted 15 lines · Linus Walleij
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Linus Walleij
Quoted 8 lines · Andy Shevchenko

Currently the header inclusion inside the pinctrl headers seems more arbitrary than logical. This series is basically out of two parts:
- add missed headers to the pin control drivers / users
- clean up the headers of pin control subsystem

The idea is to have this series to be pulled after -rc1 by the GPIO and pin control subsystems, so all new drivers will utilize cleaned up headers of the pin control.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Aha I see you want to send a pull request so I backed out the applied patches from the series for now.

Can I consider all that you answered to as Rb tag?

Thank you!

Quoted 2 lines

I haven't reviewed in detail but I fully trust you to do the right thing and fix any fallout so will happily pull this.

The plan is to push this to Linux Next for a couple of days and then I'll send PR to you and Bart.

Signature · 2 lines
With Best Regards,
Andy Shevchenko