Skip to contentSkip to conversation

perf tools: Fix man page build wrt perf-arm-coresight.txt

PATCH Applied Adrian Hunter 3 participants 3 messages Oct 17, 2022

Subsystems (2)
lore
Share & tools
lore

Adrian Hunter

author reviewer
#0 lore raw

PATCH 1/1 perf tools: Fix man page build wrt perf-arm-coresight.txt

perf build assumes documentation files starting with "perf-" are man pages but perf-arm-coresight.txt is not a man page:

asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1 make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile.perf:895: man] Error 2

Fix by renaming it.

Fixes dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")
---
 .../Documentation/{perf-arm-coresight.txt => arm-coresight.txt}   | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
tools/perf/Documentation/arm-coresight.txt renamed from tools/perf/Documentation/perf-arm-coresight.txt +0 -0
similarity index 100%
rename from tools/perf/Documentation/perf-arm-coresight.txt
rename to tools/perf/Documentation/arm-coresight.txt
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Adrian Hunter

perf build assumes documentation files starting with "perf-" are man pages but perf-arm-coresight.txt is not a man page:

asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1 make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile.perf:895: man] Error 2

Quoted 6 lines

Fix by renaming it.

Fixes dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")

Thanks for fixing, Adrian. The change LGTM:

Quoted 12 lines
---
 .../Documentation/{perf-arm-coresight.txt => arm-coresight.txt}   | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
tools/perf/Documentation/arm-coresight.txt renamed from tools/perf/Documentation/perf-arm-coresight.txt +0 -0
similarity index 100%
rename from tools/perf/Documentation/perf-arm-coresight.txt
rename to tools/perf/Documentation/arm-coresight.txt
Signature · 1 line
2.25.1
maintainer Applied
#2 lore raw

Em Mon, Oct 17, 2022 at 05:57:43PM +0800, Leo Yan escreveu:

Quoted 13 lines · Adrian Hunter
Quoted 12 lines

perf build assumes documentation files starting with "perf-" are man pages but perf-arm-coresight.txt is not a man page:

asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1 make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile.perf:895: man] Error 2

Fix by renaming it.

Quoted 8 lines
Quoted 4 lines
Fixes dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")

Thanks for fixing, Adrian. The change LGTM:

Thanks, applied.

- Arnaldo

Quoted 12 lines
Quoted 12 lines
---
 .../Documentation/{perf-arm-coresight.txt => arm-coresight.txt}   | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
tools/perf/Documentation/arm-coresight.txt renamed from tools/perf/Documentation/perf-arm-coresight.txt +0 -0
similarity index 100%
rename from tools/perf/Documentation/perf-arm-coresight.txt
rename to tools/perf/Documentation/arm-coresight.txt
Signature · 1 line
2.25.1
Signature · 1 line
- Arnaldo