Skip to contentSkip to conversation

f2fs: fix compile warning

PATCH Applied Chao Yu 2 participants 4 messages Oct 6, 2022 – Oct 10, 2022 F2FS file system

lore
Share & tools
lore

Chao Yu

author maintainer
#0 lore raw

PATCH 1/1 f2fs: fix compile warning

fs/f2fs/super.c:3886:6: warning: no previous prototype for 'f2fs_record_stop_reason' [-Wmissing-prototypes]

---
 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/super.c +1 -1
index fad333881ea2..2908d41ed462 100644
@@ -3884,7 +3884,7 @@ static void save_stop_reason(struct f2fs_sb_info *sbi, unsigned char reason)
 	spin_unlock(&sbi->error_lock);
 }
 
-void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
+static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
 {
 	struct f2fs_super_block *raw_super = F2FS_RAW_SUPER(sbi);
 	int err;
Signature · 1 line
2.36.1
maintainer Applied
#1 lore raw

Merged into the original patch.

Quoted 22 lines · Chao Yu

fs/f2fs/super.c:3886:6: warning: no previous prototype for 'f2fs_record_stop_reason' [-Wmissing-prototypes]

---
 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/super.c +1 -1
index fad333881ea2..2908d41ed462 100644
@@ -3884,7 +3884,7 @@ static void save_stop_reason(struct f2fs_sb_info *sbi, unsigned char reason)
 	spin_unlock(&sbi->error_lock);
 }
 
-void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
+static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
 {
 	struct f2fs_super_block *raw_super = F2FS_RAW_SUPER(sbi);
 	int err;
Signature · 1 line
2.36.1
author maintainer
#2 lore raw
Quoted 1 line · Jaegeuk Kim

Merged into the original patch.

Thanks, so it looks it's not too later to update commit id of original patch since it's close to the end of merge window.

Thanks,

Quoted 24 lines · Chao Yu
Quoted 22 lines

fs/f2fs/super.c:3886:6: warning: no previous prototype for 'f2fs_record_stop_reason' [-Wmissing-prototypes]

---
  fs/f2fs/super.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/super.c +1 -1
index fad333881ea2..2908d41ed462 100644
@@ -3884,7 +3884,7 @@ static void save_stop_reason(struct f2fs_sb_info *sbi, unsigned char reason)
  	spin_unlock(&sbi->error_lock);
  }
 
-void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
+static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
  {
  	struct f2fs_super_block *raw_super = F2FS_RAW_SUPER(sbi);
  	int err;
Signature · 1 line
2.36.1
maintainer
#3 lore raw
Quoted 5 lines · Chao Yu
Quoted 1 line · Jaegeuk Kim

Merged into the original patch.

Thanks, so it looks it's not too later to update commit id of original patch since it's close to the end of merge window.

I put this in the next pull request.

Quoted 12 lines

Thanks,

Quoted 9 lines · Chao Yu
Quoted 7 lines

fs/f2fs/super.c:3886:6: warning: no previous prototype for 'f2fs_record_stop_reason' [-Wmissing-prototypes]

---
  fs/f2fs/super.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
fs/f2fs/super.c +0 -0
index fad333881ea2..2908d41ed462 100644
@@ -3884,7 +3884,7 @@ static void save_stop_reason(struct f2fs_sb_info *sbi, unsigned char reason)
  	spin_unlock(&sbi->error_lock);
Quoted 8 lines
Quoted 8 lines
fs/f2fs/super.c +1 -1
  }
-void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
+static void f2fs_record_stop_reason(struct f2fs_sb_info *sbi)
  {
  	struct f2fs_super_block *raw_super = F2FS_RAW_SUPER(sbi);
  	int err;
Signature · 1 line
2.36.1

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel