HID: roccat: Convert snprintf() to sysfs_emit()
Subsystems (2)
PATCH 2/3 HID: roccat: Convert snprintf() to sysfs_emit()
Coccinnelle reports a warning
Warning: Use scnprintf or sprintf
Following the advice on kernel documentation
https://www.kernel.org/doc/html/latest/filesystems/sysfs.html
For show(device *...) functions we should only use sysfs_emit() or sysfs_emit_at() especially when formatting the value to be returned to user space.
Convert snprintf() to sysfs_emit()
Signed-off-by Jules Irenge <[email protected]>
--- drivers/hid/hid-roccat-kovaplus.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/hid/hid-roccat-kovaplus.c +5 -5
@@ -274,7 +274,7 @@ static ssize_t kovaplus_sysfs_show_actual_profile(struct device *dev, {struct kovaplus_device *kovaplus =hid_get_drvdata (dev_get_drvdata (dev->parent->parent)); -return snprintf (buf,PAGE_SIZE ,"%d\n" , kovaplus->actual_profile); +return sysfs_emit (buf,"%d\n" , kovaplus->actual_profile); } static ssize_t kovaplus_sysfs_set_actual_profile(struct device *dev,
@@ -327,7 +327,7 @@ static ssize_t kovaplus_sysfs_show_actual_cpi(struct device *dev, {struct kovaplus_device *kovaplus =hid_get_drvdata (dev_get_drvdata (dev->parent->parent)); -return snprintf (buf,PAGE_SIZE ,"%d\n" , kovaplus->actual_cpi); +return sysfs_emit (buf,"%d\n" , kovaplus->actual_cpi); } static DEVICE_ATTR(actual_cpi, 0440, kovaplus_sysfs_show_actual_cpi, NULL);
@@ -336,7 +336,7 @@ static ssize_t kovaplus_sysfs_show_actual_sensitivity_x(struct device *dev, {struct kovaplus_device *kovaplus =hid_get_drvdata (dev_get_drvdata (dev->parent->parent)); -return snprintf (buf,PAGE_SIZE ,"%d\n" , kovaplus->actual_x_sensitivity); +return sysfs_emit (buf,"%d\n" , kovaplus->actual_x_sensitivity); } static DEVICE_ATTR(actual_sensitivity_x, 0440, kovaplus_sysfs_show_actual_sensitivity_x, NULL);
@@ -346,7 +346,7 @@ static ssize_t kovaplus_sysfs_show_actual_sensitivity_y(struct device *dev, {struct kovaplus_device *kovaplus =hid_get_drvdata (dev_get_drvdata (dev->parent->parent)); -return snprintf (buf,PAGE_SIZE ,"%d\n" , kovaplus->actual_y_sensitivity); +return sysfs_emit (buf,"%d\n" , kovaplus->actual_y_sensitivity); } static DEVICE_ATTR(actual_sensitivity_y, 0440, kovaplus_sysfs_show_actual_sensitivity_y, NULL);
@@ -367,7 +367,7 @@ static ssize_t kovaplus_sysfs_show_firmware_version(struct device *dev, &info, KOVAPLUS_SIZE_INFO);mutex_unlock (&kovaplus->kovaplus_lock); -return snprintf (buf,PAGE_SIZE ,"%d\n" , info.firmware_version); +return sysfs_emit (buf,"%d\n" , info.firmware_version); } static DEVICE_ATTR(firmware_version, 0440, kovaplus_sysfs_show_firmware_version, NULL);
Signature · 1 line
2.37.3