Skip to contentSkip to conversation

ARM: dts: omap3-n900: fix LCD reset line polarity

PATCH In review Dmitry Torokhov 4 participants 15 messages Oct 4, 2022 – Oct 13, 2022 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 ARM: dts: omap3-n900: fix LCD reset line polarity

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

---
 arch/arm/boot/dts/omap3-n900.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-n900.dts +1 -1
index dd7971556449..c2e5bde19452 100644
@@ -1038,7 +1038,7 @@ lcd: acx565akm@2 {
 		pinctrl-0 = <&acx565akm_pins>;
 
 		label = "lcd";
-		reset-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* 90 */
+		reset-gpios = <&gpio3 26 GPIO_ACTIVE_LOW>; /* 90 */
 
 		port {
 			lcd_in: endpoint {
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
#1 lore raw

PATCH 2/4 ARM: dts: omap4-sdp: fix LCD reset line polarity

The LCD driver (panel-dsi-cm), when performing reset, starts with line set high, then drives it low, holds it there for a moment, and releases it back to high. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

---
 arch/arm/boot/dts/omap4-sdp.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap4-sdp.dts +2 -2
index 9e976140f34a..77e99b77a0c5 100644
@@ -669,7 +669,7 @@ lcd0: panel@0 {
 		reg = <0>;
 		label = "lcd0";
 
-		reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;	/* 102 */
+		reset-gpios = <&gpio4 6 GPIO_ACTIVE_LOW>;	/* 102 */
 
 		port {
 			lcd0_in: endpoint {
@@ -695,7 +695,7 @@ lcd1: panel@0 {
 		reg = <0>;
 		label = "lcd1";
 
-		reset-gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>;	/* 104 */
+		reset-gpios = <&gpio4 8 GPIO_ACTIVE_LOW>;	/* 104 */
 
 		port {
 			lcd1_in: endpoint {
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
#2 lore raw

PATCH 3/4 ARM: dts: omap3-n950: fix LCD reset line polarity

In reply to Dmitry Torokhov

The LCD driver (panel-dsi-cm), when performing reset, starts with line set high, then drives it low, holds it there for a moment, and releases it back to high. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

---
 arch/arm/boot/dts/omap3-n950.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-n950.dts +1 -1
index b2f480022ff6..fa133612bcc2 100644
@@ -235,7 +235,7 @@ lcd0: panel@0 {
 		vpnl-supply = <&vmmc2>;
 		vddi-supply = <&vio>;
 
-		reset-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;	/* 87 */
+		reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>;	/* 87 */
 		te-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;	/* 62 */
 
 		width-mm = <49>; /* 48.960 mm */
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
#3 lore raw

PATCH 4/4 ARM: dts: motorola-mapphone: fix LCD reset line polarity

In reply to Dmitry Torokhov

The LCD driver (panel-dsi-cm), when performing reset, starts with line set high, then drives it low, holds it there for a moment, and releases it back to high. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

---
 arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/motorola-mapphone-common.dtsi +1 -1
index c7a1f3ffc48c..beffa1cf08b2 100644
@@ -212,7 +212,7 @@ lcd0: panel@0 {
 		reg = <0>;
 		label = "lcd0";
 		vddi-supply = <&lcd_regulator>;
-		reset-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;	/* gpio101 */
+		reset-gpios = <&gpio4 5 GPIO_ACTIVE_LOW>;	/* gpio101 */
 
 		backlight = <&backlight>;
 
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
#4 lore raw
In reply to Dmitry Torokhov

Hi,

Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Regards,

Tony

#5 lore raw

Hi,

Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

Quoted 7 lines

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

So this just breaks things.

-- Sebastian

#6 lore raw

Hi Sebastian,

Quoted 15 lines · Sebastian Reichel

Hi,

Quoted 12 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

Quoted 8 lines
Quoted 3 lines

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

I was looking at

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

which are not using gpiod. Should they be retired?

Quoted 2 lines

So this just breaks things.

I missed the drivers in drivers/gpu/... and I see that they essentially abuse gpiod API as gpiod_set_value() operates on logical level (active/inactive) and not absolute (high/low). They should either use the gpiod_*_raw() variants, or they should be adjusted to do the proper thing together with the accompanying DTS change.

What are your preferences?

Thanks.

Signature · 1 line
Dmitry
#7 lore raw
Quoted 24 lines · Dmitry Torokhov

Hi Sebastian,

Quoted 21 lines · Sebastian Reichel

Hi,

Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

Quoted 7 lines

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

Quoted 7 lines
Quoted 2 lines

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

I was looking at

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

Ah OK that explains :)

Quoted 1 line

which are not using gpiod. Should they be retired?

Yes we should just get rid of them with omapdrm working just fine.

Quoted 9 lines
Quoted 1 line

So this just breaks things.

I missed the drivers in drivers/gpu/... and I see that they essentially abuse gpiod API as gpiod_set_value() operates on logical level (active/inactive) and not absolute (high/low). They should either use the gpiod_*_raw() variants, or they should be adjusted to do the proper thing together with the accompanying DTS change.

What are your preferences?

Seems like high/low at the connected device end is what we should use, right? Otherwise things will misbehave if the panel is connected to some other SoC possibly.

Regards,

Tony

#8 lore raw
Quoted 30 lines · Tony Lindgren
Quoted 29 lines · Dmitry Torokhov

Hi Sebastian,

Quoted 15 lines · Sebastian Reichel

Hi,

Quoted 12 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

Quoted 8 lines
Quoted 3 lines

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

I was looking at

Quoted 8 lines
Quoted 2 lines

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

Ah OK that explains :)

Quoted 1 line

which are not using gpiod. Should they be retired?

Yes we should just get rid of them with omapdrm working just fine.

Will you be submitting such patches? I'd like to get rid of of_get_named_gpio() and friends if I can...

Quoted 9 lines
Quoted 9 lines
Quoted 2 lines

So this just breaks things.

I missed the drivers in drivers/gpu/... and I see that they essentially abuse gpiod API as gpiod_set_value() operates on logical level (active/inactive) and not absolute (high/low). They should either use the gpiod_*_raw() variants, or they should be adjusted to do the proper thing together with the accompanying DTS change.

Quoted 5 lines
Quoted 1 line

What are your preferences?

Seems like high/low at the connected device end is what we should use, right? Otherwise things will misbehave if the panel is connected to some other SoC possibly.

It is exactly because of this case the driver should use active/inactive and follow polarity described in DTS. If the driver does:

	gpiod_set_value_cansleep(d->reset, 1);

then if DTS is saying that the reset line is active low, under the wraps the line will be driven to "0", but if DTS is saying that the line is active high, then the very same call will drive the line to "1".

This allows accommodating different designs without having to change the driver code.

Signature · 1 line
Dmitry
#9 lore raw
Quoted 34 lines · Dmitry Torokhov
Quoted 33 lines · Tony Lindgren
Quoted 31 lines · Dmitry Torokhov

Hi Sebastian,

Quoted 15 lines · Sebastian Reichel

Hi,

Quoted 12 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

Quoted 8 lines
Quoted 3 lines

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

I was looking at

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

Quoted 8 lines
Quoted 5 lines

Ah OK that explains :)

Quoted 1 line

which are not using gpiod. Should they be retired?

Yes we should just get rid of them with omapdrm working just fine.

Will you be submitting such patches? I'd like to get rid of of_get_named_gpio() and friends if I can...

Adding Tomi to Cc, my guess is he already has such patches and knows better which ones can go :)

Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line

So this just breaks things.

I missed the drivers in drivers/gpu/... and I see that they essentially abuse gpiod API as gpiod_set_value() operates on logical level (active/inactive) and not absolute (high/low). They should either use the gpiod_*_raw() variants, or they should be adjusted to do the proper thing together with the accompanying DTS change.

Quoted 5 lines
Quoted 1 line

What are your preferences?

Seems like high/low at the connected device end is what we should use, right? Otherwise things will misbehave if the panel is connected to some other SoC possibly.

It is exactly because of this case the driver should use active/inactive and follow polarity described in DTS. If the driver does:

Quoted 8 lines
	gpiod_set_value_cansleep(d->reset, 1);

then if DTS is saying that the reset line is active low, under the wraps the line will be driven to "0", but if DTS is saying that the line is active high, then the very same call will drive the line to "1".

This allows accommodating different designs without having to change the driver code.

OK

Thanks,

Tony

#10 lore raw

Hi,

Quoted 39 lines · Tony Lindgren
Quoted 38 lines · Dmitry Torokhov
Quoted 37 lines · Tony Lindgren
Quoted 24 lines · Dmitry Torokhov

Hi Sebastian,

Quoted 21 lines · Sebastian Reichel

Hi,

Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

Quoted 7 lines

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

Quoted 7 lines
Quoted 2 lines

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

I was looking at

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

Ah OK that explains :)

Quoted 1 line

which are not using gpiod. Should they be retired?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Yes we should just get rid of them with omapdrm working just fine.

Will you be submitting such patches? I'd like to get rid of of_get_named_gpio() and friends if I can...

Adding Tomi to Cc, my guess is he already has such patches and knows better which ones can go :)

To be honest, I haven't really even had a glance towards fbdev for a long time.

There is one thing that omapdrm doesn't support, which is VRFB rotation. I cannot say if the users of those above-mentioned panels require VRFB.

Quoted 17 lines
Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line

So this just breaks things.

I missed the drivers in drivers/gpu/... and I see that they essentially abuse gpiod API as gpiod_set_value() operates on logical level (active/inactive) and not absolute (high/low). They should either use the gpiod_*_raw() variants, or they should be adjusted to do the proper thing together with the accompanying DTS change.

Quoted 5 lines
Quoted 1 line

What are your preferences?

Seems like high/low at the connected device end is what we should use, right? Otherwise things will misbehave if the panel is connected to some other SoC possibly.

It is exactly because of this case the driver should use active/inactive and follow polarity described in DTS. If the driver does:

Quoted 8 lines
Quoted 8 lines
	gpiod_set_value_cansleep(d->reset, 1);

then if DTS is saying that the reset line is active low, under the wraps the line will be driven to "0", but if DTS is saying that the line is active high, then the very same call will drive the line to "1".

This allows accommodating different designs without having to change the driver code.

Isn't breaking an old dts file quite a bad thing? Why not just add a comment to the .dts and to the driver about the situation. I don't quite see that the fixing the dts (And, if done properly, adding a boot time fixup for old dtbs) and changing the drivers is worth the hassle.

Unless we see new users for these drivers, which would require the new users to write broken dts files.

Tomi

#11 lore raw
Quoted 82 lines · Tomi Valkeinen

Hi,

Quoted 39 lines · Tony Lindgren
Quoted 38 lines · Dmitry Torokhov
Quoted 37 lines · Tony Lindgren
Quoted 24 lines · Dmitry Torokhov

Hi Sebastian,

Quoted 21 lines · Sebastian Reichel

Hi,

Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

Quoted 7 lines

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

Quoted 7 lines
Quoted 2 lines

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

I was looking at

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

Ah OK that explains :)

Quoted 1 line

which are not using gpiod. Should they be retired?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Yes we should just get rid of them with omapdrm working just fine.

Will you be submitting such patches? I'd like to get rid of of_get_named_gpio() and friends if I can...

Adding Tomi to Cc, my guess is he already has such patches and knows better which ones can go :)

To be honest, I haven't really even had a glance towards fbdev for a long time.

There is one thing that omapdrm doesn't support, which is VRFB rotation. I cannot say if the users of those above-mentioned panels require VRFB.

Quoted 17 lines
Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line

So this just breaks things.

I missed the drivers in drivers/gpu/... and I see that they essentially abuse gpiod API as gpiod_set_value() operates on logical level (active/inactive) and not absolute (high/low). They should either use the gpiod_*_raw() variants, or they should be adjusted to do the proper thing together with the accompanying DTS change.

Quoted 5 lines
Quoted 1 line

What are your preferences?

Seems like high/low at the connected device end is what we should use, right? Otherwise things will misbehave if the panel is connected to some other SoC possibly.

It is exactly because of this case the driver should use active/inactive and follow polarity described in DTS. If the driver does:

Quoted 8 lines
Quoted 8 lines
	gpiod_set_value_cansleep(d->reset, 1);

then if DTS is saying that the reset line is active low, under the wraps the line will be driven to "0", but if DTS is saying that the line is active high, then the very same call will drive the line to "1".

This allows accommodating different designs without having to change the driver code.

Quoted 7 lines

Isn't breaking an old dts file quite a bad thing? Why not just add a comment to the .dts and to the driver about the situation. I don't quite see that the fixing the dts (And, if done properly, adding a boot time fixup for old dtbs) and changing the drivers is worth the hassle.

Unless we see new users for these drivers, which would require the new users to write broken dts files.

Or maybe there are devices with fixed DTSes and fixed up kernels but the fixes have not been contributed upstream. I don't know...

My personal opinion is that we pay too much attention to DTS compatibility in cases when it is not totally clear if there are devices that use DTSes that are not bundled with the kernel and also have a chance to have their kernel updated (and be lucky enough for the upstream kernel to work on such device without extensive work).

Anyway, my goal is to stop exposing of_get_named_gpio() and its derivatives, so please let me know your preference. Should I:

- mirror in omapfb drivers what gpu drivers do and use inverted polarity
- use gpiod_set_value_raw() and essentially ignore polarity described in DTS
- continue pushing polarity fixes throughout
- something else?

Thanks!

Signature · 1 line
Dmitry
#12 lore raw
Quoted 100 lines · Dmitry Torokhov
Quoted 82 lines · Tomi Valkeinen

Hi,

Quoted 39 lines · Tony Lindgren
Quoted 38 lines · Dmitry Torokhov
Quoted 37 lines · Tony Lindgren
Quoted 24 lines · Dmitry Torokhov

Hi Sebastian,

Quoted 21 lines · Sebastian Reichel

Hi,

Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Dmitry Torokhov

The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS.

Quoted 7 lines

We should ensure these patches get merged together with the driver change to avoid breaking LCD for booting. Probably no need to have the driver quirk handling for inverted polartity in this case.

It's probably easiest to have an immutable branch for the driver changes I can base the dts changes on. Or I can ack the dts changes if they get merged with the driver.

Both drivers are already using gpiod API:

Quoted 7 lines
Quoted 2 lines

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

I was looking at

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

Ah OK that explains :)

Quoted 1 line

which are not using gpiod. Should they be retired?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Yes we should just get rid of them with omapdrm working just fine.

Will you be submitting such patches? I'd like to get rid of of_get_named_gpio() and friends if I can...

Adding Tomi to Cc, my guess is he already has such patches and knows better which ones can go :)

To be honest, I haven't really even had a glance towards fbdev for a long time.

There is one thing that omapdrm doesn't support, which is VRFB rotation. I cannot say if the users of those above-mentioned panels require VRFB.

Quoted 17 lines
Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line

So this just breaks things.

I missed the drivers in drivers/gpu/... and I see that they essentially abuse gpiod API as gpiod_set_value() operates on logical level (active/inactive) and not absolute (high/low). They should either use the gpiod_*_raw() variants, or they should be adjusted to do the proper thing together with the accompanying DTS change.

Quoted 5 lines
Quoted 1 line

What are your preferences?

Seems like high/low at the connected device end is what we should use, right? Otherwise things will misbehave if the panel is connected to some other SoC possibly.

It is exactly because of this case the driver should use active/inactive and follow polarity described in DTS. If the driver does:

Quoted 8 lines
Quoted 8 lines
	gpiod_set_value_cansleep(d->reset, 1);

then if DTS is saying that the reset line is active low, under the wraps the line will be driven to "0", but if DTS is saying that the line is active high, then the very same call will drive the line to "1".

This allows accommodating different designs without having to change the driver code.

Quoted 7 lines

Isn't breaking an old dts file quite a bad thing? Why not just add a comment to the .dts and to the driver about the situation. I don't quite see that the fixing the dts (And, if done properly, adding a boot time fixup for old dtbs) and changing the drivers is worth the hassle.

Unless we see new users for these drivers, which would require the new users to write broken dts files.

Or maybe there are devices with fixed DTSes and fixed up kernels but the fixes have not been contributed upstream. I don't know...

My personal opinion is that we pay too much attention to DTS compatibility in cases when it is not totally clear if there are devices that use DTSes that are not bundled with the kernel and also have a chance to have their kernel updated (and be lucky enough for the upstream kernel to work on such device without extensive work).

Quoted 5 lines

Anyway, my goal is to stop exposing of_get_named_gpio() and its derivatives, so please let me know your preference. Should I:

- mirror in omapfb drivers what gpu drivers do and use inverted polarity

I would just go with the above for the time being. It should be an easy change, and as these omapfb and drm panel drivers are kind of copies of each other, I think it makes sense to use the same code in both.

That said, I personally don't mind fixing the dts files and the drivers, and even dropping the omapfb panel drivers. However, as I don't know if someone needs the omapfb drivers or has to use an old dtb, I don't want to step on that possible mine field. If someone else wants to go there (without my involvement), fine for me =).

Tomi

#13 lore raw

Hi,

Quoted 3 lines · Tomi Valkeinen

I would just go with the above for the time being. It should be an easy change, and as these omapfb and drm panel drivers are kind of copies of each other, I think it makes sense to use the same code in both.

Maybe if a fix is needed, sure let's fix things first, then drop the unused panel drivers.

We already have drivers/gpu/drm/panel driver for both of these two omapfb panels:

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

The compatible strings used translate to these dts files:

arch/arm/boot/dts/motorola-mapphone-common.dtsi
arch/arm/boot/dts/omap3-n900.dts
arch/arm/boot/dts/omap3-n950.dts
arch/arm/boot/dts/omap4-sdp.dts

These devices work with omapdrm and there should not be any need to stick with the omapfb driver. We can just drop the omapfb panel drivers for panel-sony-acx565akm.c and panel-dsi-cm.c. Let's put the limited effort where there is activity instead :)

The vrfb rotation work has been discussed on the lists, so seems like we will eventually have that for omapdrm. Meanwhile, software rotation is being used for postmarketos and leste with omapdrm AFAIK.

Quoted 5 lines

That said, I personally don't mind fixing the dts files and the drivers, and even dropping the omapfb panel drivers. However, as I don't know if someone needs the omapfb drivers or has to use an old dtb, I don't want to step on that possible mine field. If someone else wants to go there (without my involvement), fine for me =).

I belive the only valid use case for omap2 omapfb is the n8x0 rfbi driver that has no omapdrm driver.

Regards,

Tony

#14 lore raw

Hi,

Quoted 23 lines · Tony Lindgren

Hi,

Quoted 3 lines · Tomi Valkeinen

I would just go with the above for the time being. It should be an easy change, and as these omapfb and drm panel drivers are kind of copies of each other, I think it makes sense to use the same code in both.

Maybe if a fix is needed, sure let's fix things first, then drop the unused panel drivers.

We already have drivers/gpu/drm/panel driver for both of these two omapfb panels:

drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c

The compatible strings used translate to these dts files:

arch/arm/boot/dts/motorola-mapphone-common.dtsi
arch/arm/boot/dts/omap3-n900.dts
arch/arm/boot/dts/omap3-n950.dts
arch/arm/boot/dts/omap4-sdp.dts

Quoted 4 lines

These devices work with omapdrm and there should not be any need to stick with the omapfb driver. We can just drop the omapfb panel drivers for panel-sony-acx565akm.c and panel-dsi-cm.c. Let's put the limited effort where there is activity instead :)

FWIW

for removal of those two omapfb panel drivers.

Quoted 5 lines

The vrfb rotation work has been discussed on the lists, so seems like we will eventually have that for omapdrm. Meanwhile, software rotation is being used for postmarketos and leste with omapdrm AFAIK.

Quoted 8 lines
Quoted 5 lines

That said, I personally don't mind fixing the dts files and the drivers, and even dropping the omapfb panel drivers. However, as I don't know if someone needs the omapfb drivers or has to use an old dtb, I don't want to step on that possible mine field. If someone else wants to go there (without my involvement), fine for me =).

I belive the only valid use case for omap2 omapfb is the n8x0 rfbi driver that has no omapdrm driver.

Is that upstream? omapfb (and omapdrm) both have this:

	/*
	 * HACK
	 * We don't have a working driver for rfbi, so skip it here always.
	 * Otherwise dss will never get probed successfully, as it will wait
	 * for rfbi to get probed.
	 */
	if (strstr(dev_name(dev), "rfbi"))
		return 0;

I've seen a few old drivers being removed by marking them as BROKEN (and updating Kconfig help text to explain the situation). Then the code is dropped 1-2 cycles later assuming nobody complained.

-- Sebastian