[4.15] libxl/Arm: correct xc_shadow_control() invocation to fix build
PATCH v2 1/1 [4.15] libxl/Arm: correct xc_shadow_control() invocation to fix build
The backport didn't adapt to the earlier function prototype taking more (unused here) arguments.
---
Also applicable to 4.14 and 4.13.
---
v2: Correct oversights.
tools/libs/light/libxl_arm.c +1 -1
@@ -132,7 +132,7 @@ int libxl__arch_domain_create(libxl__gc *gc, uint32_t domid) {libxl_ctx *ctx =libxl__gc_owner (gc); -unsigned int shadow_mb =DIV_ROUNDUP (d_config->b_info.shadow_memkb,1024 ); +unsigned long shadow_mb =DIV_ROUNDUP (d_config->b_info.shadow_memkb,1024 ); int r = xc_shadow_control(ctx->xch, domid, XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
- &shadow_mb, 0);
+ NULL, 0, &shadow_mb, 0, NULL);
if (r) {
LOGED(ERROR, domid,
- "Failed to set %u MiB shadow allocation", shadow_mb);
+ "Failed to set %lu MiB shadow allocation", shadow_mb);
return ERROR_FAIL;
}Hi Jan,
Quoted 11 lines
-----Original Message-----
From: Jan Beulich <[email protected]>
Subject: [PATCH v2][4.15] libxl/Arm: correctxc_shadow_control()invocation to fix buildThe backport didn't adapt to the earlier function prototype taking more (unused here) arguments.
Fixes c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_opfor Arm")
Signed-off-by Jan Beulich <[email protected]>
Kind regards,
Henry
Anthony PERARD
Acked-byQuoted 7 lines · Henry Wang
Hi Jan,
Quoted 5 lines
-----Original Message-----
From: Jan Beulich <[email protected]>
Subject: [PATCH v2][4.15] libxl/Arm: correctxc_shadow_control()invocation to fix build
Quoted 8 lines
Quoted 6 lines
The backport didn't adapt to the earlier function prototype taking more (unused here) arguments.
Fixes c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_opfor Arm")
Signed-off-by Jan Beulich <[email protected]>Reviewed-by Henry Wang <[email protected]>
Thanks,
Signature · 1 line
Anthony PERARD