lib: Add checking of needs_root
Hi,
If we neeed to run the test as a non-root user, the non-root user would belong to the root group.
Shall we add a checking of needs_root and needs_rootgroup?
Regards,
Gongyi
Quoted 58 lines
Quoted 6 lines
Quoted 5 lines
-----Original Message-----
From: ltp <[email protected]> On Behalf Of Petr VorelQuoted 6 lines
Quoted 6 lines
Hi all,
The subject "lib: Add checking of
needs_root" is a bit misleading as it does not mention at all that it's for the loop device.Quoted 1 line
We need to check
needs_rootis set whentst_test->needs_deviceor
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
tst_test->mount_deviceis set since access the/dev/*need a privilege.FYI we had some discussion about it, quoting Cyril [1]:
Quoted 7 lines
Quoted 7 lines
Well technically you can be added into whatever group is set to
/dev/loop-controle.g. disk group and then you can create devices without a need to be a root.So the most correct solution would be checking if we can access
/dev/loop-controlif tst_test.needs_device is set and if not we would implyneeds_root. However this would need to be rethinked properlyso
Quoted 6 lines
Quoted 5 lines
that we do not end up creating something complex and not really required.
There is also possibility to add custom device via $LTP_DEV. That might allow to add permissions which allow to test without root.
Quoted 6 lines
Quoted 2 lines
I'll write to automated-testing ML (and maybe to LKML ML) to see if people prefers to test without non-root.
I took a quick look at this, and don't like the change.
I didn't investigate all the affected tests, and what device exactly is being
protected.
Quoted 7 lines
But the overall sense of the change takes makes the authorization checking for tests less granular.
Fuego often runs tests as 'root', but it is also fairly common in Fuego to have a dedicated testing user account on a device under test, that has permissions for things like mounting, access to device nodes, etc. This change would cause tests to break for that account.
Hi Tim,
thanks a lot for confirming that people are using non-root users for testing. I'm not sure if we ever implement complex checks, but at least we should not merge this patchset.
Kind regards,
PetrQuoted 2 lines
That's my 2 cents.
-- Tim
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 5 lines
Hi,
If we neeed to run the test as a non-root user, the non-root user would belong to the root group.
Shall we add a checking of
needs_rootandneeds_rootgroup?
How many of these tests we have? I wonder if it's worth to add this.
Kind regards,
Petr
Quoted 61 lines
Regards,
GongyiQuoted 56 lines
Quoted 10 lines
Quoted 10 lines
-----Original Message-----
From: ltp <[email protected]> On Behalf Of Petr VorelHi all,
The subject "lib: Add checking of
needs_root" is a bit misleading as it does not mention at all that it's for the loop device.Quoted 1 line
We need to check
needs_rootis set whentst_test->needs_deviceor
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
tst_test->mount_deviceis set since access the/dev/*need a privilege.FYI we had some discussion about it, quoting Cyril [1]:
Quoted 7 lines
Quoted 7 lines
Well technically you can be added into whatever group is set to
/dev/loop-controle.g. disk group and then you can create devices without a need to be a root.So the most correct solution would be checking if we can access
/dev/loop-controlif tst_test.needs_device is set and if not we would implyneeds_root. However this would need to be rethinked properlyso
Quoted 6 lines
Quoted 5 lines
that we do not end up creating something complex and not really required.
There is also possibility to add custom device via $LTP_DEV. That might allow to add permissions which allow to test without root.
Quoted 6 lines
Quoted 2 lines
I'll write to automated-testing ML (and maybe to LKML ML) to see if people prefers to test without non-root.
I took a quick look at this, and don't like the change.
I didn't investigate all the affected tests, and what device exactly is being
protected.
Quoted 7 lines
But the overall sense of the change takes makes the authorization checking for tests less granular.
Fuego often runs tests as 'root', but it is also fairly common in Fuego to have a dedicated testing user account on a device under test, that has permissions for things like mounting, access to device nodes, etc. This change would cause tests to break for that account.
Hi Tim,
thanks a lot for confirming that people are using non-root users for testing. I'm not sure if we ever implement complex checks, but at least we should not merge this patchset.
Kind regards,
PetrQuoted 2 lines
That's my 2 cents.
-- Tim
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp