Skip to contentSkip to conversation

Add support for Renesas RZ/Five SoC

RFC PATCH Superseded Prabhakar 5 participants 16 messages Oct 28, 2022 – Nov 8, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Prabhakar

author
#0 lore raw

cover Add support for Renesas RZ/Five SoC

From: Lad Prabhakar <[email protected]>

Hi All,

This patch series adds initial support to RZ/Five SoC (which is equipped with AX45MP AndesCore). Platform supports DT based probing.

Linux support is currently being upstreamed the latest patchset can be found at [0].(DT bindings can be seen here)

[0] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20220920184904.90495-1-prabhakar.mahadev-lad.rj at bp.renesas.com/

- PLIC binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml#L57
- PLMT and PLICSW are not used by any driver in kernel hence DT bindings for it
and is used in a similar manner as compared Andes AE350 [1]
[1] https://github.com/andestech/linux/commits/v6.0.y_ae350-ax45mp/Documentation/devicetree/bindings
- SCIF binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/serial/renesas,scif.yaml#L79

Below are the logs for U-Boot (2022.10) and OpenSBI:
--------------------------------------------------
U-Boot SPL 2022.10-00192-g0cf0a0919b-dirty (Oct 28 2022 - 01:09:54 +0100) Trying to boot from NOR

OpenSBI v1.1-87-gc46891e
____ _____ ____ _____

  / __ \                  / ____|  _ \_   _|
 | |  | |_ __   ___ _ __ | (___ | |_) || |
 | |  | | '_ \ / _ \ '_ \ \___ \|  _ < | |
 | |__| | |_) |  __/ | | |____) | |_) || |_
  \____/| .__/ \___|_| |_|_____/|____/_____|
        | |
        |_|

Platform Name : smarc-rzfZ/Five
Platform Features : medeleg
Platform HART Count : 1
Platform IPI Device : andes_plicsw
Platform Timer Device : andes_plmt @ 12000000Hz
Platform Console Device : renesas_scif
Platform HSM Device : ---
Platform PMU Device : ---
Platform Reboot Device : ---
Platform Shutdown Device : ---
Firmware Base : 0x44000000
Firmware Size : 152 KB
Runtime SBI Version : 1.0

Domain0 Name : root
Domain0 Boot HART : 0
Domain0 HARTs : 0*
Domain0 Region00 : 0x00000000110c0000-0x00000000110fffff (I,R)
Domain0 Region01 : 0x0000000011180000-0x00000000111bffff (I,R)
Domain0 Region02 : 0x0000000044000000-0x000000004403ffff ()
Domain0 Region03 : 0x0000000011100000-0x000000001117ffff (I,R)
Domain0 Region04 : 0x0000000013000000-0x00000000133fffff (I)
Domain0 Region05 : 0x0000000000000000-0xffffffffffffffff (R,W,X)
Domain0 Next Address : 0x0000000050000000
Domain0 Next Arg1 : 0x00000000500be568
Domain0 Next Mode : S-mode
Domain0 SysReset : yes

Boot HART ID : 0
Boot HART Domain : root
Boot HART Priv Version : v1.11
Boot HART Base ISA : rv64imafdcnx
Boot HART ISA Extensions : none
Boot HART PMP Count : 16
Boot HART PMP Granularity : 8
Boot HART PMP Address Bits: 36
Boot HART MHPM Count : 4
Boot HART MIDELEG : 0x0000000000000222
Boot HART MEDELEG : 0x000000000000b109

U-Boot 2022.10-00192-g0cf0a0919b-dirty (Oct 28 2022 - 01:09:54 +0100)

CPU:   rv64imafdc
Model: smarc-rzf
DRAM:  896 MiB
SW_ET0_EN: OFFCore:  30 devices, 18 uclasses, devicetree: separate
MMC:   sd at 11c00000: 0, sd at 11c10000: 1
Loading Environment from MMC... OK
In:    serial at 1004b800
Out:   serial at 1004b800
Err:   serial at 1004b800
Net:   eth0: ethernet@11c30000
Hit any key to stop autoboot:  0

=>
--------------------------------------------------

Cheers,
Prabhakar

Lad Prabhakar (7):
lib: utils: serial: Add Renesas SCIF driver
lib: utils: serial: Add FDT driver for Renesas SCIF
platform: andes/ae350: Split header platform.h header file
lib: utils/irqchip: Add compatible string for Andestech NCEPLIC100
platform: Add Renesas RZ/Five initial support
scripts: Add Renesas RZ/Five to platform list in the binary archive
script
docs: platform: Add documentation for Renesas RZ/Five SoC

 docs/platform/platform.md                  |   4 +
 docs/platform/renesas-rzfive.md            | 139 ++++++++++++++++++
 include/sbi_utils/fdt/fdt_helper.h         |   3 +
 include/sbi_utils/serial/renesas-scif.h    |  11 ++
 lib/utils/fdt/fdt_helper.c                 |  23 +++
 lib/utils/irqchip/fdt_irqchip_plic.c       |   3 +-
 lib/utils/serial/Kconfig                   |   9 ++
 lib/utils/serial/fdt_serial_renesas_scif.c |  31 ++++
 lib/utils/serial/objects.mk                |   4 +
 lib/utils/serial/renesas_scif.c            | 140 ++++++++++++++++++
 platform/andes/ae350/common-platform.h     |  94 ++++++++++++
 platform/andes/ae350/platform.h            |  82 +----------
 platform/renesas/rzfive/Kconfig            |  32 ++++
 platform/renesas/rzfive/configs/defconfig  |   0
 platform/renesas/rzfive/objects.mk         |  18 +++
 platform/renesas/rzfive/platform.c         | 161 +++++++++++++++++++++
 platform/renesas/rzfive/platform.h         |  24 +++
 scripts/create-binary-archive.sh           |   1 +
 18 files changed, 698 insertions(+), 81 deletions(-)
 create mode 100644 docs/platform/renesas-rzfive.md
 create mode 100644 include/sbi_utils/serial/renesas-scif.h
 create mode 100644 lib/utils/serial/fdt_serial_renesas_scif.c
 create mode 100644 lib/utils/serial/renesas_scif.c
 create mode 100644 platform/andes/ae350/common-platform.h
 create mode 100644 platform/renesas/rzfive/Kconfig
 create mode 100644 platform/renesas/rzfive/configs/defconfig
 create mode 100644 platform/renesas/rzfive/objects.mk
 create mode 100644 platform/renesas/rzfive/platform.c
 create mode 100644 platform/renesas/rzfive/platform.h
Signature · 1 line
2.17.1
author
#1 lore raw

RFC PATCH 1/7 lib: utils: serial: Add Renesas SCIF driver

From: Lad Prabhakar <[email protected]>

Add Renesas SCIF driver.

Based on a patch in the BSP by Takeki Hamada
<[email protected]>

---
 include/sbi_utils/serial/renesas-scif.h |  11 ++
 lib/utils/serial/Kconfig                |   4 +
 lib/utils/serial/objects.mk             |   1 +
 lib/utils/serial/renesas_scif.c         | 140 ++++++++++++++++++++++++
 4 files changed, 156 insertions(+)
 create mode 100644 include/sbi_utils/serial/renesas-scif.h
 create mode 100644 lib/utils/serial/renesas_scif.c
include/sbi_utils/serial/renesas-scif.h new file +11 -0
new file mode 100644
index 0000000..0002a1a
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: BSD-2-Clause */
+/*
+ * Copyright (C) 2022 Renesas Electronics Corporation
+ */
+
+#ifndef __SERIAL_RENESAS_SCIF_H__
+#define __SERIAL_RENESAS_SCIF_H__
+
+int renesas_scif_init(unsigned long base, u32 in_freq, u32 baudrate);
+
+#endif /* __SERIAL_RENESAS_SCIF_H__ */
lib/utils/serial/Kconfig +4 -0
index da549a7..f6ed803 100644
@@ -59,6 +59,10 @@ config SERIAL_GAISLER
 	bool "Gaisler UART support"
 	default n
 
+config SERIAL_RENESAS_SCIF
+	bool "Renesas SCIF support"
+	default n
+
 config SERIAL_SHAKTI
 	bool "Shakti UART support"
 	default n
lib/utils/serial/objects.mk +1 -0
index 98f3f9a..6520424 100644
@@ -36,6 +36,7 @@ libsbiutils-objs-$(CONFIG_FDT_SERIAL_XILINX_UARTLITE) += serial/fdt_serial_xlnx_
 
 libsbiutils-objs-$(CONFIG_SERIAL_CADENCE) += serial/cadence-uart.o
 libsbiutils-objs-$(CONFIG_SERIAL_GAISLER) += serial/gaisler-uart.o
+libsbiutils-objs-$(CONFIG_SERIAL_RENESAS_SCIF) += serial/renesas_scif.o
 libsbiutils-objs-$(CONFIG_SERIAL_SHAKTI) += serial/shakti-uart.o
 libsbiutils-objs-$(CONFIG_SERIAL_SIFIVE) += serial/sifive-uart.o
 libsbiutils-objs-$(CONFIG_SERIAL_LITEX) += serial/litex-uart.o
lib/utils/serial/renesas_scif.c new file +140 -0

140 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

RFC PATCH 1/7 lib: utils: serial: Add Renesas SCIF driver

? 2022-10-28???? 01:40 +0100?Prabhakar???

Quoted 114 lines

From: Lad Prabhakar <[email protected]>

Add Renesas SCIF driver.

Based on a patch in the BSP by Takeki Hamada
<[email protected]>

---

?include/sbi_utils/serial/renesas-scif.h |? 11 ++
?lib/utils/serial/Kconfig??????????????? |?? 4 +
?lib/utils/serial/objects.mk???????????? |?? 1 +
?lib/utils/serial/renesas_scif.c???????? | 140 ++++++++++++++++++++++++

?4 files changed, 156 insertions(+)
?create mode 100644 include/sbi_utils/serial/renesas-scif.h ?create mode 100644 lib/utils/serial/renesas_scif.c

include/sbi_utils/serial/renesas-scif.h new file +11 -0
new file mode 100644
index 0000000..0002a1a
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: BSD-2-Clause */
+/*
+ * Copyright (C) 2022 Renesas Electronics Corporation
+ */
+
+#ifndef __SERIAL_RENESAS_SCIF_H__
+#define __SERIAL_RENESAS_SCIF_H__
+
+int renesas_scif_init(unsigned long base, u32 in_freq, u32 baudrate);
+
+#endif /* __SERIAL_RENESAS_SCIF_H__ */
lib/utils/serial/Kconfig +0 -0
index da549a7..f6ed803 100644
@@ -59,6 +59,10 @@ config SERIAL_GAISLER

????????bool "Gaisler UART support"
????????default n
?

lib/utils/serial/Kconfig +4 -0
+config SERIAL_RENESAS_SCIF
+???????bool "Renesas SCIF support"
+???????default n
+

?config SERIAL_SHAKTI
????????bool "Shakti UART support"
????????default n

lib/utils/serial/objects.mk +0 -0
index 98f3f9a..6520424 100644
@@ -36,6 +36,7 @@ libsbiutils-objs-$(CONFIG_FDT_SERIAL_XILINX_UARTLITE) += serial/fdt_serial_xlnx_

?
?libsbiutils-objs-$(CONFIG_SERIAL_CADENCE) += serial/cadence-uart.o ?libsbiutils-objs-$(CONFIG_SERIAL_GAISLER) += serial/gaisler-uart.o +libsbiutils-objs-$(CONFIG_SERIAL_RENESAS_SCIF) += serial/renesas_scif.o ?libsbiutils-objs-$(CONFIG_SERIAL_SHAKTI) += serial/shakti-uart.o ?libsbiutils-objs-$(CONFIG_SERIAL_SIFIVE) += serial/sifive-uart.o ?libsbiutils-objs-$(CONFIG_SERIAL_LITEX) += serial/litex-uart.o

lib/utils/serial/renesas_scif.c new file +47 -0
new file mode 100644
index 0000000..13ac60b
@@ -0,0 +1,140 @@
+// SPDX-License-Identifier: BSD-2-Clause
+/*
+ * Copyright (C) 2022 Renesas Electronics Corporation
+ */
+
+#include <sbi/riscv_io.h>
+#include <sbi/sbi_console.h>
+#include <sbi/sbi_timer.h>
+#include <sbi_utils/serial/renesas-scif.h>
+
+/* clang-format off */
+
+#define SCIF_REG_SMR???????????0x0
+#define SCIF_REG_BRR???????????0x2
+#define SCIF_REG_SCR???????????0x4
+#define SCIF_REG_FTDR??????????0x6
+#define SCIF_REG_FSR???????????0x8
+#define SCIF_REG_FRDR??????????0xa
+#define SCIF_REG_FCR???????????0xc
+#define SCIF_REG_LSR???????????0x12
+#define SCIF_REG_SEMR??????????0x14
+
+#define SCIF_RFRST?????????????0x2 /* Reset assert receive-FIFO (bit[1]) */
+#define SCIF_TFRST?????????????0x4 /* Reset assert transmit-FIFO(bit[2]) */
+
+#define SCIF_FCR_RST_ASSRT_TFRF????????(SCIF_RFRST | SCIF_TFRST) /* Reset assert tx-FIFO & rx-FIFO */
+#define SCIF_FCR_RST_NGATE_TFRF????????0x0 /* Reset negate tx-FIFO & rx-FIFO*/
+
+#define SCIF_RE????????????????????????0x10 /* Enable receive (bit[4])? */
+#define SCIF_TE????????????????????????0x20 /* Enable transmit(bit[5])? */
+#define SCIF_SCR_RCV_TRN_EN????(SCIF_RE | SCIF_TE) /* Enable receive & transmit */
+#define SCIF_SCR_RCV_TRN_DIS???0x0 /* Disable receive & transmit */
+
+#define SCIF_FSR_ER????????????0x80 /* Receive error flag */
+#define SCIF_FSR_TEND??????????0x40 /* Detect break flag */
+#define SCIF_FSR_TDFE??????????0x20 /* Detect break flag */
+#define SCIF_FSR_BRK???????????0x10 /* Detect break flag */
+#define SCIF_FSR_RDF???????????0x2? /* Receive FIFO data full flag */
+#define SCIF_FSR_DR????????????0x1? /* Receive data ready flag */
+
+#define SCIF_FSR_RXD_CHK???????(SCIF_FSR_ER | SCIF_FSR_BRK | SCIF_FSR_DR)
+#define SCIF_FSR_TXD_CHK???????(SCIF_FSR_TEND | SCIF_FSR_TDFE)
+
+#define SCIF_LSR_ORER??????????0x1 /* Overrun error flag */
+
+#define SCIF_SPTR_SPB2DT???????0x1 /* if SCR.TE setting, don't care */
+#define SCIF_SPTR_SPB2IO???????0x2 /* if SCR.TE setting, don't care */

lib/utils/serial/renesas_scif.c line 57

Quoted 10 lines
lib/utils/serial/renesas_scif.c new file +10 -0
+
+#define SCIF_SEMR_BRME?????????0x20 /* bit-rate modulation enable */
+#define SCIF_SEMR_MDDRS????????????????0x10 /* MDDR access enable */
+
+#define SCIF_SIZE(reg)?????????((reg == SCIF_REG_BRR) || \
+??????????????????????????????? (reg == SCIF_REG_FTDR) || \
+??????????????????????????????? (reg == SCIF_REG_FRDR) || \
+??????????????????????????????? (reg == SCIF_REG_SEMR))
+
+#define SCBRR_VALUE(clk, baudrate) ((clk) / (64 / 2 * (baudrate)) - 1)

replace 62 /2 to 32

Quoted 17 lines
lib/utils/serial/renesas_scif.c new file +17 -0
+
+/* clang-format on */
+
+static volatile char *scif_base;
+
+static u32 get_reg(u32 offset)
+{
+???????if (SCIF_SIZE(offset))
+???????????????return readb(scif_base + offset);
+
+???????return readw(scif_base + offset);
+}
+
+static void set_reg(u32 offset, u32 val)
+{
+???????if (SCIF_SIZE(offset))
+???????????????return writeb(val, scif_base + offset);

lib/utils/serial/renesas_scif.c

Quoted 10 lines
lib/utils/serial/renesas_scif.c new file +10 -0
+
+???????return writew(val, scif_base + offset);
+}
+
+static void scif_wait(unsigned long baudrate)
+{
+???????unsigned long utime;
+
+???????utime = 1000000 / baudrate;
+???????utime += 1;

replace before 2 line to:

          utime = 1000000 / baudrate + 1;

Regards,
Xiang W

Quoted 60 lines
lib/utils/serial/renesas_scif.c new file +56 -0
+
+???????sbi_timer_udelay(utime);
+}
+
+static void renesas_scif_putc(char ch)
+{
+???????uint16_t reg;
+
+???????while (!(SCIF_FSR_TXD_CHK & get_reg(SCIF_REG_FSR)))
+???????????????;
+
+???????set_reg(SCIF_REG_FTDR, ch);
+???????reg = get_reg(SCIF_REG_FSR);
+???????reg &= ~SCIF_FSR_TXD_CHK;
+???????set_reg(SCIF_REG_FSR, reg);
+}
+
+static struct sbi_console_device renesas_scif_console = {
+???????.name???????????= "renesas_scif",
+???????.console_putc???= renesas_scif_putc,
+};
+
+int renesas_scif_init(unsigned long base, u32 in_freq, u32 baudrate)
+{
+???????volatile uint16_t data16;
+
+???????scif_base = (volatile char *)base;
+
+???????set_reg(SCIF_REG_SCR, SCIF_SCR_RCV_TRN_DIS); /* Disable receive & transmit */
+???????set_reg(SCIF_REG_FCR, SCIF_FCR_RST_ASSRT_TFRF); /* Reset assert tx-FIFO & rx-FIFO */
+
+???????data16 = get_reg(SCIF_REG_FSR); /* Dummy read */
+???????set_reg(SCIF_REG_FSR, 0x0); /* Clear all error bit */
+
+???????data16 = get_reg(SCIF_REG_LSR); /* Dummy read */
+???????set_reg(SCIF_REG_LSR, 0x0); /* Clear ORER bit */
+
+???????set_reg(SCIF_REG_SCR, 0x0); /* Select internal clock, SC_CLK pin unused for output pin */
+
+???????set_reg(SCIF_REG_SMR, 0x0); /* Set asynchronous, 8bit data, no-parity, 1 stop and Po/1 */
+
+???????data16 = get_reg(SCIF_REG_SEMR);
+???????set_reg(SCIF_REG_SEMR, data16 & (~SCIF_SEMR_MDDRS)); /* Select to access BRR */
+???????set_reg(SCIF_REG_BRR, SCBRR_VALUE(in_freq, baudrate));
+
+???????scif_wait(baudrate);
+
+???????/* FTCR is left at initial value, because this interrupt isn't used. */
+???????set_reg(SCIF_REG_FCR, SCIF_FCR_RST_NGATE_TFRF); /* Reset negate tx-FIFO, rx-FIFO. */
+
+???????set_reg(SCIF_REG_SCR, SCIF_SCR_RCV_TRN_EN); /* Enable receive & transmit w/SC_CLK=no output */
+
+???????sbi_console_set_device(&renesas_scif_console);
+
+???????return 0;
+}
Signature · 1 line
2.17.1
#3 lore raw

RFC PATCH 1/7 lib: utils: serial: Add Renesas SCIF driver

Hi Xiang,

Thank you for the review.

Quoted 25 lines · Xiang W

? 2022-10-28???? 01:40 +0100?Prabhakar???

Quoted 23 lines

From: Lad Prabhakar <[email protected]>

Add Renesas SCIF driver.

Based on a patch in the BSP by Takeki Hamada
<[email protected]>

---
 include/sbi_utils/serial/renesas-scif.h |  11 ++
 lib/utils/serial/Kconfig                |   4 +
 lib/utils/serial/objects.mk             |   1 +
 lib/utils/serial/renesas_scif.c         | 140 ++++++++++++++++++++++++
 4 files changed, 156 insertions(+)
 create mode 100644 include/sbi_utils/serial/renesas-scif.h
 create mode 100644 lib/utils/serial/renesas_scif.c
include/sbi_utils/serial/renesas-scif.h new file +0 -0
new file mode 100644
index 0000000..0002a1a
@@ -0,0 +1,11 @@

<snip>

Quoted 5 lines
Quoted 5 lines
include/sbi_utils/serial/renesas-scif.h new file +5 -0
+#define SCIF_SPTR_SPB2DT       0x1 /* if SCR.TE setting, don't care */
+#define SCIF_SPTR_SPB2IO       0x2 /* if SCR.TE setting, don't care */
+
+#define SCIF_SEMR_BRME         0x20 /* bit-rate modulation enable */
+#define SCIF_SEMR_MDDRS                0x10 /* MDDR access enable */
Quoted 9 lines

include/sbi_utils/serial/renesas-scif.h

Quoted 7 lines
include/sbi_utils/serial/renesas-scif.h new file +7 -0
+
+#define SCIF_SIZE(reg)         ((reg == SCIF_REG_BRR) || \
+                                (reg == SCIF_REG_FTDR) || \
+                                (reg == SCIF_REG_FRDR) || \
+                                (reg == SCIF_REG_SEMR))
+
+#define SCBRR_VALUE(clk, baudrate) ((clk) / (64 / 2 * (baudrate)) - 1)

replace 62 /2 to 32

OK.

Quoted 28 lines
Quoted 17 lines
include/sbi_utils/serial/renesas-scif.h new file +17 -0
+
+/* clang-format on */
+
+static volatile char *scif_base;
+
+static u32 get_reg(u32 offset)
+{
+       if (SCIF_SIZE(offset))
+               return readb(scif_base + offset);
+
+       return readw(scif_base + offset);
+}
+
+static void set_reg(u32 offset, u32 val)
+{
+       if (SCIF_SIZE(offset))
+               return writeb(val, scif_base + offset);

include/sbi_utils/serial/renesas-scif.h

Quoted 10 lines
include/sbi_utils/serial/renesas-scif.h new file +10 -0
+
+       return writew(val, scif_base + offset);
+}
+
+static void scif_wait(unsigned long baudrate)
+{
+       unsigned long utime;
+
+       utime = 1000000 / baudrate;
+       utime += 1;

replace before 2 line to:

Quoted 2 lines
          utime = 1000000 / baudrate + 1;

Agreed, will do.

Cheers,
Prabhakar

author
#4 lore raw

RFC PATCH 2/7 lib: utils: serial: Add FDT driver for Renesas SCIF

In reply to Prabhakar

From: Lad Prabhakar <[email protected]>

Add FDT driver for Renesas SCIF.

    dts example:

    soc: soc {
          ....
            scif0: serial at 1004b800 {
                    compatible = "renesas,scif-r9a07g043",
                                 "renesas,scif-r9a07g044";
                    reg = <0 0x1004b800 0 0x400>;
                    interrupts = <412 IRQ_TYPE_LEVEL_HIGH>,
                                 <414 IRQ_TYPE_LEVEL_HIGH>,
                                 <415 IRQ_TYPE_LEVEL_HIGH>,
                                 <413 IRQ_TYPE_LEVEL_HIGH>,
                                 <416 IRQ_TYPE_LEVEL_HIGH>,
                                 <416 IRQ_TYPE_LEVEL_HIGH>;
                    interrupt-names = "eri", "rxi", "txi",
                                      "bri", "dri", "tei";
                    clocks = <&cpg CPG_MOD R9A07G043_SCIF0_CLK_PCK>;
                    clock-names = "fck";
                    power-domains = <&cpg>;
                    resets = <&cpg R9A07G043_SCIF0_RST_SYSTEM_N>;
                    status = "disabled";
            };
          ....
    };
---
 include/sbi_utils/fdt/fdt_helper.h         |  3 +++
 lib/utils/fdt/fdt_helper.c                 | 23 ++++++++++++++++
 lib/utils/serial/Kconfig                   |  5 ++++
 lib/utils/serial/fdt_serial_renesas_scif.c | 31 ++++++++++++++++++++++
 lib/utils/serial/objects.mk                |  3 +++
 5 files changed, 65 insertions(+)
 create mode 100644 lib/utils/serial/fdt_serial_renesas_scif.c
include/sbi_utils/fdt/fdt_helper.h +3 -0
index c39f77a..09f3095 100644
@@ -59,6 +59,9 @@ int fdt_parse_timebase_frequency(void *fdt, unsigned long *freq);
 int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
 				struct platform_uart_data *uart);
 
+int fdt_parse_renesas_scif_node(void *fdt, int nodeoffset,
+				struct platform_uart_data *uart);
+
 int fdt_parse_shakti_uart_node(void *fdt, int nodeoffset,
 			       struct platform_uart_data *uart);
 
lib/utils/fdt/fdt_helper.c +23 -0
index d390436..483865e 100644
@@ -23,6 +23,11 @@
 #define DEFAULT_UART_REG_IO_WIDTH	1
 #define DEFAULT_UART_REG_OFFSET		0
 
+#define DEFAULT_RENESAS_SCIF_FREQ		100000000
+#define DEFAULT_RENESAS_SCIF_BAUD		115200
+#define DEFAULT_RENESAS_SCIF_REG_SHIFT		0
+#define DEFAULT_RENESAS_SCIF_REG_IO_WIDTH	4
+
 #define DEFAULT_SIFIVE_UART_FREQ		0
 #define DEFAULT_SIFIVE_UART_BAUD		115200
 #define DEFAULT_SIFIVE_UART_REG_SHIFT		0
@@ -370,6 +375,24 @@ int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
 	return 0;
 }
 
+int fdt_parse_renesas_scif_node(void *fdt, int nodeoffset,
+				struct platform_uart_data *uart)
+{
+	int rc;
+
+	rc = fdt_parse_uart_node_common(fdt, nodeoffset, uart,
+					DEFAULT_RENESAS_SCIF_FREQ,
+					DEFAULT_RENESAS_SCIF_BAUD);
+
+	if (rc)
+		return rc;
+
+	uart->reg_shift = DEFAULT_RENESAS_SCIF_REG_SHIFT;
+	uart->reg_io_width = DEFAULT_RENESAS_SCIF_REG_IO_WIDTH;
+
+	return 0;
+}
+
 int fdt_parse_shakti_uart_node(void *fdt, int nodeoffset,
 			       struct platform_uart_data *uart)
 {
lib/utils/serial/Kconfig +5 -0
index f6ed803..e3589ca 100644
@@ -24,6 +24,11 @@ config FDT_SERIAL_HTIF
 	select SYS_HTIF
 	default n
 
+config FDT_SERIAL_RENESAS_SCIF
+	bool "Renesas SCIF FDT driver"
+	select SERIAL_RENESAS_SCIF
+	default n
+
 config FDT_SERIAL_SHAKTI
 	bool "Shakti UART FDT driver"
 	select SERIAL_SHAKTI
lib/utils/serial/fdt_serial_renesas_scif.c new file +31 -0
new file mode 100644
index 0000000..c331ca1
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: BSD-2-Clause
+/*
+ * Copyright (C) 2022 Renesas Electronics Corporation
+ */
+
+#include <sbi_utils/fdt/fdt_helper.h>
+#include <sbi_utils/serial/fdt_serial.h>
+#include <sbi_utils/serial/renesas-scif.h>
+
+static int serial_renesas_scif_init(void *fdt, int nodeoff,
+				    const struct fdt_match *match)
+{
+	struct platform_uart_data uart = { 0 };
+	int ret;
+
+	ret = fdt_parse_renesas_scif_node(fdt, nodeoff, &uart);
+	if (ret)
+		return ret;
+
+	return renesas_scif_init(uart.addr, uart.freq, uart.baud);
+}
+
+static const struct fdt_match serial_renesas_scif_match[] = {
+	{ .compatible = "renesas,scif-r9a07g043" },
+	{ /* sentinel */ }
+};
+
+struct fdt_serial fdt_serial_renesas_scif = {
+	.match_table = serial_renesas_scif_match,
+	.init = serial_renesas_scif_init
+};
lib/utils/serial/objects.mk +3 -0
index 6520424..1e6bd2e 100644
@@ -19,6 +19,9 @@ libsbiutils-objs-$(CONFIG_FDT_SERIAL_GAISLER) += serial/fdt_serial_gaisler.o
 carray-fdt_serial_drivers-$(CONFIG_FDT_SERIAL_HTIF) += fdt_serial_htif
 libsbiutils-objs-$(CONFIG_FDT_SERIAL_HTIF) += serial/fdt_serial_htif.o
 
+carray-fdt_serial_drivers-$(CONFIG_FDT_SERIAL_RENESAS_SCIF) += fdt_serial_renesas_scif
+libsbiutils-objs-$(CONFIG_FDT_SERIAL_RENESAS_SCIF) += serial/fdt_serial_renesas_scif.o
+
 carray-fdt_serial_drivers-$(CONFIG_FDT_SERIAL_SHAKTI) += fdt_serial_shakti
 libsbiutils-objs-$(CONFIG_FDT_SERIAL_SHAKTI) += serial/fdt_serial_shakti.o
 
Signature · 1 line
2.17.1
#5 lore raw

RFC PATCH 2/7 lib: utils: serial: Add FDT driver for Renesas SCIF

? 2022-10-28???? 01:40 +0100?Prabhakar???

Quoted 77 lines

From: Lad Prabhakar <[email protected]>

Add FDT driver for Renesas SCIF.

??? dts example:

??? soc: soc {
????????? ....
??????????? scif0: serial at 1004b800 { ??????????????????? compatible = "renesas,scif-r9a07g043", ???????????????????????????????? "renesas,scif-r9a07g044"; ??????????????????? reg = <0 0x1004b800 0 0x400>; ??????????????????? interrupts = <412 IRQ_TYPE_LEVEL_HIGH>, ???????????????????????????????? <414 IRQ_TYPE_LEVEL_HIGH>, ???????????????????????????????? <415 IRQ_TYPE_LEVEL_HIGH>, ???????????????????????????????? <413 IRQ_TYPE_LEVEL_HIGH>, ???????????????????????????????? <416 IRQ_TYPE_LEVEL_HIGH>, ???????????????????????????????? <416 IRQ_TYPE_LEVEL_HIGH>; ??????????????????? interrupt-names = "eri", "rxi", "txi", ????????????????????????????????????? "bri", "dri", "tei"; ??????????????????? clocks = <&cpg CPG_MOD R9A07G043_SCIF0_CLK_PCK>; ??????????????????? clock-names = "fck"; ??????????????????? power-domains = <&cpg>; ??????????????????? resets = <&cpg R9A07G043_SCIF0_RST_SYSTEM_N>; ??????????????????? status = "disabled";
??????????? };
????????? ....
??? };

---

?include/sbi_utils/fdt/fdt_helper.h???????? |? 3 +++
?lib/utils/fdt/fdt_helper.c???????????????? | 23 ++++++++++++++++
?lib/utils/serial/Kconfig?????????????????? |? 5 ++++
?lib/utils/serial/fdt_serial_renesas_scif.c | 31 ++++++++++++++++++++++
?lib/utils/serial/objects.mk??????????????? |? 3 +++

?5 files changed, 65 insertions(+)
?create mode 100644 lib/utils/serial/fdt_serial_renesas_scif.c

include/sbi_utils/fdt/fdt_helper.h +0 -0
index c39f77a..09f3095 100644
@@ -59,6 +59,9 @@ int fdt_parse_timebase_frequency(void *fdt, unsigned long *freq);
 ?int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
 ????????????????????????????????struct platform_uart_data *uart);

?

include/sbi_utils/fdt/fdt_helper.h +3 -0
+int fdt_parse_renesas_scif_node(void *fdt, int nodeoffset,
+???????????????????????????????struct platform_uart_data *uart);
+

?int fdt_parse_shakti_uart_node(void *fdt, int nodeoffset, ?????????????????????????????? struct platform_uart_data *uart); ?

lib/utils/fdt/fdt_helper.c +0 -0
index d390436..483865e 100644
@@ -23,6 +23,11 @@

?#define DEFAULT_UART_REG_IO_WIDTH??????1
?#define DEFAULT_UART_REG_OFFSET????????????????0
?

lib/utils/fdt/fdt_helper.c +5 -0
+#define DEFAULT_RENESAS_SCIF_FREQ??????????????100000000
+#define DEFAULT_RENESAS_SCIF_BAUD??????????????115200
+#define DEFAULT_RENESAS_SCIF_REG_SHIFT?????????0
+#define DEFAULT_RENESAS_SCIF_REG_IO_WIDTH??????4
+

?#define DEFAULT_SIFIVE_UART_FREQ???????????????0 ?#define DEFAULT_SIFIVE_UART_BAUD???????????????115200 ?#define DEFAULT_SIFIVE_UART_REG_SHIFT??????????0

lib/utils/fdt/fdt_helper.c +0 -0
@@ -370,6 +375,24 @@ int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
 ????????return 0;
 ?}

?

lib/utils/fdt/fdt_helper.c +4 -0
+int fdt_parse_renesas_scif_node(void *fdt, int nodeoffset,
+???????????????????????????????struct platform_uart_data *uart)
+{
+???????int rc;

lib/utils/fdt/fdt_helper.c

Quoted 10 lines
lib/utils/fdt/fdt_helper.c +10 -0
+
+???????rc = fdt_parse_uart_node_common(fdt, nodeoffset, uart,
+???????????????????????????????????????DEFAULT_RENESAS_SCIF_FREQ,
+???????????????????????????????????????DEFAULT_RENESAS_SCIF_BAUD);
+
+???????if (rc)
+???????????????return rc;
+
+???????uart->reg_shift = DEFAULT_RENESAS_SCIF_REG_SHIFT;
+???????uart->reg_io_width = DEFAULT_RENESAS_SCIF_REG_IO_WIDTH;

uart->reg_shift and uart->reg_io_width not used in your dirver. This 2 lines can be dropped.

Regards,
Xiang W

Quoted 78 lines
lib/utils/fdt/fdt_helper.c +4 -0
+
+???????return 0;
+}
+

?int fdt_parse_shakti_uart_node(void *fdt, int nodeoffset, ?????????????????????????????? struct platform_uart_data *uart) ?{

lib/utils/serial/Kconfig +0 -0
index f6ed803..e3589ca 100644
@@ -24,6 +24,11 @@ config FDT_SERIAL_HTIF

????????select SYS_HTIF
????????default n
?

lib/utils/serial/Kconfig +5 -0
+config FDT_SERIAL_RENESAS_SCIF
+???????bool "Renesas SCIF FDT driver"
+???????select SERIAL_RENESAS_SCIF
+???????default n
+

?config FDT_SERIAL_SHAKTI
????????bool "Shakti UART FDT driver"
????????select SERIAL_SHAKTI

lib/utils/serial/fdt_serial_renesas_scif.c new file +31 -0
new file mode 100644
index 0000000..c331ca1
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: BSD-2-Clause
+/*
+ * Copyright (C) 2022 Renesas Electronics Corporation
+ */
+
+#include <sbi_utils/fdt/fdt_helper.h>
+#include <sbi_utils/serial/fdt_serial.h>
+#include <sbi_utils/serial/renesas-scif.h>
+
+static int serial_renesas_scif_init(void *fdt, int nodeoff,
+?????????????????????????????????? const struct fdt_match *match)
+{
+???????struct platform_uart_data uart = { 0 };
+???????int ret;
+
+???????ret = fdt_parse_renesas_scif_node(fdt, nodeoff, &uart);
+???????if (ret)
+???????????????return ret;
+
+???????return renesas_scif_init(uart.addr, uart.freq, uart.baud);
+}
+
+static const struct fdt_match serial_renesas_scif_match[] = {
+???????{ .compatible = "renesas,scif-r9a07g043" },
+???????{ /* sentinel */ }
+};
+
+struct fdt_serial fdt_serial_renesas_scif = {
+???????.match_table = serial_renesas_scif_match,
+???????.init = serial_renesas_scif_init
+};
lib/utils/serial/objects.mk +0 -0
index 6520424..1e6bd2e 100644
@@ -19,6 +19,9 @@ libsbiutils-objs-$(CONFIG_FDT_SERIAL_GAISLER) += serial/fdt_serial_gaisler.o

?carray-fdt_serial_drivers-$(CONFIG_FDT_SERIAL_HTIF) += fdt_serial_htif ?libsbiutils-objs-$(CONFIG_FDT_SERIAL_HTIF) += serial/fdt_serial_htif.o ?

lib/utils/serial/objects.mk +3 -0
+carray-fdt_serial_drivers-$(CONFIG_FDT_SERIAL_RENESAS_SCIF) += fdt_serial_renesas_scif
+libsbiutils-objs-$(CONFIG_FDT_SERIAL_RENESAS_SCIF) += serial/fdt_serial_renesas_scif.o
+

?carray-fdt_serial_drivers-$(CONFIG_FDT_SERIAL_SHAKTI) += fdt_serial_shakti ?libsbiutils-objs-$(CONFIG_FDT_SERIAL_SHAKTI) += serial/fdt_serial_shakti.o ?

Signature · 1 line
2.17.1
#6 lore raw

RFC PATCH 2/7 lib: utils: serial: Add FDT driver for Renesas SCIF

Hi Xiang,

Thank you for the review.

Quoted 75 lines · Xiang W

? 2022-10-28???? 01:40 +0100?Prabhakar???

Quoted 73 lines

From: Lad Prabhakar <[email protected]>

Add FDT driver for Renesas SCIF.

    dts example:

    soc: soc {
          ....
            scif0: serial at 1004b800 {
                    compatible = "renesas,scif-r9a07g043",
                                 "renesas,scif-r9a07g044";
                    reg = <0 0x1004b800 0 0x400>;
                    interrupts = <412 IRQ_TYPE_LEVEL_HIGH>,
                                 <414 IRQ_TYPE_LEVEL_HIGH>,
                                 <415 IRQ_TYPE_LEVEL_HIGH>,
                                 <413 IRQ_TYPE_LEVEL_HIGH>,
                                 <416 IRQ_TYPE_LEVEL_HIGH>,
                                 <416 IRQ_TYPE_LEVEL_HIGH>;
                    interrupt-names = "eri", "rxi", "txi",
                                      "bri", "dri", "tei";
                    clocks = <&cpg CPG_MOD R9A07G043_SCIF0_CLK_PCK>;
                    clock-names = "fck";
                    power-domains = <&cpg>;
                    resets = <&cpg R9A07G043_SCIF0_RST_SYSTEM_N>;
                    status = "disabled";
            };
          ....
    };
---
 include/sbi_utils/fdt/fdt_helper.h         |  3 +++
 lib/utils/fdt/fdt_helper.c                 | 23 ++++++++++++++++
 lib/utils/serial/Kconfig                   |  5 ++++
 lib/utils/serial/fdt_serial_renesas_scif.c | 31 ++++++++++++++++++++++
 lib/utils/serial/objects.mk                |  3 +++
 5 files changed, 65 insertions(+)
 create mode 100644 lib/utils/serial/fdt_serial_renesas_scif.c
include/sbi_utils/fdt/fdt_helper.h +3 -0
index c39f77a..09f3095 100644
@@ -59,6 +59,9 @@ int fdt_parse_timebase_frequency(void *fdt, unsigned long *freq);
 int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
                                struct platform_uart_data *uart);
 
+int fdt_parse_renesas_scif_node(void *fdt, int nodeoffset,
+                               struct platform_uart_data *uart);
+
 int fdt_parse_shakti_uart_node(void *fdt, int nodeoffset,
                               struct platform_uart_data *uart);
 
lib/utils/fdt/fdt_helper.c +5 -0
index d390436..483865e 100644
@@ -23,6 +23,11 @@
 #define DEFAULT_UART_REG_IO_WIDTH      1
 #define DEFAULT_UART_REG_OFFSET                0
 
+#define DEFAULT_RENESAS_SCIF_FREQ              100000000
+#define DEFAULT_RENESAS_SCIF_BAUD              115200
+#define DEFAULT_RENESAS_SCIF_REG_SHIFT         0
+#define DEFAULT_RENESAS_SCIF_REG_IO_WIDTH      4
+
 #define DEFAULT_SIFIVE_UART_FREQ               0
 #define DEFAULT_SIFIVE_UART_BAUD               115200
 #define DEFAULT_SIFIVE_UART_REG_SHIFT          0
@@ -370,6 +375,24 @@ int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
        return 0;
 }
 
Quoted 17 lines
Quoted 4 lines
lib/utils/fdt/fdt_helper.c +4 -0
+int fdt_parse_renesas_scif_node(void *fdt, int nodeoffset,
+                               struct platform_uart_data *uart)
+{
+       int rc;

lib/utils/fdt/fdt_helper.c int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset, · line 391

Quoted 10 lines
lib/utils/fdt/fdt_helper.c +10 -0
+
+       rc = fdt_parse_uart_node_common(fdt, nodeoffset, uart,
+                                       DEFAULT_RENESAS_SCIF_FREQ,
+                                       DEFAULT_RENESAS_SCIF_BAUD);
+
+       if (rc)
+               return rc;
+
+       uart->reg_shift = DEFAULT_RENESAS_SCIF_REG_SHIFT;
+       uart->reg_io_width = DEFAULT_RENESAS_SCIF_REG_IO_WIDTH;

uart->reg_shift and uart->reg_io_width not used in your dirver. This 2 lines can be dropped.

Ok I will drop them. I was under the impression these fields had to be initialized, for example the Sifive uart driver doesn't use them but it's still being set in the helpers.

Cheers,
Prabhakar

author
#7 lore raw

RFC PATCH 3/7 platform: andes/ae350: Split header platform.h header file

In reply to Prabhakar

From: Lad Prabhakar <[email protected]>

Split up the platform.h header file into
- platform.h #Contains platform specific macros
- common-platform.h #contains macros common across Andes platforms

This is in preparation for adding the Renesas RZ/Five SoC which is based on Andes AX45MP core.

---
 platform/andes/ae350/common-platform.h | 94 ++++++++++++++++++++++++++
 platform/andes/ae350/platform.h        | 82 +---------------------
 2 files changed, 96 insertions(+), 80 deletions(-)
 create mode 100644 platform/andes/ae350/common-platform.h
platform/andes/ae350/common-platform.h new file +94 -0
new file mode 100644
index 0000000..6334a2e
@@ -0,0 +1,94 @@
+/* SPDX-License-Identifier: BSD-2-Clause */
+/*
+ * Copyright (c) 2019 Andes Technology Corporation
+ *
+ * Authors:
+ *   Zong Li <[email protected]>
+ *   Nylon Chen <[email protected]>
+ */
+
+#ifndef _AE350_COMMON_PLATFORM_H_
+#define _AE350_COMMON_PLATFORM_H_
+
+/* Memory and Miscellaneous Registers */
+#define CSR_MILMB		0x7c0
+#define CSR_MDLMB		0x7c1
+#define CSR_MECC_CDOE		0x7c2
+#define CSR_MNVEC		0x7c3
+#define CSR_MPFTCTL		0x7c5
+#define CSR_MCACHECTL		0x7ca
+#define CSR_MCCTLBEGINADDR	0x7cb
+#define CSR_MCCTLCOMMAND	0x7cc
+#define CSR_MCCTLDATA		0x7cc
+#define CSR_SCCTLDATA		0x9cd
+#define CSR_UCCTLBEGINADDR	0x80c
+#define CSR_MMISCCTL		0x7d0
+
+/* nds v5 mmisc_ctl register*/
+#define V5_MMISC_CTL_VEC_PLIC_OFFSET		1
+#define V5_MMISC_CTL_RVCOMPM_OFFSET		2
+#define V5_MMISC_CTL_BRPE_OFFSET		3
+#define V5_MMISC_CTL_MSA_OR_UNA_OFFSET		6
+#define V5_MMISC_CTL_NON_BLOCKING_OFFSET	8
+#define V5_MCACHE_CTL_L1I_PREFETCH_OFFSET	9
+#define V5_MCACHE_CTL_L1D_PREFETCH_OFFSET	10
+#define V5_MCACHE_CTL_DC_WAROUND_OFFSET_1	13
+#define V5_MCACHE_CTL_DC_WAROUND_OFFSET_2	14
+
+#define V5_MMISC_CTL_VEC_PLIC_EN	(1UL << V5_MMISC_CTL_VEC_PLIC_OFFSET)
+#define V5_MMISC_CTL_RVCOMPM_EN		(1UL << V5_MMISC_CTL_RVCOMPM_OFFSET)
+#define V5_MMISC_CTL_BRPE_EN		(1UL << V5_MMISC_CTL_BRPE_OFFSET)
+#define V5_MMISC_CTL_MSA_OR_UNA_EN	(1UL << V5_MMISC_CTL_MSA_OR_UNA_OFFSET)
+#define V5_MMISC_CTL_NON_BLOCKING_EN	(1UL << V5_MMISC_CTL_NON_BLOCKING_OFFSET)
+#define V5_MCACHE_CTL_L1I_PREFETCH_EN	(1UL << V5_MCACHE_CTL_L1I_PREFETCH_OFFSET)
+#define V5_MCACHE_CTL_L1D_PREFETCH_EN	(1UL << V5_MCACHE_CTL_L1D_PREFETCH_OFFSET)
+#define V5_MCACHE_CTL_DC_WAROUND_1_EN	(1UL << V5_MCACHE_CTL_DC_WAROUND_OFFSET_1)
+#define V5_MCACHE_CTL_DC_WAROUND_2_EN	(1UL << V5_MCACHE_CTL_DC_WAROUND_OFFSET_2)
+
+#define V5_MMISC_CTL_MASK	(V5_MMISC_CTL_VEC_PLIC_EN | V5_MMISC_CTL_RVCOMPM_EN | \
+				 V5_MMISC_CTL_BRPE_EN | V5_MMISC_CTL_MSA_OR_UNA_EN | \
+				 V5_MMISC_CTL_NON_BLOCKING_EN)
+
+/* nds mcache_ctl register */
+#define V5_MCACHE_CTL_IC_EN_OFFSET	0
+#define V5_MCACHE_CTL_DC_EN_OFFSET	1
+#define V5_MCACHE_CTL_IC_ECCEN_OFFSET	2
+#define V5_MCACHE_CTL_DC_ECCEN_OFFSET	4
+#define V5_MCACHE_CTL_IC_RWECC_OFFSET	6
+#define V5_MCACHE_CTL_DC_RWECC_OFFSET	7
+#define V5_MCACHE_CTL_CCTL_SUEN_OFFSET	8
+
+/* nds cctl command */
+#define V5_UCCTL_L1D_WBINVAL_ALL	6
+#define V5_UCCTL_L1D_WB_ALL		7
+
+#define V5_MCACHE_CTL_IC_EN	(1UL << V5_MCACHE_CTL_IC_EN_OFFSET)
+#define V5_MCACHE_CTL_DC_EN	(1UL << V5_MCACHE_CTL_DC_EN_OFFSET)
+#define V5_MCACHE_CTL_IC_RWECC	(1UL << V5_MCACHE_CTL_IC_RWECC_OFFSET)
+#define V5_MCACHE_CTL_DC_RWECC	(1UL << V5_MCACHE_CTL_DC_RWECC_OFFSET)
+#define V5_MCACHE_CTL_CCTL_SUEN	(1UL << V5_MCACHE_CTL_CCTL_SUEN_OFFSET)
+
+#define V5_MCACHE_CTL_MASK	(V5_MCACHE_CTL_IC_EN | V5_MCACHE_CTL_DC_EN | \
+				 V5_MCACHE_CTL_IC_RWECC | V5_MCACHE_CTL_DC_RWECC | \
+				 V5_MCACHE_CTL_CCTL_SUEN | V5_MCACHE_CTL_L1I_PREFETCH_EN | \
+				 V5_MCACHE_CTL_L1D_PREFETCH_EN | V5_MCACHE_CTL_DC_WAROUND_1_EN | \
+				 V5_MCACHE_CTL_DC_WAROUND_2_EN)
+
+#define V5_L2C_CTL_OFFSET		0x8
+#define V5_L2C_CTL_ENABLE_OFFSET	0
+#define V5_L2C_CTL_IPFDPT_OFFSET	3
+#define V5_L2C_CTL_DPFDPT_OFFSET	5
+#define V5_L2C_CTL_TRAMOCTL_OFFSET	8
+#define V5_L2C_CTL_TRAMICTL_OFFSET	10
+#define V5_L2C_CTL_DRAMOCTL_OFFSET	11
+#define V5_L2C_CTL_DRAMICTL_OFFSET	13
+
+#define V5_L2C_CTL_ENABLE_MASK		(1UL << V5_L2C_CTL_ENABLE_OFFSET)
+#define V5_L2C_CTL_IPFDPT_MASK		(3UL << V5_L2C_CTL_IPFDPT_OFFSET)
+#define V5_L2C_CTL_DPFDPT_MASK		(3UL << V5_L2C_CTL_DPFDPT_OFFSET)
+#define V5_L2C_CTL_TRAMOCTL_MASK	(3UL << V5_L2C_CTL_TRAMOCTL_OFFSET)
+#define V5_L2C_CTL_TRAMICTL_MASK	(1UL << V5_L2C_CTL_TRAMICTL_OFFSET)
+#define V5_L2C_CTL_DRAMOCTL_MASK	(3UL << V5_L2C_CTL_DRAMOCTL_OFFSET)
+#define V5_L2C_CTL_DRAMICTL_MASK	(1UL << V5_L2C_CTL_DRAMICTL_OFFSET)
+
+#endif /* _AE350_COMMON_PLATFORM_H_ */
platform/andes/ae350/platform.h +2 -80

93 lines not on this page · raw message

Signature · 1 line
2.17.1
#8 lore raw

RFC PATCH 3/7 platform: andes/ae350: Split header platform.h header file

Quoted 218 lines · Prabhakar

From: Lad Prabhakar <[email protected]>

Split up the platform.h header file into
- platform.h #Contains platform specific macros
- common-platform.h #contains macros common across Andes platforms

This is in preparation for adding the Renesas RZ/Five SoC which is based on Andes AX45MP core.

---
 platform/andes/ae350/common-platform.h | 94 ++++++++++++++++++++++++++
 platform/andes/ae350/platform.h        | 82 +---------------------
 2 files changed, 96 insertions(+), 80 deletions(-)
 create mode 100644 platform/andes/ae350/common-platform.h
platform/andes/ae350/common-platform.h new file +94 -0
new file mode 100644
index 0000000..6334a2e
@@ -0,0 +1,94 @@
+/* SPDX-License-Identifier: BSD-2-Clause */
+/*
+ * Copyright (c) 2019 Andes Technology Corporation
+ *
+ * Authors:
+ *   Zong Li <[email protected]>
+ *   Nylon Chen <[email protected]>
+ */
+
+#ifndef _AE350_COMMON_PLATFORM_H_
+#define _AE350_COMMON_PLATFORM_H_
+
+/* Memory and Miscellaneous Registers */
+#define CSR_MILMB		0x7c0
+#define CSR_MDLMB		0x7c1
+#define CSR_MECC_CDOE		0x7c2
+#define CSR_MNVEC		0x7c3
+#define CSR_MPFTCTL		0x7c5
+#define CSR_MCACHECTL		0x7ca
+#define CSR_MCCTLBEGINADDR	0x7cb
+#define CSR_MCCTLCOMMAND	0x7cc
+#define CSR_MCCTLDATA		0x7cc
+#define CSR_SCCTLDATA		0x9cd
+#define CSR_UCCTLBEGINADDR	0x80c
+#define CSR_MMISCCTL		0x7d0
+
+/* nds v5 mmisc_ctl register*/
+#define V5_MMISC_CTL_VEC_PLIC_OFFSET		1
+#define V5_MMISC_CTL_RVCOMPM_OFFSET		2
+#define V5_MMISC_CTL_BRPE_OFFSET		3
+#define V5_MMISC_CTL_MSA_OR_UNA_OFFSET		6
+#define V5_MMISC_CTL_NON_BLOCKING_OFFSET	8
+#define V5_MCACHE_CTL_L1I_PREFETCH_OFFSET	9
+#define V5_MCACHE_CTL_L1D_PREFETCH_OFFSET	10
+#define V5_MCACHE_CTL_DC_WAROUND_OFFSET_1	13
+#define V5_MCACHE_CTL_DC_WAROUND_OFFSET_2	14
+
+#define V5_MMISC_CTL_VEC_PLIC_EN	(1UL << V5_MMISC_CTL_VEC_PLIC_OFFSET)
+#define V5_MMISC_CTL_RVCOMPM_EN		(1UL << V5_MMISC_CTL_RVCOMPM_OFFSET)
+#define V5_MMISC_CTL_BRPE_EN		(1UL << V5_MMISC_CTL_BRPE_OFFSET)
+#define V5_MMISC_CTL_MSA_OR_UNA_EN	(1UL << V5_MMISC_CTL_MSA_OR_UNA_OFFSET)
+#define V5_MMISC_CTL_NON_BLOCKING_EN	(1UL << V5_MMISC_CTL_NON_BLOCKING_OFFSET)
+#define V5_MCACHE_CTL_L1I_PREFETCH_EN	(1UL << V5_MCACHE_CTL_L1I_PREFETCH_OFFSET)
+#define V5_MCACHE_CTL_L1D_PREFETCH_EN	(1UL << V5_MCACHE_CTL_L1D_PREFETCH_OFFSET)
+#define V5_MCACHE_CTL_DC_WAROUND_1_EN	(1UL << V5_MCACHE_CTL_DC_WAROUND_OFFSET_1)
+#define V5_MCACHE_CTL_DC_WAROUND_2_EN	(1UL << V5_MCACHE_CTL_DC_WAROUND_OFFSET_2)
+
+#define V5_MMISC_CTL_MASK	(V5_MMISC_CTL_VEC_PLIC_EN | V5_MMISC_CTL_RVCOMPM_EN | \
+				 V5_MMISC_CTL_BRPE_EN | V5_MMISC_CTL_MSA_OR_UNA_EN | \
+				 V5_MMISC_CTL_NON_BLOCKING_EN)
+
+/* nds mcache_ctl register */
+#define V5_MCACHE_CTL_IC_EN_OFFSET	0
+#define V5_MCACHE_CTL_DC_EN_OFFSET	1
+#define V5_MCACHE_CTL_IC_ECCEN_OFFSET	2
+#define V5_MCACHE_CTL_DC_ECCEN_OFFSET	4
+#define V5_MCACHE_CTL_IC_RWECC_OFFSET	6
+#define V5_MCACHE_CTL_DC_RWECC_OFFSET	7
+#define V5_MCACHE_CTL_CCTL_SUEN_OFFSET	8
+
+/* nds cctl command */
+#define V5_UCCTL_L1D_WBINVAL_ALL	6
+#define V5_UCCTL_L1D_WB_ALL		7
+
+#define V5_MCACHE_CTL_IC_EN	(1UL << V5_MCACHE_CTL_IC_EN_OFFSET)
+#define V5_MCACHE_CTL_DC_EN	(1UL << V5_MCACHE_CTL_DC_EN_OFFSET)
+#define V5_MCACHE_CTL_IC_RWECC	(1UL << V5_MCACHE_CTL_IC_RWECC_OFFSET)
+#define V5_MCACHE_CTL_DC_RWECC	(1UL << V5_MCACHE_CTL_DC_RWECC_OFFSET)
+#define V5_MCACHE_CTL_CCTL_SUEN	(1UL << V5_MCACHE_CTL_CCTL_SUEN_OFFSET)
+
+#define V5_MCACHE_CTL_MASK	(V5_MCACHE_CTL_IC_EN | V5_MCACHE_CTL_DC_EN | \
+				 V5_MCACHE_CTL_IC_RWECC | V5_MCACHE_CTL_DC_RWECC | \
+				 V5_MCACHE_CTL_CCTL_SUEN | V5_MCACHE_CTL_L1I_PREFETCH_EN | \
+				 V5_MCACHE_CTL_L1D_PREFETCH_EN | V5_MCACHE_CTL_DC_WAROUND_1_EN | \
+				 V5_MCACHE_CTL_DC_WAROUND_2_EN)
+
+#define V5_L2C_CTL_OFFSET		0x8
+#define V5_L2C_CTL_ENABLE_OFFSET	0
+#define V5_L2C_CTL_IPFDPT_OFFSET	3
+#define V5_L2C_CTL_DPFDPT_OFFSET	5
+#define V5_L2C_CTL_TRAMOCTL_OFFSET	8
+#define V5_L2C_CTL_TRAMICTL_OFFSET	10
+#define V5_L2C_CTL_DRAMOCTL_OFFSET	11
+#define V5_L2C_CTL_DRAMICTL_OFFSET	13
+
+#define V5_L2C_CTL_ENABLE_MASK		(1UL << V5_L2C_CTL_ENABLE_OFFSET)
+#define V5_L2C_CTL_IPFDPT_MASK		(3UL << V5_L2C_CTL_IPFDPT_OFFSET)
+#define V5_L2C_CTL_DPFDPT_MASK		(3UL << V5_L2C_CTL_DPFDPT_OFFSET)
+#define V5_L2C_CTL_TRAMOCTL_MASK	(3UL << V5_L2C_CTL_TRAMOCTL_OFFSET)
+#define V5_L2C_CTL_TRAMICTL_MASK	(1UL << V5_L2C_CTL_TRAMICTL_OFFSET)
+#define V5_L2C_CTL_DRAMOCTL_MASK	(3UL << V5_L2C_CTL_DRAMOCTL_OFFSET)
+#define V5_L2C_CTL_DRAMICTL_MASK	(1UL << V5_L2C_CTL_DRAMICTL_OFFSET)
+
+#endif /* _AE350_COMMON_PLATFORM_H_ */
platform/andes/ae350/platform.h +2 -80
index 903bef0..45de792 100644
@@ -11,21 +11,9 @@
 #ifndef _AE350_PLATFORM_H_
 #define _AE350_PLATFORM_H_
 
-#define AE350_L2C_ADDR			0xe0500000
+#include "common-platform.h"
 
-/*Memory and Miscellaneous Registers*/
-#define CSR_MILMB		0x7c0
-#define CSR_MDLMB		0x7c1
-#define CSR_MECC_CDOE		0x7c2
-#define CSR_MNVEC		0x7c3
-#define CSR_MPFTCTL		0x7c5
-#define CSR_MCACHECTL		0x7ca
-#define CSR_MCCTLBEGINADDR	0x7cb
-#define CSR_MCCTLCOMMAND	0x7cc
-#define CSR_MCCTLDATA		0x7cc
-#define CSR_SCCTLDATA		0x9cd
-#define CSR_UCCTLBEGINADDR	0x80c
-#define CSR_MMISCCTL		0x7d0
+#define AE350_L2C_ADDR			0xe0500000
 
 enum sbi_ext_andes_fid {
 	SBI_EXT_ANDES_GET_MCACHE_CTL_STATUS = 0,
@@ -40,70 +28,4 @@ enum sbi_ext_andes_fid {
 	SBI_EXT_ANDES_WRITE_AROUND,
 };
 
-/* nds v5 mmisc_ctl register*/
-#define V5_MMISC_CTL_VEC_PLIC_OFFSET            1
-#define V5_MMISC_CTL_RVCOMPM_OFFSET             2
-#define V5_MMISC_CTL_BRPE_OFFSET                3
-#define V5_MMISC_CTL_MSA_OR_UNA_OFFSET          6
-#define V5_MMISC_CTL_NON_BLOCKING_OFFSET        8
-#define V5_MCACHE_CTL_L1I_PREFETCH_OFFSET       9
-#define V5_MCACHE_CTL_L1D_PREFETCH_OFFSET       10
-#define V5_MCACHE_CTL_DC_WAROUND_OFFSET_1       13
-#define V5_MCACHE_CTL_DC_WAROUND_OFFSET_2       14
-
-#define V5_MMISC_CTL_VEC_PLIC_EN        (1UL << V5_MMISC_CTL_VEC_PLIC_OFFSET)
-#define V5_MMISC_CTL_RVCOMPM_EN         (1UL << V5_MMISC_CTL_RVCOMPM_OFFSET)
-#define V5_MMISC_CTL_BRPE_EN            (1UL << V5_MMISC_CTL_BRPE_OFFSET)
-#define V5_MMISC_CTL_MSA_OR_UNA_EN      (1UL << V5_MMISC_CTL_MSA_OR_UNA_OFFSET)
-#define V5_MMISC_CTL_NON_BLOCKING_EN    (1UL << V5_MMISC_CTL_NON_BLOCKING_OFFSET)
-#define V5_MCACHE_CTL_L1I_PREFETCH_EN   (1UL << V5_MCACHE_CTL_L1I_PREFETCH_OFFSET)
-#define V5_MCACHE_CTL_L1D_PREFETCH_EN   (1UL << V5_MCACHE_CTL_L1D_PREFETCH_OFFSET)
-#define V5_MCACHE_CTL_DC_WAROUND_1_EN   (1UL << V5_MCACHE_CTL_DC_WAROUND_OFFSET_1)
-#define V5_MCACHE_CTL_DC_WAROUND_2_EN   (1UL << V5_MCACHE_CTL_DC_WAROUND_OFFSET_2)
-
-#define V5_MMISC_CTL_MASK  (V5_MMISC_CTL_VEC_PLIC_EN | V5_MMISC_CTL_RVCOMPM_EN \
-	| V5_MMISC_CTL_BRPE_EN | V5_MMISC_CTL_MSA_OR_UNA_EN | V5_MMISC_CTL_NON_BLOCKING_EN)
-
-/* nds mcache_ctl register*/
-#define V5_MCACHE_CTL_IC_EN_OFFSET      0
-#define V5_MCACHE_CTL_DC_EN_OFFSET      1
-#define V5_MCACHE_CTL_IC_ECCEN_OFFSET   2
-#define V5_MCACHE_CTL_DC_ECCEN_OFFSET   4
-#define V5_MCACHE_CTL_IC_RWECC_OFFSET   6
-#define V5_MCACHE_CTL_DC_RWECC_OFFSET   7
-#define V5_MCACHE_CTL_CCTL_SUEN_OFFSET  8
-
-/*nds cctl command*/
-#define V5_UCCTL_L1D_WBINVAL_ALL 6
-#define V5_UCCTL_L1D_WB_ALL 7
-
-#define V5_MCACHE_CTL_IC_EN     (1UL << V5_MCACHE_CTL_IC_EN_OFFSET)
-#define V5_MCACHE_CTL_DC_EN     (1UL << V5_MCACHE_CTL_DC_EN_OFFSET)
-#define V5_MCACHE_CTL_IC_RWECC  (1UL << V5_MCACHE_CTL_IC_RWECC_OFFSET)
-#define V5_MCACHE_CTL_DC_RWECC  (1UL << V5_MCACHE_CTL_DC_RWECC_OFFSET)
-#define V5_MCACHE_CTL_CCTL_SUEN (1UL << V5_MCACHE_CTL_CCTL_SUEN_OFFSET)
-
-#define V5_MCACHE_CTL_MASK (V5_MCACHE_CTL_IC_EN | V5_MCACHE_CTL_DC_EN \
-	| V5_MCACHE_CTL_IC_RWECC | V5_MCACHE_CTL_DC_RWECC \
-	| V5_MCACHE_CTL_CCTL_SUEN | V5_MCACHE_CTL_L1I_PREFETCH_EN \
-	| V5_MCACHE_CTL_L1D_PREFETCH_EN | V5_MCACHE_CTL_DC_WAROUND_1_EN \
-	| V5_MCACHE_CTL_DC_WAROUND_2_EN)
-
-#define V5_L2C_CTL_OFFSET           0x8
-#define V5_L2C_CTL_ENABLE_OFFSET    0
-#define V5_L2C_CTL_IPFDPT_OFFSET    3
-#define V5_L2C_CTL_DPFDPT_OFFSET    5
-#define V5_L2C_CTL_TRAMOCTL_OFFSET  8
-#define V5_L2C_CTL_TRAMICTL_OFFSET  10
-#define V5_L2C_CTL_DRAMOCTL_OFFSET  11
-#define V5_L2C_CTL_DRAMICTL_OFFSET  13
-
-#define V5_L2C_CTL_ENABLE_MASK      (1UL << V5_L2C_CTL_ENABLE_OFFSET)
-#define V5_L2C_CTL_IPFDPT_MASK      (3UL << V5_L2C_CTL_IPFDPT_OFFSET)
-#define V5_L2C_CTL_DPFDPT_MASK      (3UL << V5_L2C_CTL_DPFDPT_OFFSET)
-#define V5_L2C_CTL_TRAMOCTL_MASK    (3UL << V5_L2C_CTL_TRAMOCTL_OFFSET)
-#define V5_L2C_CTL_TRAMICTL_MASK    (1UL << V5_L2C_CTL_TRAMICTL_OFFSET)
-#define V5_L2C_CTL_DRAMOCTL_MASK    (3UL << V5_L2C_CTL_DRAMOCTL_OFFSET)
-#define V5_L2C_CTL_DRAMICTL_MASK    (1UL << V5_L2C_CTL_DRAMICTL_OFFSET)
-
 #endif /* _AE350_PLATFORM_H_ */
Signature · 1 line
2.17.1

Hi Prabhakar,

LGTM.

Thanks,
Peter Lin

author
#9 lore raw

RFC PATCH 4/7 lib: utils/irqchip: Add compatible string for Andestech NCEPLIC100

In reply to Prabhakar

From: Lad Prabhakar <[email protected]>

Add compatible string for Andestech NCEPLIC100 found on Renesas RZ/Five SoC which is equipped with AX45MP AndesCore.

While at it drop the comma after the sentinel as it does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel.

dts example (Single-core AX45MP):

    soc: soc {
          ....

          plic: interrupt-controller at 12c00000 {
              compatible = "renesas,r9a07g043-plic", "andestech,nceplic100";
              #interrupt-cells = <2>;
              #address-cells = <0>;
              riscv,ndev = <511>;
              interrupt-controller;
              reg = <0x0 0x12c00000 0 0x400000>;
              clocks = <&cpg CPG_MOD R9A07G043_NCEPLIC_ACLK>;
              power-domains = <&cpg>;
              resets = <&cpg R9A07G043_NCEPLIC_ARESETN>;
              interrupts-extended = <&cpu0_intc 11 &cpu0_intc 9>;
        };

         ....
    };
---
 lib/utils/irqchip/fdt_irqchip_plic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/utils/irqchip/fdt_irqchip_plic.c +2 -1
index a6e185c..83d091a 100644
@@ -163,7 +163,8 @@ static const struct fdt_match irqchip_plic_match[] = {
 	{ .compatible = "sifive,plic-1.0.0" },
 	{ .compatible = "thead,c900-plic",
 	  .data = thead_plic_plat_init },
-	{ },
+	{ .compatible = "andestech,nceplic100" },
+	{ /* sentinel */ }
 };
 
 struct fdt_irqchip fdt_irqchip_plic = {
Signature · 1 line
2.17.1
author
#10 lore raw

RFC PATCH 5/7 platform: Add Renesas RZ/Five initial support

In reply to Prabhakar

From: Lad Prabhakar <[email protected]>

This commit provides basic support for the Renesas RZ/Five SoC.

The RZ/Five microprocessor includes a RISC-V CPU Core (AX45MP Single).

Useful links:
-------------
[0] https://www.renesas.com/us/en/products/microcontrollers-microprocessors/rz-mpus/rzfive-risc-v-general-purpose-microprocessors-risc-v-cpu-core-andes-ax45mp-single-10-ghz-2ch-gigabit-ethernet
[1] http://www.andestech.com/en/products-solutions/andescore-processors/riscv-ax45mp/

---
 platform/renesas/rzfive/Kconfig           |  32 +++++
 platform/renesas/rzfive/configs/defconfig |   0
 platform/renesas/rzfive/objects.mk        |  18 +++
 platform/renesas/rzfive/platform.c        | 161 ++++++++++++++++++++++
 platform/renesas/rzfive/platform.h        |  24 ++++
 5 files changed, 235 insertions(+)
 create mode 100644 platform/renesas/rzfive/Kconfig
 create mode 100644 platform/renesas/rzfive/configs/defconfig
 create mode 100644 platform/renesas/rzfive/objects.mk
 create mode 100644 platform/renesas/rzfive/platform.c
 create mode 100644 platform/renesas/rzfive/platform.h
platform/renesas/rzfive/Kconfig new file +32 -0
new file mode 100644
index 0000000..c5e8a19
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: BSD-2-Clause
+
+config PLATFORM_RENESAS_RZFIVE
+	bool
+	select FDT
+	select FDT_SERIAL
+	select FDT_SERIAL_RENESAS_SCIF
+	select FDT_TIMER
+	select FDT_TIMER_PLMT
+	select FDT_IRQCHIP
+	select FDT_IRQCHIP_PLIC
+	select FDT_IPI
+	select FDT_IPI_PLICSW
+	default y
+
+if PLATFORM_RENESAS_RZFIVE
+
+config PLATFORM_RENESAS_RZFIVE_NAME
+	string "Platform default name"
+	default "Renesas RZ/Five"
+
+config PLATFORM_RENESAS_RZFIVE_MAJOR_VER
+	int "Platform major version"
+	range 0 65535
+	default 0
+
+config PLATFORM_RENESAS_RZFIVE_MINOR_VER
+	int "Platform minor version"
+	range 0 65535
+	default 1
+
+endif
platform/renesas/rzfive/configs/defconfig new file +0 -0
new file mode 100644
index 0000000..e69de29
platform/renesas/rzfive/objects.mk new file +18 -0
new file mode 100644
index 0000000..302b3d6
@@ -0,0 +1,18 @@
+#
+# SPDX-License-Identifier: BSD-2-Clause
+#
+# Copyright (C) 2022 Renesas Electronics Corp.
+#
+
+# Compiler flags
+platform-cppflags-y =
+platform-cflags-y =
+platform-asflags-y =
+platform-ldflags-y =
+
+# Objects to build
+platform-objs-y += ../../andes/ae350/cache.o platform.o
+
+# Blobs to build
+FW_TEXT_START=0x00000000
+FW_DYNAMIC=y
platform/renesas/rzfive/platform.c new file +161 -0

161 lines not on this page · raw message

platform/renesas/rzfive/platform.h new file +24 -0
new file mode 100644
index 0000000..e46ca91
@@ -0,0 +1,24 @@
+/* SPDX-License-Identifier: BSD-2-Clause
+ *
+ * Copyright (C) 2022 Renesas Electronics Corp.
+ */
+
+#ifndef _RZFIVE_PLATFORM_H_
+#define _RZFIVE_PLATFORM_H_
+
+#include "../../andes/ae350/common-platform.h"
+
+enum sbi_ext_andes_fid {
+	SBI_EXT_RENESAS_RZFIVE_GET_MCACHE_CTL_STATUS = 0,
+	SBI_EXT_RENESAS_RZFIVE_GET_MMISC_CTL_STATUS,
+	SBI_EXT_RENESAS_RZFIVE_SET_MCACHE_CTL,
+	SBI_EXT_RENESAS_RZFIVE_SET_MMISC_CTL,
+	SBI_EXT_RENESAS_RZFIVE_ICACHE_OP,
+	SBI_EXT_RENESAS_RZFIVE_DCACHE_OP,
+	SBI_EXT_RENESAS_RZFIVE_L1CACHE_I_PREFETCH,
+	SBI_EXT_RENESAS_RZFIVE_L1CACHE_D_PREFETCH,
+	SBI_EXT_RENESAS_RZFIVE_NON_BLOCKING_LOAD_STORE,
+	SBI_EXT_RENESAS_RZFIVE_WRITE_AROUND,
+};
+
+#endif /* _RZFIVE_PLATFORM_H_ */
Signature · 1 line
2.17.1
author
#11 lore raw

RFC PATCH 6/7 scripts: Add Renesas RZ/Five to platform list in the binary archive script

In reply to Prabhakar

From: Lad Prabhakar <[email protected]>

This patch adds Renesas RZ/Five to RV64 platform list in the binary archive script.

---
 scripts/create-binary-archive.sh | 1 +
 1 file changed, 1 insertion(+)
scripts/create-binary-archive.sh +1 -0
index 261a45a..28a5b2f 100755
@@ -104,6 +104,7 @@ build_opensbi() {
 		BUILD_PLATFORM_SUBDIR+=("fpga/ariane")
 		BUILD_PLATFORM_SUBDIR+=("fpga/openpiton")
 		BUILD_PLATFORM_SUBDIR+=("andes/ae350")
+		BUILD_PLATFORM_SUBDIR+=("renesas/rzfive")
 		BUILD_PLATFORM_SUBDIR+=("generic")
 		;;
 	*)
Signature · 1 line
2.17.1
author
#12 lore raw

RFC PATCH 7/7 docs: platform: Add documentation for Renesas RZ/Five SoC

In reply to Prabhakar

From: Lad Prabhakar <[email protected]>

This patch adds documentation to build Renesas RZ/Five SoC.

---
 docs/platform/platform.md       |   4 +
 docs/platform/renesas-rzfive.md | 139 ++++++++++++++++++++++++++++++++
 2 files changed, 143 insertions(+)
 create mode 100644 docs/platform/renesas-rzfive.md
docs/platform/platform.md +4 -0
index f291931..a4c1864 100644
@@ -39,6 +39,9 @@ OpenSBI currently supports the following virtual and hardware platforms:
   processor based SOCs. More details on this platform can be found in the
   file *[shakti_cclass.md]*.
 
+* **Renesas RZ/Five SoC**: Platform support for the Renesas RZ/Five SoC (R9A07G043F).
+  More details on this platform can be found in the file *[renesas-rzfive.md]*.
+
 The code for these supported platforms can be used as example to implement
 support for other platforms. The *platform/template* directory also provides
 template files for implementing support for a new platform. The *objects.mk*,
@@ -54,3 +57,4 @@ comments to facilitate the implementation.
 [spike.md]: spike.md
 [fpga-openpiton.md]: fpga-openpiton.md
 [shakti_cclass.md]: shakti_cclass.md
+[renesas-rzfive.md]: renesas-rzfive.md
docs/platform/renesas-rzfive.md new file +139 -0

139 lines not on this page · raw message

Signature · 1 line
2.17.1
#13 lore raw

cover Add support for Renesas RZ/Five SoC

In reply to Prabhakar
Quoted 11 lines · Prabhakar

From: Lad Prabhakar <[email protected]>

Hi All,

This patch series adds initial support to RZ/Five SoC (which is equipped with AX45MP AndesCore). Platform supports DT based probing.

Linux support is currently being upstreamed the latest patchset can be found at [0].(DT bindings can be seen here)

Quoted 8 lines

[0] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20220920184904.90495-1-prabhakar.mahadev-lad.rj at bp.renesas.com/

- PLIC binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml#L57
- PLMT and PLICSW are not used by any driver in kernel hence DT bindings for it
and is used in a similar manner as compared Andes AE350 [1]
[1] https://github.com/andestech/linux/commits/v6.0.y_ae350-ax45mp/Documentation/devicetree/bindings
- SCIF binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/serial/renesas,scif.yaml#L79

Gentle ping for review.

Cheers,
Prabhakar

Quoted 118 lines

Below are the logs for U-Boot (2022.10) and OpenSBI:
--------------------------------------------------
U-Boot SPL 2022.10-00192-g0cf0a0919b-dirty (Oct 28 2022 - 01:09:54 +0100) Trying to boot from NOR

OpenSBI v1.1-87-gc46891e
____ _____ ____ _____

  / __ \                  / ____|  _ \_   _|
 | |  | |_ __   ___ _ __ | (___ | |_) || |
 | |  | | '_ \ / _ \ '_ \ \___ \|  _ < | |
 | |__| | |_) |  __/ | | |____) | |_) || |_
  \____/| .__/ \___|_| |_|_____/|____/_____|
        | |
        |_|

Platform Name : smarc-rzfZ/Five
Platform Features : medeleg
Platform HART Count : 1
Platform IPI Device : andes_plicsw
Platform Timer Device : andes_plmt @ 12000000Hz
Platform Console Device : renesas_scif
Platform HSM Device : ---
Platform PMU Device : ---
Platform Reboot Device : ---
Platform Shutdown Device : ---
Firmware Base : 0x44000000
Firmware Size : 152 KB
Runtime SBI Version : 1.0

Domain0 Name : root
Domain0 Boot HART : 0
Domain0 HARTs : 0*
Domain0 Region00 : 0x00000000110c0000-0x00000000110fffff (I,R)
Domain0 Region01 : 0x0000000011180000-0x00000000111bffff (I,R)
Domain0 Region02 : 0x0000000044000000-0x000000004403ffff ()
Domain0 Region03 : 0x0000000011100000-0x000000001117ffff (I,R)
Domain0 Region04 : 0x0000000013000000-0x00000000133fffff (I)
Domain0 Region05 : 0x0000000000000000-0xffffffffffffffff (R,W,X)
Domain0 Next Address : 0x0000000050000000
Domain0 Next Arg1 : 0x00000000500be568
Domain0 Next Mode : S-mode
Domain0 SysReset : yes

Boot HART ID : 0
Boot HART Domain : root
Boot HART Priv Version : v1.11
Boot HART Base ISA : rv64imafdcnx
Boot HART ISA Extensions : none
Boot HART PMP Count : 16
Boot HART PMP Granularity : 8
Boot HART PMP Address Bits: 36
Boot HART MHPM Count : 4
Boot HART MIDELEG : 0x0000000000000222
Boot HART MEDELEG : 0x000000000000b109

U-Boot 2022.10-00192-g0cf0a0919b-dirty (Oct 28 2022 - 01:09:54 +0100)

CPU:   rv64imafdc
Model: smarc-rzf
DRAM:  896 MiB
SW_ET0_EN: OFFCore:  30 devices, 18 uclasses, devicetree: separate
MMC:   sd at 11c00000: 0, sd at 11c10000: 1
Loading Environment from MMC... OK
In:    serial at 1004b800
Out:   serial at 1004b800
Err:   serial at 1004b800
Net:   eth0: ethernet at 11c30000
Hit any key to stop autoboot:  0

=>
--------------------------------------------------

Cheers,
Prabhakar

Lad Prabhakar (7):
lib: utils: serial: Add Renesas SCIF driver
lib: utils: serial: Add FDT driver for Renesas SCIF
platform: andes/ae350: Split header platform.h header file
lib: utils/irqchip: Add compatible string for Andestech NCEPLIC100
platform: Add Renesas RZ/Five initial support
scripts: Add Renesas RZ/Five to platform list in the binary archive
script
docs: platform: Add documentation for Renesas RZ/Five SoC

 docs/platform/platform.md                  |   4 +
 docs/platform/renesas-rzfive.md            | 139 ++++++++++++++++++
 include/sbi_utils/fdt/fdt_helper.h         |   3 +
 include/sbi_utils/serial/renesas-scif.h    |  11 ++
 lib/utils/fdt/fdt_helper.c                 |  23 +++
 lib/utils/irqchip/fdt_irqchip_plic.c       |   3 +-
 lib/utils/serial/Kconfig                   |   9 ++
 lib/utils/serial/fdt_serial_renesas_scif.c |  31 ++++
 lib/utils/serial/objects.mk                |   4 +
 lib/utils/serial/renesas_scif.c            | 140 ++++++++++++++++++
 platform/andes/ae350/common-platform.h     |  94 ++++++++++++
 platform/andes/ae350/platform.h            |  82 +----------
 platform/renesas/rzfive/Kconfig            |  32 ++++
 platform/renesas/rzfive/configs/defconfig  |   0
 platform/renesas/rzfive/objects.mk         |  18 +++
 platform/renesas/rzfive/platform.c         | 161 +++++++++++++++++++++
 platform/renesas/rzfive/platform.h         |  24 +++
 scripts/create-binary-archive.sh           |   1 +
 18 files changed, 698 insertions(+), 81 deletions(-)
 create mode 100644 docs/platform/renesas-rzfive.md
 create mode 100644 include/sbi_utils/serial/renesas-scif.h
 create mode 100644 lib/utils/serial/fdt_serial_renesas_scif.c
 create mode 100644 lib/utils/serial/renesas_scif.c
 create mode 100644 platform/andes/ae350/common-platform.h
 create mode 100644 platform/renesas/rzfive/Kconfig
 create mode 100644 platform/renesas/rzfive/configs/defconfig
 create mode 100644 platform/renesas/rzfive/objects.mk
 create mode 100644 platform/renesas/rzfive/platform.c
 create mode 100644 platform/renesas/rzfive/platform.h

--
2.17.1

#14 lore raw

cover Add support for Renesas RZ/Five SoC

Hi,

Quoted 21 lines · Prabhakar
Quoted 11 lines · Prabhakar

From: Lad Prabhakar <[email protected]>

Hi All,

This patch series adds initial support to RZ/Five SoC (which is equipped with AX45MP AndesCore). Platform supports DT based probing.

Linux support is currently being upstreamed the latest patchset can be found at [0].(DT bindings can be seen here)

Quoted 8 lines

[0] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20220920184904.90495-1-prabhakar.mahadev-lad.rj at bp.renesas.com/

- PLIC binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml#L57
- PLMT and PLICSW are not used by any driver in kernel hence DT bindings for it
and is used in a similar manner as compared Andes AE350 [1]
[1] https://github.com/andestech/linux/commits/v6.0.y_ae350-ax45mp/Documentation/devicetree/bindings
- SCIF binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/serial/renesas,scif.yaml#L79

Quoted 9 lines

Gentle ping for review.

Cheers,
Prabhakar

Quoted 4 lines

Below are the logs for U-Boot (2022.10) and OpenSBI:
--------------------------------------------------
U-Boot SPL 2022.10-00192-g0cf0a0919b-dirty (Oct 28 2022 - 01:09:54 +0100) Trying to boot from NOR

Has U-Boot support been upstreamed?

Quoted 54 lines
Quoted 54 lines

OpenSBI v1.1-87-gc46891e
____ _____ ____ _____

  / __ \                  / ____|  _ \_   _|
 | |  | |_ __   ___ _ __ | (___ | |_) || |
 | |  | | '_ \ / _ \ '_ \ \___ \|  _ < | |
 | |__| | |_) |  __/ | | |____) | |_) || |_
  \____/| .__/ \___|_| |_|_____/|____/_____|
        | |
        |_|

Platform Name : smarc-rzfZ/Five
Platform Features : medeleg
Platform HART Count : 1
Platform IPI Device : andes_plicsw
Platform Timer Device : andes_plmt @ 12000000Hz
Platform Console Device : renesas_scif
Platform HSM Device : ---
Platform PMU Device : ---
Platform Reboot Device : ---
Platform Shutdown Device : ---
Firmware Base : 0x44000000
Firmware Size : 152 KB
Runtime SBI Version : 1.0

Domain0 Name : root
Domain0 Boot HART : 0
Domain0 HARTs : 0*
Domain0 Region00 : 0x00000000110c0000-0x00000000110fffff (I,R)
Domain0 Region01 : 0x0000000011180000-0x00000000111bffff (I,R)
Domain0 Region02 : 0x0000000044000000-0x000000004403ffff ()
Domain0 Region03 : 0x0000000011100000-0x000000001117ffff (I,R)
Domain0 Region04 : 0x0000000013000000-0x00000000133fffff (I)
Domain0 Region05 : 0x0000000000000000-0xffffffffffffffff (R,W,X)
Domain0 Next Address : 0x0000000050000000
Domain0 Next Arg1 : 0x00000000500be568
Domain0 Next Mode : S-mode
Domain0 SysReset : yes

Boot HART ID : 0
Boot HART Domain : root
Boot HART Priv Version : v1.11
Boot HART Base ISA : rv64imafdcnx
Boot HART ISA Extensions : none
Boot HART PMP Count : 16
Boot HART PMP Granularity : 8
Boot HART PMP Address Bits: 36
Boot HART MHPM Count : 4
Boot HART MIDELEG : 0x0000000000000222
Boot HART MEDELEG : 0x000000000000b109

U-Boot 2022.10-00192-g0cf0a0919b-dirty (Oct 28 2022 - 01:09:54 +0100)

Quoted 14 lines
Quoted 11 lines
CPU:   rv64imafdc
Model: smarc-rzf
DRAM:  896 MiB
SW_ET0_EN: OFFCore:  30 devices, 18 uclasses, devicetree: separate
MMC:   sd at 11c00000: 0, sd at 11c10000: 1
Loading Environment from MMC... OK
In:    serial at 1004b800
Out:   serial at 1004b800
Err:   serial at 1004b800
Net:   eth0: ethernet at 11c30000
Hit any key to stop autoboot:  0
Quoted 3 lines

=>
--------------------------------------------------

Regards,
Bin

#15 lore raw

cover Add support for Renesas RZ/Five SoC

Hi,

Quoted 31 lines · Bin Meng

Hi,

Quoted 26 lines · Prabhakar
Quoted 11 lines · Prabhakar

From: Lad Prabhakar <[email protected]>

Hi All,

This patch series adds initial support to RZ/Five SoC (which is equipped with AX45MP AndesCore). Platform supports DT based probing.

Linux support is currently being upstreamed the latest patchset can be found at [0].(DT bindings can be seen here)

Quoted 8 lines

[0] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20220920184904.90495-1-prabhakar.mahadev-lad.rj at bp.renesas.com/

- PLIC binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml#L57
- PLMT and PLICSW are not used by any driver in kernel hence DT bindings for it
and is used in a similar manner as compared Andes AE350 [1]
[1] https://github.com/andestech/linux/commits/v6.0.y_ae350-ax45mp/Documentation/devicetree/bindings
- SCIF binding - https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/serial/renesas,scif.yaml#L79

Gentle ping for review.

Cheers,
Prabhakar

Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

Below are the logs for U-Boot (2022.10) and OpenSBI:
--------------------------------------------------
U-Boot SPL 2022.10-00192-g0cf0a0919b-dirty (Oct 28 2022 - 01:09:54 +0100) Trying to boot from NOR

Has U-Boot support been upstreamed?

It's in the pipeline (and should be done soon as you can see we are on the latest u-boot release). I can share the repo link if you need.

Cheers,
Prabhakar