MAINTAINERS: add keyword match on PTP
Subsystems (2)
Jakub Kicinski
maintainerPATCH 1/1 MAINTAINERS: add keyword match on PTP
Most of PTP drivers live under ethernet and we have to keep telling people to CC the PTP maintainers. Let's try a keyword match, we can refine as we go if it causes false positives.
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -16673,6 +16673,7 @@ F: Documentation/driver-api/ptp.rst F: drivers/net/phy/dp83640* F: drivers/ptp/* F: include/linux/ptp_cl* +K: (?:\b|_)ptp(?:\b|_) PTP VIRTUAL CLOCK SUPPORT M: Yangbo Lu <[email protected]>
Signature · 1 line
2.37.3
Quoted 3 lines · Jakub Kicinski
Most of PTP drivers live under ethernet and we have to keep telling people to CC the PTP maintainers. Let's try a keyword match, we can refine as we go if it causes false positives.
This is great, thanks!
Richard
Quoted 14 lines · Jakub Kicinski
Most of PTP drivers live under ethernet and we have to keep telling people to CC the PTP maintainers. Let's try a keyword match, we can refine as we go if it causes false positives.
Signed-off-by Jakub Kicinski <[email protected]>--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)MAINTAINERS +0
-0
MAINTAINERS F: Documentation/driver-api/ptp.rst · line 16676
Quoted 4 lines
MAINTAINERS +1
-0@@ -16673,6 +16673,7 @@ F: Documentation/driver-api/ptp.rst F: drivers/net/phy/dp83640* F: drivers/ptp/* F: include/linux/ptp_cl* +K: (?:\b|_)ptp(?:\b|_)
I tried it with grep (maybe it is wrong) and it finds only files with underscores.
➜ kernel git:(m/xfrm-latest) tree | grep -E "(?:\b|_)ptp(?:\b|_)"
│ │ │ │ │ ├── ice_ptp_consts.h │ │ │ │ │ ├── ice_ptp_hw.c │ │ │ │ │ ├── ice_ptp_hw.h
And this is as it is written in MAINTAINERS without "_".
➜ kernel git:(m/xfrm-latest) tree | grep -E "\bptp\b"
│ │ ├── sysfs-ptp │ │ │ │ ├── intel,ixp46x-ptp-timer.yaml │ │ │ ├── ptp │ │ │ │ ├── brcm,ptp-dte.txt │ │ │ │ ├── ptp-idt82p33.yaml │ │ │ │ ├── ptp-idtcm.yaml │ │ │ │ ├── ptp-ines.txt │ │ │ │ ├── ptp-qoriq.txt │ │ ├── ptp.rst │ │ │ │ ├── ptp.c │ │ │ │ ├── ptp.h │ │ │ │ └── xgbe-ptp.c │ │ │ │ │ ├── dpaa2-ptp.c │ │ │ │ │ ├── dpaa2-ptp.h │ │ │ │ │ ├── ptp.c │ │ │ │ │ │ ├── ptp.c │ │ │ │ │ │ ├── ptp.h │ │ │ │ │ │ ├── ptp.c │ │ │ │ │ │ ├── ptp.h │ │ │ │ ├── ptp.c │ │ │ │ ├── ptp.h │ │ │ │ │ ├── ptp.c │ │ │ │ │ ├── ptp.h │ │ │ ├── bcm-phy-ptp.c
Should I try it differently?
Thanks
Quoted 6 lines
MAINTAINERS +0
-0PTP VIRTUAL CLOCK SUPPORT M: Yangbo Lu <[email protected]>Signature · 1 line
2.37.3
Quoted 56 lines · Leon Romanovsky
Quoted 14 lines · Jakub Kicinski
Most of PTP drivers live under ethernet and we have to keep telling people to CC the PTP maintainers. Let's try a keyword match, we can refine as we go if it causes false positives.
Signed-off-by Jakub Kicinski <[email protected]>--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)MAINTAINERS +0
-0MAINTAINERS F: Documentation/driver-api/ptp.rst · line 16676
Quoted 4 lines
MAINTAINERS +1
-0@@ -16673,6 +16673,7 @@ F: Documentation/driver-api/ptp.rst F: drivers/net/phy/dp83640* F: drivers/ptp/* F: include/linux/ptp_cl* +K: (?:\b|_)ptp(?:\b|_)I tried it with grep (maybe it is wrong) and it finds only files with underscores.
➜ kernel git:(m/xfrm-latest) tree | grep -E "(?:\b|_)ptp(?:\b|_)"
│ │ │ │ │ ├── ice_ptp_consts.h │ │ │ │ │ ├── ice_ptp_hw.c │ │ │ │ │ ├── ice_ptp_hw.hAnd this is as it is written in
MAINTAINERSwithout "_".➜ kernel git:(m/xfrm-latest) tree | grep -E "\bptp\b"
│ │ ├── sysfs-ptp │ │ │ │ ├── intel,ixp46x-ptp-timer.yaml │ │ │ ├── ptp │ │ │ │ ├── brcm,ptp-dte.txt │ │ │ │ ├── ptp-idt82p33.yaml │ │ │ │ ├── ptp-idtcm.yaml │ │ │ │ ├── ptp-ines.txt │ │ │ │ ├── ptp-qoriq.txt │ │ ├── ptp.rst │ │ │ │ ├── ptp.c │ │ │ │ ├── ptp.h │ │ │ │ └── xgbe-ptp.c │ │ │ │ │ ├── dpaa2-ptp.c │ │ │ │ │ ├── dpaa2-ptp.h │ │ │ │ │ ├── ptp.c │ │ │ │ │ │ ├── ptp.c │ │ │ │ │ │ ├── ptp.h │ │ │ │ │ │ ├── ptp.c │ │ │ │ │ │ ├── ptp.h │ │ │ │ ├── ptp.c │ │ │ │ ├── ptp.h │ │ │ │ │ ├── ptp.c │ │ │ │ │ ├── ptp.h │ │ │ ├── bcm-phy-ptp.c
Quoted 1 line
Should I try it differently?
And maybe "K: ptp" will be even better.
Quoted 9 lines
Thanks
Quoted 6 lines
MAINTAINERS +0
-0PTP VIRTUAL CLOCK SUPPORT M: Yangbo Lu <[email protected]>Signature · 1 line
2.37.3
Jakub Kicinski
maintainerQuoted 1 line · On Thu, 20 Oct 2022 09:12:20 +0300 Leon Romanovsky wrote:
Quoted 1 line
Should I try it differently?
I think these are supposed to be Perl regexps:
K: *Content regex* (perl extended) pattern match in a patch or file.
IOW try grep -P rather than grep -E.
Quoted 1 line
And maybe "K: ptp" will be even better.
That may be too wide, for instance it matches PPTP :(
Quoted 8 lines · Jakub Kicinski
Quoted 1 line · On Thu, 20 Oct 2022 09:12:20 +0300 Leon Romanovsky wrote:
Quoted 1 line
Should I try it differently?
I think these are supposed to be Perl regexps:
K: *Content regex* (perl extended) pattern match in a patch or file.
IOW try grep -P rather than grep -E.
Tried now, it works, thanks.
Quoted 4 lines
Quoted 2 lines
And maybe "K: ptp" will be even better.
That may be too wide, for instance it matches PPTP :(
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Wed, 19 Oct 2022 19:19:13 -0700 you wrote:
Most of PTP drivers live under ethernet and we have to keep telling people to CC the PTP maintainers. Let's try a keyword match, we can refine as we go if it causes false positives.
Signed-off-by Jakub Kicinski <[email protected]>--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
Here is the summary with links:
- [net] MAINTAINERS: add keyword match on PTP
https://git.kernel.org/netdev/net/c/4d814b329a4d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html