staging: rtl8723bs: clean up driver code in rtw_ioctl_set

Fix the following checkpatch warnings in rtw_ioctl_set:
1) Add missing blankline after declaration
2) Replace spaces used for indent with tab
3) Remove space before tab

Signed-off-by Emily Peri <[email protected]>

---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -0

index 8c11daff2d59..354e61a8f2bd 100644
@@ -78,6 +78,7 @@ u8 rtw_do_join(struct adapter *padapter)
 		goto exit;
 	} else {
 		int select_ret;
+
 		spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
 		select_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
 		if (select_ret == _SUCCESS) {

Quoted 22 lines · Emily Peri

Fix the following checkpatch warnings in rtw_ioctl_set:
1) Add missing blankline after declaration
2) Replace spaces used for indent with tab
3) Remove space before tab

Signed-off-by Emily Peri <[email protected]>

---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -0

index 8c11daff2d59..354e61a8f2bd 100644
@@ -78,6 +78,7 @@ u8 rtw_do_join(struct adapter *padapter)
 		goto exit;
 	} else {
 		int select_ret;
+
 		spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
 		select_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
 		if (select_ret == _SUCCESS) {

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter, · line 315

Quoted 6 lines

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -1

@@ -311,7 +312,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
 		if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
 			if (check_fwstate(pmlmepriv, _FW_LINKED) == true)
 				rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have checked whether issue dis-assoc_cmd or not */
-	       }
+		}

I think indentation is wrong here, it should be only 1 tab instead of 2 tabs ?

Quoted 11 lines

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -1

 		*pold_state = networktype;
 

@@ -367,7 +368,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter)
 
 u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_802_11_ssid *pssid, int ssid_max_num)
 {
-	struct	mlme_priv 	*pmlmepriv = &padapter->mlmepriv;
+	struct	mlme_priv	*pmlmepriv = &padapter->mlmepriv;
 	u8 res = true;
 

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c u8 rtw_set_802_11_disassociate(struct adapter *padapter) · line 374

Quoted 1 line

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +0 -0

 	if (!padapter) {

Regards,

~Praveen.

Quoted 11 lines

Quoted 11 lines

  
  		*pold_state = networktype;

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -1

@@ -367,7 +368,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter)
 
  u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_802_11_ssid *pssid, int ssid_max_num)
  {
-	struct	mlme_priv 	*pmlmepriv = &padapter->mlmepriv;
+	struct	mlme_priv	*pmlmepriv = &padapter->mlmepriv;
  	u8 res = true;
 

Quoted 5 lines

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c u8 rtw_set_802_11_disassociate(struct adapter *padapter) · line 374

Quoted 1 line

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +0 -0

  	if (!padapter) {

Regards,

~Praveen.

Now that I think about-- in this last edit I removed a space to appease checkpatch, but maybe I actually should have removed the tab?

Fix the following checkpatch warnings in rtw_ioctl_set:
1) Add missing blankline after declaration
2) Replace spaces used for indent with tab
3) Remove space before tab

Quoted 4 lines · Emily Peri

Fix the following checkpatch warnings in rtw_ioctl_set:
1) Add missing blankline after declaration
2) Replace spaces used for indent with tab
3) Remove space before tab

When you have to list the different things you do, you should really break that up into individual patches. This should be 3.

thanks,

greg k-h

Quoted 11 lines · Greg KH

Quoted 4 lines · Emily Peri

Fix the following checkpatch warnings in rtw_ioctl_set:
1) Add missing blankline after declaration
2) Replace spaces used for indent with tab
3) Remove space before tab

When you have to list the different things you do, you should really break that up into individual patches. This should be 3.

thanks,

Quoted 1 line

greg k-h

Thanks greg for the feedback! I got the idea to put them all in the same patch from the PatchPhilosophy guide, which suggested combining a bunch of white space corrections into one commit. But, it sounds like I misinterpreted what the guide was saying. Maybe if there are identical warnings, such as "trailing white space" in the driver code, could those corrections go together in a single patch?