Skip to contentSkip to conversation

staging: rtl8192u: Provide a TODO file for this driver

PATCH In review Peter Robinson 2 participants 6 messages Oct 16, 2022 – Oct 20, 2022 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 staging: rtl8192u: Provide a TODO file for this driver

Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging. It's missing from original addition of this driver.

---
 drivers/staging/rtl8192u/TODO | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 drivers/staging/rtl8192u/TODO
drivers/staging/rtl8192u/TODO new file +16 -0
new file mode 100644
index 000000000000..ab9d5d145b3b
@@ -0,0 +1,16 @@
+To-do list:
+
+* Correct the coding style according to Linux guidelines; please read the document
+  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+  the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
+* Switch to use CFG80211.
+* Improve the error handling of various functions, particularly those that use
+  existing kernel APIs.
Signature · 1 line
2.37.3
#1 lore raw

PATCH 2/4 staging: rtl8192e: Update the TODO file for this driver

The driver directory where it was proposed to move to has changed, while add it add some more pieces this driver to update.

---
 drivers/staging/rtl8192e/TODO | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
drivers/staging/rtl8192e/TODO +17 -1
index d51f159d1adf..7221ae65d63e 100644
@@ -1,2 +1,18 @@
-* merge into drivers/net/wireless/rtllib/rtl8192e
+To-do list:
+
+* merge into drivers/net/wireless/realtek/rtlwifi/rtl8192*
 * clean up function naming
+* Correct the coding style according to Linux guidelines; please read the document
+  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+  the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
+* Switch to use CFG80211.
+* Improve the error handling of various functions, particularly those that use
+  existing kernel APIs.
Signature · 1 line
2.37.3
#2 lore raw

PATCH 3/4 staging: ks7010: Update the TODO file for this driver

In reply to Peter Robinson

Add move to mac80211 from wext to the todo for this driver.

---
 drivers/staging/ks7010/TODO | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/ks7010/TODO +3 -0
index ab6f39175d99..80c97543b977 100644
@@ -27,6 +27,9 @@ Now the TODOs:
 - fix the 'card removal' event when card is inserted when booting
 - check what other upstream wireless mechanisms can be used instead of the
   custom ones here
+- Switch to use LIB80211.
+- Switch to use MAC80211.
+- Switch to use CFG80211.
 
 Please send any patches to:
 Greg Kroah-Hartman <[email protected]>
Signature · 1 line
2.37.3
#3 lore raw

PATCH 4/4 staging: wlan-ng: Provide a TODO file for this driver

In reply to Peter Robinson

Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging. It's missing from original addition of this driver.

---
 drivers/staging/wlan-ng/TODO | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 drivers/staging/wlan-ng/TODO
drivers/staging/wlan-ng/TODO new file +16 -0
new file mode 100644
index 000000000000..ab9d5d145b3b
@@ -0,0 +1,16 @@
+To-do list:
+
+* Correct the coding style according to Linux guidelines; please read the document
+  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+  the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
+* Switch to use CFG80211.
+* Improve the error handling of various functions, particularly those that use
+  existing kernel APIs.
Signature · 1 line
2.37.3
#4 lore raw
In reply to Peter Robinson
Quoted 22 lines · Peter Robinson

Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging. It's missing from original addition of this driver.

---
 drivers/staging/rtl8192u/TODO | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 drivers/staging/rtl8192u/TODO
drivers/staging/rtl8192u/TODO new file +6 -0
new file mode 100644
index 000000000000..ab9d5d145b3b
@@ -0,0 +1,16 @@
+To-do list:
+
+* Correct the coding style according to Linux guidelines; please read the document
+  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).

drivers/staging/rtl8192u/TODO line 16

Quoted 10 lines
drivers/staging/rtl8192u/TODO new file +10 -0
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+  the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
+* Switch to use CFG80211.
+* Improve the error handling of various functions, particularly those that use
+  existing kernel APIs.

Where did this list come from?

How do you know they are all needed?

thanks,

greg k-h

#5 lore raw
Quoted 37 lines · Greg Kroah-Hartman
Quoted 22 lines · Peter Robinson

Provide a TODO file that lists the tasks that should be carried out in order to move this driver off drivers/staging. It's missing from original addition of this driver.

---
 drivers/staging/rtl8192u/TODO | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 drivers/staging/rtl8192u/TODO
drivers/staging/rtl8192u/TODO new file +6 -0
new file mode 100644
index 000000000000..ab9d5d145b3b
@@ -0,0 +1,16 @@
+To-do list:
+
+* Correct the coding style according to Linux guidelines; please read the document
+  at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+  use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).

drivers/staging/rtl8192u/TODO line 16

Quoted 10 lines
drivers/staging/rtl8192u/TODO new file +10 -0
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+  the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
+* Switch to use CFG80211.
+* Improve the error handling of various functions, particularly those that use
+  existing kernel APIs.

Where did this list come from?

Quoted 1 line

How do you know they are all needed?

It was based on the other real tek drivers that has a todo and some grep.