Skip to contentSkip to conversation

clean up driver code in rtw_ioctl_set

PATCH In review Emily Peri 2 participants 5 messages Oct 21, 2022 – Oct 22, 2022 Staging

lore
Share & tools
lore

Emily Peri

author
#0 lore raw

v2 cover clean up driver code in rtw_ioctl_set

Created patchset to fix all checkpatch warnings in rtw_ioctl_set

Changes since v1:

* Patch 1: "staging: rtl8723bs: remove tab in variable definition"
* Split previous white space patch into three separate patches (feedback from Gregh). Remove tab instead of space (feedback from Michael S and Praveen K)

* Patch 2: "staging: rtl8723bs: add newline after variable declaration"
* Split previous white space patch into three separate patches (feedback from Gregh).

* Patch 3: "staging: rtl8723bs: use tab instead of spaces for indent"
* Split previous white space patch into three separate patches (feedback from Gregh).

* Merged into Greg's tree "rtl8723bs: align block comment stars"

* Merged into Greg's tree "staging: rtl8723bs: remove unnecessary parenthesis"

Emily Peri (3):
staging: rtl8723bs: remove tab in variable definition
staging: rtl8723bs: add newline after variable declaration
staging: rtl8723bs: use tab instead of spaces for indent

 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v2 1/3 staging: rtl8723bs: remove tab in variable definition

Remove unnecessary tab in variable definition in rtw_ioctl_set. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -1
index 8c7daab141db..ede7d2930844 100644
@@ -367,7 +367,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter)
 
 u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_802_11_ssid *pssid, int ssid_max_num)
 {
-	struct	mlme_priv 	*pmlmepriv = &padapter->mlmepriv;
+	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	u8 res = true;
 
 	if (!padapter) {
Signature · 1 line
2.34.1
author
#2 lore raw

PATCH v2 2/3 staging: rtl8723bs: add newline after variable declaration

In reply to Emily Peri

Fix checkpatch style warning by adding newline after variable declaration in rtw_ioctl_set

---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -0
index ede7d2930844..47323160e72d 100644
@@ -78,6 +78,7 @@ u8 rtw_do_join(struct adapter *padapter)
 		goto exit;
 	} else {
 		int select_ret;
+
 		spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
 		select_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
 		if (select_ret == _SUCCESS) {
Signature · 1 line
2.34.1
author
#3 lore raw

PATCH v2 3/3 staging: rtl8723bs: use tab instead of spaces for indent

In reply to Emily Peri

Replace spaces with tab for indent and correct alignment for closing brace in rtw_ioctl_set. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +1 -1
index 47323160e72d..3b44f0dd5b0a 100644
@@ -312,7 +312,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
 		if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
 			if (check_fwstate(pmlmepriv, _FW_LINKED) == true)
 				rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have checked whether issue dis-assoc_cmd or not */
-	       }
+		}
 
 		*pold_state = networktype;
 
Signature · 1 line
2.34.1
maintainer
#4 lore raw
In reply to Emily Peri
Quoted 3 lines · Emily Peri

Created patchset to fix all checkpatch warnings in rtw_ioctl_set

Changes since v1:

In the future, please use the proper prefix ("staging: rtl8723bs:" in this case) for your 0/X emails.

thanks,

greg k-h